rhertogh\Yii2Oauth2Server\components\repositories\Oauth2UserRepository

Complexity

Total Complexity

10

Size/Duplication

Total Lines	72
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	getUserEntityByIdentifier()	0	16	3
A	getModelClass()	0	3	1
A	getUserEntityByUserCredentials()	0	36	6

<?php

namespace rhertogh\Yii2Oauth2Server\components\repositories;

use League\OAuth2\Server\Entities\ClientEntityInterface;
use rhertogh\Yii2Oauth2Server\components\repositories\base\Oauth2BaseRepository;
use rhertogh\Yii2Oauth2Server\interfaces\components\repositories\Oauth2UserRepositoryInterface;
use rhertogh\Yii2Oauth2Server\interfaces\models\Oauth2PasswordGrantUserInterface;
use rhertogh\Yii2Oauth2Server\interfaces\models\Oauth2UserInterface;
use yii\base\InvalidConfigException;

class Oauth2UserRepository extends Oauth2BaseRepository implements Oauth2UserRepositoryInterface
{
    /**
     * @inheritDoc
     * @return Oauth2UserInterface|string
     */
    public function getModelClass()
    {
        return $this->_module->identityClass;
    }

    /**
     * @inheritDoc
     */
    public function getUserEntityByIdentifier($identifier)
    {
        $userClass = $this->getModelClass();
        $user = $userClass::findIdentity($identifier);

        if (empty($user)) {
            return null;
        }

        if (!($user instanceof Oauth2UserInterface)) {
            throw new \TypeError(
                $userClass . '::findIdentity() must return an instance of ' . Oauth2UserInterface::class

Are you sure $userClass of type rhertogh\Yii2Oauth2Server\interfaces\models\Oauth2UserInterface can be used in concatenation? Consider adding a __toString()-method.

            );
        }

        return $user;
    }

    /**
     * @inheritDoc
     * @throws InvalidConfigException
     */
    public function getUserEntityByUserCredentials(
        $username,
        $password,
        $grantType,
        ClientEntityInterface $clientEntity
    ) {
        $userClass = $this->getModelClass();
        if (!is_a($userClass, Oauth2PasswordGrantUserInterface::class, true)) {
            throw new \TypeError(
                'In order to support the `password` grant type, ' . $userClass

Are you sure $userClass of type rhertogh\Yii2Oauth2Server\interfaces\models\Oauth2UserInterface can be used in concatenation? Consider adding a __toString()-method.

                    . ' must implement ' . Oauth2PasswordGrantUserInterface::class
            );
        }

        /** @var Oauth2UserInterface|null $user */
        $user = $userClass::findByUsername($username);

The method findByUsername() does not exist on rhertogh\Yii2Oauth2Server\interfaces\models\Oauth2UserInterface. It seems like you code against a sub-type of said class. However, the method does not exist in rhertogh\Yii2Oauth2Server\interfaces\models\Oauth2OidcUserInterface. Are you sure you never get one of those?

        if (empty($user)) {
            return null;
        }
        if (!($user instanceof Oauth2UserInterface)) {

$user is always a sub-type of rhertogh\Yii2Oauth2Server\interfaces\models\Oauth2UserInterface.

            throw new \TypeError(
                $userClass . '::findByUsername() must return an instance of ' . Oauth2UserInterface::class
            );
        }
        if (!($user instanceof Oauth2PasswordGrantUserInterface)) {
            throw new \TypeError(
                'In order to support the `password` grant type, ' . $userClass
                    . '::findByUsername() must return an instance of ' . Oauth2PasswordGrantUserInterface::class
            );
        }

        if ($user->validatePassword($password)) {
            return $user;
        }

        return null;
    }
}