rezzza / rest-api-behat-extension

src/RestApiContext.php

Spacing +2 added lines, -2 removed lines

@@ -101,8 +101,8 @@
      */
     public function iSetBasicAuthenticationWithAnd($username, $password)
     {
-        $authorization = base64_encode($username . ':' . $password);
-        $this->restApiBrowser->setRequestHeader('Authorization', 'Basic ' . $authorization);
+        $authorization = base64_encode($username.':'.$password);
+        $this->restApiBrowser->setRequestHeader('Authorization', 'Basic '.$authorization);
     }
 
     /**

Unused Use Statements -2 removed lines

@@ -6,8 +6,6 @@
 use Behat\Behat\Context\Context;
 use Behat\Behat\Context\SnippetAcceptingContext;
 use Behat\Gherkin\Node\PyStringNode;
-use Behat\Gherkin\Node\TableNode;
-use Psr\Http\Message\RequestInterface;
 use Psr\Http\Message\ResponseInterface;
 use Rezzza\RestApiBehatExtension\Rest\RestApiBrowser;
 

www/index.php

Spacing +4 added lines, -4 removed lines

@@ -8,7 +8,7 @@ 
 use Symfony\Component\HttpFoundation\JsonResponse;
 use Symfony\Component\HttpFoundation\Request;
 
-require_once __DIR__ . '/../vendor/autoload.php';
+require_once __DIR__.'/../vendor/autoload.php';
 
 $app = new Silex\Application();
 
@@ -56,15 +56,15 @@ 
 );
 $app->match(
     'error_random',
-    function (Request $request) {
-        $statusCode = time() % 3 <= 0 ? 200 : 502 ;
+    function(Request $request) {
+        $statusCode = time() % 3 <= 0 ? 200 : 502;
 
         return new JsonResponse([], $statusCode);
     }
 );
 $app->match(
     'always_error',
-    function (Request $request) {
+    function(Request $request) {
         return new JsonResponse([], 502);
     }
 );

src/Json/JsonContext.php

Spacing +10 added lines, -10 removed lines

@@ -43,7 +43,7 @@ 
      */
     public function theJsonNodeShouldBeEqualTo($jsonNode, $expectedValue)
     {
-        $this->assert(function () use ($jsonNode, $expectedValue) {
+        $this->assert(function() use ($jsonNode, $expectedValue) {
             $realValue = $this->evaluateJsonNodeValue($jsonNode);
             $this->asserter->variable($realValue)->isEqualTo($expectedValue);
         });
@@ -55,7 +55,7 @@ 
      */
     public function theJsonNodeShouldHaveElements($jsonNode, $expectedNth)
     {
-        $this->assert(function () use ($jsonNode, $expectedNth) {
+        $this->assert(function() use ($jsonNode, $expectedNth) {
             $realValue = $this->evaluateJsonNodeValue($jsonNode);
             $this->asserter->phpArray($realValue)->hasSize($expectedNth);
         });
@@ -66,7 +66,7 @@ 
      */
     public function theJsonArrayNodeShouldContainElements($jsonNode, $expectedValue)
     {
-        $this->assert(function () use ($jsonNode, $expectedValue) {
+        $this->assert(function() use ($jsonNode, $expectedValue) {
             $realValue = $this->evaluateJsonNodeValue($jsonNode);
             $this->asserter->phpArray($realValue)->contains($expectedValue);
         });
@@ -77,7 +77,7 @@ 
      */
     public function theJsonArrayNodeShouldNotContainElements($jsonNode, $expectedValue)
     {
-        $this->assert(function () use ($jsonNode, $expectedValue) {
+        $this->assert(function() use ($jsonNode, $expectedValue) {
             $realValue = $this->evaluateJsonNodeValue($jsonNode);
             $this->asserter->phpArray($realValue)->notContains($expectedValue);
         });
@@ -88,7 +88,7 @@ 
      */
     public function theJsonNodeShouldContain($jsonNode, $expectedValue)
     {
-        $this->assert(function () use ($jsonNode, $expectedValue) {
+        $this->assert(function() use ($jsonNode, $expectedValue) {
             $realValue = $this->evaluateJsonNodeValue($jsonNode);
             $this->asserter->string((string) $realValue)->contains($expectedValue);
         });
@@ -101,7 +101,7 @@ 
      */
     public function theJsonNodeShouldNotContain($jsonNode, $unexpectedValue)
     {
-        $this->assert(function () use ($jsonNode, $unexpectedValue) {
+        $this->assert(function() use ($jsonNode, $unexpectedValue) {
             $realValue = $this->evaluateJsonNodeValue($jsonNode);
             $this->asserter->string((string) $realValue)->notContains($unexpectedValue);
         });
@@ -152,7 +152,7 @@ 
     {
         $tempFilename = tempnam(sys_get_temp_dir(), 'rae');
         file_put_contents($tempFilename, $jsonSchemaContent);
-        $this->assert(function () use ($tempFilename) {
+        $this->assert(function() use ($tempFilename) {
             $this->jsonInspector->validateJson(
                 new JsonSchema($tempFilename)
             );
@@ -167,7 +167,7 @@ 
     {
         $filename = $this->resolveFilename($filename);
 
-        $this->assert(function () use ($filename) {
+        $this->assert(function() use ($filename) {
             $this->jsonInspector->validateJson(
                 new JsonSchema($filename)
             );
@@ -187,7 +187,7 @@ 
             throw new \Exception('The expected JSON is not a valid');
         }
 
-        $this->assert(function () use ($realJsonValue, $expectedJsonValue) {
+        $this->assert(function() use ($realJsonValue, $expectedJsonValue) {
             $this->asserter->castToString($realJsonValue)->isEqualTo((string) $expectedJsonValue);
         });
     }
@@ -215,7 +215,7 @@ 
             ));
         }
 
-        $filename = $this->jsonSchemaBaseUrl . '/' . $filename;
+        $filename = $this->jsonSchemaBaseUrl.'/'.$filename;
 
         if (false === is_file($filename)) {
             throw new \RuntimeException(sprintf(

Doc Comments +1 added lines

@@ -194,6 +194,7 @@
 
     /**
      * @Then the JSON path expression :pathExpression should be equal to json :expectedJson
+     * @param string $expectedJson
      */
     public function theJsonPathExpressionShouldBeEqualToJson($pathExpression, $expectedJson)
     {

src/Extension.php

Spacing +1 added lines, -1 removed lines

@@ -15,7 +15,7 @@
     public function load(ContainerBuilder $container, array $config)
     {
         $container->setParameter('rezzza.json_api.rest.base_url', $config['rest']['base_url']);
-        $loader = new XmlFileLoader($container, new FileLocator(__DIR__ . '/Resources'));
+        $loader = new XmlFileLoader($container, new FileLocator(__DIR__.'/Resources'));
         $loader->load('services.xml');
 
         if (true === $config['rest']['store_response']) {

src/Json/JsonSchema.php

Spacing +3 added lines, -3 removed lines

@@ -19,15 +19,15 @@
 
     public function validate(Json $json, Validator $validator, SchemaStorage $schemaStorage)
     {
-        $schema = $schemaStorage->resolveRef('file://' . realpath($this->filename));
+        $schema = $schemaStorage->resolveRef('file://'.realpath($this->filename));
         $data = $json->getRawContent();
 
         $validator->check($data, $schema);
 
         if (!$validator->isValid()) {
-            $msg = "JSON does not validate. Violations:" . PHP_EOL;
+            $msg = "JSON does not validate. Violations:".PHP_EOL;
             foreach ($validator->getErrors() as $error) {
-                $msg .= sprintf("  - [%s] %s" . PHP_EOL, $error['property'], $error['message']);
+                $msg .= sprintf("  - [%s] %s".PHP_EOL, $error['property'], $error['message']);
             }
             throw new \Exception($msg);
         }

src/Rest/RestApiBrowser.php

Spacing +1 added lines, -1 removed lines

@@ -115,7 +115,7 @@
             new TimeOut(new SleepWaiter(), $maxExecutionTime)
         );
         $restApiBrowser = $this;
-        $runner->run(new Callback(function () use ($restApiBrowser, $method, $uri, $body, $assertion) {
+        $runner->run(new Callback(function() use ($restApiBrowser, $method, $uri, $body, $assertion) {
             $restApiBrowser->sendRequest($method, $uri, $body);
 
             return $assertion();