resque / php-resque

demo/job.php

Indentation +1 added lines, -1 removed lines

@@ -3,7 +3,7 @@
 {
 	public function perform()
 	{
-        fwrite(STDOUT, 'Start job! -> ');
+		fwrite(STDOUT, 'Start job! -> ');
 		sleep(1);
 		fwrite(STDOUT, 'Job ended!' . PHP_EOL);
 	}

demo/check_status.php

Spacing +5 added lines, -5 removed lines

@@ -1,5 +1,5 @@ 
 <?php
-if(empty($argv[1])) {
+if (empty($argv[1])) {
 	die('Specify the ID of a job to monitor the status of.');
 }
 
@@ -12,12 +12,12 @@ 
 //Resque::setBackend('redis://user:pass@a.host.name:3432/2');
 
 $status = new Resque_Job_Status($argv[1]);
-if(!$status->isTracking()) {
+if (!$status->isTracking()) {
 	die("Resque is not tracking the status of this job.\n");
 }
 
-echo "Tracking status of ".$argv[1].". Press [break] to stop.\n\n";
-while(true) {
-	fwrite(STDOUT, "Status of ".$argv[1]." is: ".$status->get()."\n");
+echo "Tracking status of " . $argv[1] . ". Press [break] to stop.\n\n";
+while (true) {
+	fwrite(STDOUT, "Status of " . $argv[1] . " is: " . $status->get() . "\n");
 	sleep(1);
 }
\ No newline at end of file

demo/queue.php

Indentation +1 added lines, -1 removed lines

@@ -20,7 +20,7 @@
 if (empty($argv[2])) {
 	$jobId = Resque::enqueue('default', $argv[1], $args, true);
 } else {
-        $jobId = Resque::enqueue($argv[1], $argv[2], $args, true);	
+		$jobId = Resque::enqueue($argv[1], $argv[2], $args, true);	
 }
 
 echo "Queued job ".$jobId."\n\n";

Spacing +2 added lines, -2 removed lines

@@ -1,5 +1,5 @@ 
 <?php
-if(empty($argv[1])) {
+if (empty($argv[1])) {
 	die('Specify the name of a job to add. e.g, php queue.php PHP_Job');
 }
 
@@ -23,4 +23,4 @@ 
         $jobId = Resque::enqueue($argv[1], $argv[2], $args, true);	
 }
 
-echo "Queued job ".$jobId."\n\n";
+echo "Queued job " . $jobId . "\n\n";

lib/Resque.php

Braces +1 added lines, -2 removed lines

@@ -227,8 +227,7 @@
 		);
 		try {
 			Resque_Event::trigger('beforeEnqueue', $hookParams);
-		}
-		catch(Resque_Job_DontCreate $e) {
+		} catch(Resque_Job_DontCreate $e) {
 			return false;
 		}
 

Indentation +42 added lines, -42 removed lines

@@ -10,7 +10,7 @@ 
 {
 	const VERSION = '1.2';
 
-    const DEFAULT_INTERVAL = 5;
+	const DEFAULT_INTERVAL = 5;
 
 	/**
 	 * @var Resque_Redis Instance of Resque_Redis that talks to redis.
@@ -28,9 +28,9 @@ 
 	 */
 	protected static $redisDatabase = 0;
 
-    /**
-     * @var string auth of Redis database
-     */
+	/**
+	 * @var string auth of Redis database
+	 */
 	protected static $auth;
 
 	/**
@@ -42,7 +42,7 @@ 
 	 *                      and returns a Resque_Redis instance, or
 	 *                      a nested array of servers with host/port pairs.
 	 * @param int $database
-     * @param string $auth
+	 * @param string $auth
 	 */
 	public static function setBackend($server, $database = 0, $auth = null)
 	{
@@ -70,8 +70,8 @@ 
 		}
 
 		if (!empty(self::$auth)) {
-            self::$redis->auth(self::$auth);
-        }
+			self::$redis->auth(self::$auth);
+		}
 
 		return self::$redis;
 	}
@@ -133,7 +133,7 @@ 
 	 */
 	public static function pop($queue)
 	{
-        $item = self::redis()->lpop('queue:' . $queue);
+		$item = self::redis()->lpop('queue:' . $queue);
 
 		if(!$item) {
 			return;
@@ -151,11 +151,11 @@ 
 	 */
 	public static function dequeue($queue, $items = Array())
 	{
-	    if(count($items) > 0) {
+		if(count($items) > 0) {
 			return self::removeItems($queue, $items);
-	    } else {
+		} else {
 			return self::removeList($queue);
-	    }
+		}
 	}
 
 	/**
@@ -166,9 +166,9 @@ 
 	 */
 	public static function removeQueue($queue)
 	{
-	    $num = self::removeList($queue);
-	    self::redis()->srem('queues', $queue);
-	    return $num;
+		$num = self::removeList($queue);
+		self::redis()->srem('queues', $queue);
+		return $num;
 	}
 
 	/**
@@ -181,28 +181,28 @@ 
 	 */
 	public static function blpop(array $queues, $timeout)
 	{
-	    $list = array();
-	    foreach($queues AS $queue) {
+		$list = array();
+		foreach($queues AS $queue) {
 		$list[] = 'queue:' . $queue;
-	    }
+		}
 
-	    $item = self::redis()->blpop($list, (int)$timeout);
+		$item = self::redis()->blpop($list, (int)$timeout);
 
-	    if(!$item) {
+		if(!$item) {
 		return;
-	    }
+		}
 
-	    /**
-	     * Normally the Resque_Redis class returns queue names without the prefix
-	     * But the blpop is a bit different. It returns the name as prefix:queue:name
-	     * So we need to strip off the prefix:queue: part
-	     */
-	    $queue = substr($item[0], strlen(self::redis()->getPrefix() . 'queue:'));
+		/**
+		 * Normally the Resque_Redis class returns queue names without the prefix
+		 * But the blpop is a bit different. It returns the name as prefix:queue:name
+		 * So we need to strip off the prefix:queue: part
+		 */
+		$queue = substr($item[0], strlen(self::redis()->getPrefix() . 'queue:'));
 
-	    return array(
+		return array(
 		'queue'   => $queue,
 		'payload' => json_decode($item[1], true)
-	    );
+		);
 	}
 
 	/**
@@ -330,7 +330,7 @@ 
 		while (!$finished) {
 			$string = self::redis()->rpoplpush($requeueQueue, self::redis()->getPrefix() .$originalQueue);
 			if (empty($string)) {
-			    $finished = true;
+				$finished = true;
 			}
 		}
 
@@ -353,29 +353,29 @@ 
 	 */
 	private static function matchItem($string, $items)
 	{
-	    $decoded = json_decode($string, true);
+		$decoded = json_decode($string, true);
 
-	    foreach($items as $key => $val) {
+		foreach($items as $key => $val) {
 			# class name only  ex: item[0] = ['class']
 			if (is_numeric($key)) {
-			    if($decoded['class'] == $val) {
+				if($decoded['class'] == $val) {
 					return true;
-			    }
+				}
 			# class name with args , example: item[0] = ['class' => {'foo' => 1, 'bar' => 2}]
 			} elseif (is_array($val)) {
-			    $decodedArgs = (array)$decoded['args'][0];
-			    if ($decoded['class'] == $key &&
+				$decodedArgs = (array)$decoded['args'][0];
+				if ($decoded['class'] == $key &&
 					count($decodedArgs) > 0 && count(array_diff($decodedArgs, $val)) == 0) {
 					return true;
 				}
 			# class name with ID, example: item[0] = ['class' => 'id']
 			} else {
-			    if ($decoded['class'] == $key && $decoded['id'] == $val) {
+				if ($decoded['class'] == $key && $decoded['id'] == $val) {
 					return true;
-			    }
+				}
 			}
-	    }
-	    return false;
+		}
+		return false;
 	}
 
 	/**
@@ -388,9 +388,9 @@ 
 	 */
 	private static function removeList($queue)
 	{
-	    $counter = self::size($queue);
-	    $result = self::redis()->del('queue:' . $queue);
-	    return ($result == 1) ? $counter : 0;
+		$counter = self::size($queue);
+		$result = self::redis()->del('queue:' . $queue);
+		return ($result == 1) ? $counter : 0;
 	}
 
 	/*

Spacing +16 added lines, -16 removed lines

@@ -87,7 +87,7 @@ 
 	 */
 	public static function fork()
 	{
-		if(!function_exists('pcntl_fork')) {
+		if (!function_exists('pcntl_fork')) {
 			return false;
 		}
 
@@ -96,7 +96,7 @@ 
 		self::$redis = null;
 
 		$pid = pcntl_fork();
-		if($pid === -1) {
+		if ($pid === -1) {
 			throw new RuntimeException('Unable to fork child worker.');
 		}
 
@@ -135,7 +135,7 @@ 
 	{
         $item = self::redis()->lpop('queue:' . $queue);
 
-		if(!$item) {
+		if (!$item) {
 			return;
 		}
 
@@ -151,7 +151,7 @@ 
 	 */
 	public static function dequeue($queue, $items = Array())
 	{
-	    if(count($items) > 0) {
+	    if (count($items) > 0) {
 			return self::removeItems($queue, $items);
 	    } else {
 			return self::removeList($queue);
@@ -182,13 +182,13 @@ 
 	public static function blpop(array $queues, $timeout)
 	{
 	    $list = array();
-	    foreach($queues AS $queue) {
+	    foreach ($queues AS $queue) {
 		$list[] = 'queue:' . $queue;
 	    }
 
 	    $item = self::redis()->blpop($list, (int)$timeout);
 
-	    if(!$item) {
+	    if (!$item) {
 		return;
 	    }
 
@@ -240,7 +240,7 @@ 
 		try {
 			Resque_Event::trigger('beforeEnqueue', $hookParams);
 		}
-		catch(Resque_Job_DontCreate $e) {
+		catch (Resque_Job_DontCreate $e) {
 			return false;
 		}
 
@@ -269,7 +269,7 @@ 
 	public static function queues()
 	{
 		$queues = self::redis()->smembers('queues');
-		if(!is_array($queues)) {
+		if (!is_array($queues)) {
 			$queues = array();
 		}
 		return $queues;
@@ -283,7 +283,7 @@ 
 	public static function items($queue, $start = 0, $stop = -1)
 	{
 		$list = self::redis()->lrange('queue:' . $queue, $start, $stop);
-		if(!is_array($list)) {
+		if (!is_array($list)) {
 			$list = array();
 		}
 		return $list;
@@ -304,9 +304,9 @@ 
 	private static function removeItems($queue, $items = Array())
 	{
 		$counter = 0;
-		$originalQueue = 'queue:'. $queue;
-		$tempQueue = $originalQueue. ':temp:'. time();
-		$requeueQueue = $tempQueue. ':requeue';
+		$originalQueue = 'queue:' . $queue;
+		$tempQueue = $originalQueue . ':temp:' . time();
+		$requeueQueue = $tempQueue . ':requeue';
 
 		// move each item from original queue to temp queue and process it
 		$finished = false;
@@ -314,7 +314,7 @@ 
 			$string = self::redis()->rpoplpush($originalQueue, self::redis()->getPrefix() . $tempQueue);
 
 			if (!empty($string)) {
-				if(self::matchItem($string, $items)) {
+				if (self::matchItem($string, $items)) {
 					self::redis()->rpop($tempQueue);
 					$counter++;
 				} else {
@@ -328,7 +328,7 @@ 
 		// move back from temp queue to original queue
 		$finished = false;
 		while (!$finished) {
-			$string = self::redis()->rpoplpush($requeueQueue, self::redis()->getPrefix() .$originalQueue);
+			$string = self::redis()->rpoplpush($requeueQueue, self::redis()->getPrefix() . $originalQueue);
 			if (empty($string)) {
 			    $finished = true;
 			}
@@ -355,10 +355,10 @@ 
 	{
 	    $decoded = json_decode($string, true);
 
-	    foreach($items as $key => $val) {
+	    foreach ($items as $key => $val) {
 			# class name only  ex: item[0] = ['class']
 			if (is_numeric($key)) {
-			    if($decoded['class'] == $val) {
+			    if ($decoded['class'] == $val) {
 					return true;
 			    }
 			# class name with args , example: item[0] = ['class' => {'foo' => 1, 'bar' => 2}]

lib/Resque/Job/Factory.php

Indentation +24 added lines, -24 removed lines

@@ -3,30 +3,30 @@
 class Resque_Job_Factory implements Resque_Job_FactoryInterface
 {
 
-    /**
-     * @param $className
-     * @param array $args
-     * @param $queue
-     * @return Resque_JobInterface
-     * @throws \Resque_Exception
-     */
-    public function create($className, $args, $queue)
-    {
-        if (!class_exists($className)) {
-            throw new Resque_Exception(
-                'Could not find job class ' . $className . '.'
-            );
-        }
+	/**
+	 * @param $className
+	 * @param array $args
+	 * @param $queue
+	 * @return Resque_JobInterface
+	 * @throws \Resque_Exception
+	 */
+	public function create($className, $args, $queue)
+	{
+		if (!class_exists($className)) {
+			throw new Resque_Exception(
+				'Could not find job class ' . $className . '.'
+			);
+		}
 
-        if (!method_exists($className, 'perform')) {
-            throw new Resque_Exception(
-                'Job class ' . $className . ' does not contain a perform method.'
-            );
-        }
+		if (!method_exists($className, 'perform')) {
+			throw new Resque_Exception(
+				'Job class ' . $className . ' does not contain a perform method.'
+			);
+		}
 
-        $instance = new $className;
-        $instance->args = $args;
-        $instance->queue = $queue;
-        return $instance;
-    }
+		$instance = new $className;
+		$instance->args = $args;
+		$instance->queue = $queue;
+		return $instance;
+	}
 }

lib/Resque/Redis.php

Spacing +7 added lines, -7 removed lines

@@ -130,7 +130,7 @@ 
 
 				$this->driver = new Credis_Client($host, $port, $timeout, $persistent);
 				$this->driver->setMaxConnectRetries($maxRetries);
-				if ($password){
+				if ($password) {
 					$this->driver->auth($password);
 				}
 
@@ -145,7 +145,7 @@ 
 				$this->driver->select($database);
 			}
 		}
-		catch(CredisException $e) {
+		catch (CredisException $e) {
 			throw new Resque_RedisException('Error communicating with Redis: ' . $e->getMessage(), 0, $e);
 		}
 	}
@@ -170,7 +170,7 @@ 
 			// Use a sensible default for an empty DNS string
 			$dsn = 'redis://' . self::DEFAULT_HOST;
 		}
-		if(substr($dsn, 0, 7) === 'unix://') {
+		if (substr($dsn, 0, 7) === 'unix://') {
 			return array(
 				$dsn,
 				null,
@@ -184,12 +184,12 @@ 
 
 		// Check the URI scheme
 		$validSchemes = array('redis', 'tcp');
-		if (isset($parts['scheme']) && ! in_array($parts['scheme'], $validSchemes)) {
+		if (isset($parts['scheme']) && !in_array($parts['scheme'], $validSchemes)) {
 			throw new \InvalidArgumentException("Invalid DSN. Supported schemes are " . implode(', ', $validSchemes));
 		}
 
 		// Allow simple 'hostname' format, which `parse_url` treats as a path, not host.
-		if ( ! isset($parts['host']) && isset($parts['path'])) {
+		if (!isset($parts['host']) && isset($parts['path'])) {
 			$parts['host'] = $parts['path'];
 			unset($parts['path']);
 		}
@@ -260,10 +260,10 @@ 
 
 	public static function removePrefix($string)
 	{
-	    $prefix=self::getPrefix();
+	    $prefix = self::getPrefix();
 
 	    if (substr($string, 0, strlen($prefix)) == $prefix) {
-	        $string = substr($string, strlen($prefix), strlen($string) );
+	        $string = substr($string, strlen($prefix), strlen($string));
 	    }
 	    return $string;
 	}

Indentation +11 added lines, -11 removed lines

@@ -98,10 +98,10 @@ 
 	 */
 	public static function prefix($namespace)
 	{
-	    if (substr($namespace, -1) !== ':' && $namespace != '') {
-	        $namespace .= ':';
-	    }
-	    self::$defaultNamespace = $namespace;
+		if (substr($namespace, -1) !== ':' && $namespace != '') {
+			$namespace .= ':';
+		}
+		self::$defaultNamespace = $namespace;
 	}
 
 	/**
@@ -110,7 +110,7 @@ 
 	 *                      DSN-supplied value will be used instead and this parameter is ignored.
 	 * @param object $client Optional Credis_Cluster or Credis_Client instance instantiated by you
 	 */
-    public function __construct($server, $database = null, $client = null)
+	public function __construct($server, $database = null, $client = null)
 	{
 		try {
 			if (is_object($client)) {
@@ -258,16 +258,16 @@ 
 
 	public static function getPrefix()
 	{
-	    return self::$defaultNamespace;
+		return self::$defaultNamespace;
 	}
 
 	public static function removePrefix($string)
 	{
-	    $prefix=self::getPrefix();
+		$prefix=self::getPrefix();
 
-	    if (substr($string, 0, strlen($prefix)) == $prefix) {
-	        $string = substr($string, strlen($prefix), strlen($string) );
-	    }
-	    return $string;
+		if (substr($string, 0, strlen($prefix)) == $prefix) {
+			$string = substr($string, strlen($prefix), strlen($string) );
+		}
+		return $string;
 	}
 }

Braces +6 added lines, -12 removed lines

@@ -115,14 +115,11 @@ 
 		try {
 			if (is_object($client)) {
 				$this->driver = $client;
-			}
-			elseif (is_object($server)) {
+			} elseif (is_object($server)) {
 				$this->driver = $server;
-			}
-			elseif (is_array($server)) {
+			} elseif (is_array($server)) {
 				$this->driver = new Credis_Cluster($server);
-			}
-			else {
+			} else {
 				list($host, $port, $dsnDatabase, $user, $password, $options) = self::parseDsn($server);
 				// $user is not used, only $password
 
@@ -147,8 +144,7 @@ 
 			if ($database !== null) {
 				$this->driver->select($database);
 			}
-		}
-		catch(CredisException $e) {
+		} catch(CredisException $e) {
 			throw new Resque_RedisException('Error communicating with Redis: ' . $e->getMessage(), 0, $e);
 		}
 	}
@@ -243,15 +239,13 @@ 
 				foreach ($args[0] AS $i => $v) {
 					$args[0][$i] = self::$defaultNamespace . $v;
 				}
-			}
-			else {
+			} else {
 				$args[0] = self::$defaultNamespace . $args[0];
 			}
 		}
 		try {
 			return $this->driver->__call($name, $args);
-		}
-		catch (CredisException $e) {
+		} catch (CredisException $e) {
 			throw new Resque_RedisException('Error communicating with Redis: ' . $e->getMessage(), 0, $e);
 		}
 	}

lib/Resque/Failure.php

Spacing +1 added lines, -1 removed lines

@@ -35,7 +35,7 @@
 	 */
 	public static function getBackend()
 	{
-		if(self::$backend === null) {
+		if (self::$backend === null) {
 			self::$backend = 'Resque_Failure_Redis';
 		}
 

lib/Resque/Worker.php

Indentation +40 added lines, -40 removed lines

@@ -17,8 +17,8 @@ 
 	private static $processPrefix = 'resque';
 
 	/**
-	* @var LoggerInterface Logging object that impliments the PSR-3 LoggerInterface
-	*/
+	 * @var LoggerInterface Logging object that impliments the PSR-3 LoggerInterface
+	 */
 	public $logger;
 
 	/**
@@ -61,30 +61,30 @@ 
 	 */
 	private $child = null;
 
-    /**
-     * Instantiate a new worker, given a list of queues that it should be working
-     * on. The list of queues should be supplied in the priority that they should
-     * be checked for jobs (first come, first served)
-     *
-     * Passing a single '*' allows the worker to work on all queues in alphabetical
-     * order. You can easily add new queues dynamically and have them worked on using
-     * this method.
-     *
-     * @param string|array $queues String with a single queue name, array with multiple.
-     */
-    public function __construct($queues)
-    {
-        $this->logger = new Resque_Log();
+	/**
+	 * Instantiate a new worker, given a list of queues that it should be working
+	 * on. The list of queues should be supplied in the priority that they should
+	 * be checked for jobs (first come, first served)
+	 *
+	 * Passing a single '*' allows the worker to work on all queues in alphabetical
+	 * order. You can easily add new queues dynamically and have them worked on using
+	 * this method.
+	 *
+	 * @param string|array $queues String with a single queue name, array with multiple.
+	 */
+	public function __construct($queues)
+	{
+		$this->logger = new Resque_Log();
 
-        if(!is_array($queues)) {
-            $queues = array($queues);
-        }
+		if(!is_array($queues)) {
+			$queues = array($queues);
+		}
 
-        $this->queues = $queues;
-        $this->hostname = php_uname('n');
+		$this->queues = $queues;
+		$this->hostname = php_uname('n');
 
-        $this->id = $this->hostname . ':'.getmypid() . ':' . implode(',', $this->queues);
-    }
+		$this->id = $this->hostname . ':'.getmypid() . ':' . implode(',', $this->queues);
+	}
 
 	/**
 	 * Set the process prefix of the workers to the given prefix string.
@@ -166,9 +166,9 @@ 
 		$this->updateProcLine('Starting');
 		$this->startup();
 
-        if(function_exists('pcntl_signal_dispatch')) {
-            pcntl_signal_dispatch();
-        }
+		if(function_exists('pcntl_signal_dispatch')) {
+			pcntl_signal_dispatch();
+		}
 
 		while(true) {
 			if($this->shutdown) {
@@ -177,14 +177,14 @@ 
 
 			// is redis still alive?
 			try {
-			    if (Resque::redis()->ping() === false) {
-			        throw new CredisException('redis ping() failed');
-			    }
+				if (Resque::redis()->ping() === false) {
+					throw new CredisException('redis ping() failed');
+				}
 			} catch (CredisException $e) {
-			    $this->logger->log(Psr\Log\LogLevel::ERROR, 'redis went away. trying to reconnect');
-			    Resque::$redis = null;
-			    usleep($interval * 1000000);
-			    continue;
+				$this->logger->log(Psr\Log\LogLevel::ERROR, 'redis went away. trying to reconnect');
+				Resque::$redis = null;
+				usleep($interval * 1000000);
+				continue;
 			}
 
 			// Attempt to find and reserve a job
@@ -259,8 +259,8 @@ 
 				// Wait until the child process finishes before continuing
 				while (pcntl_wait($status, WNOHANG) === 0) {
 					if(function_exists('pcntl_signal_dispatch')) {
-			            pcntl_signal_dispatch();
-			        }
+						pcntl_signal_dispatch();
+					}
 
 					// Pause for a half a second to conserve system resources
 					usleep(500000);
@@ -336,11 +336,11 @@ 
 		}
 
 		if($blocking === true) {
-		    if(empty($queues)){
-                $this->logger->log(Psr\Log\LogLevel::INFO, 'No queue was found, sleeping for {interval}', array('interval' => $timeout));
-                usleep($timeout * 1000000);
-                return false;
-            }
+			if(empty($queues)){
+				$this->logger->log(Psr\Log\LogLevel::INFO, 'No queue was found, sleeping for {interval}', array('interval' => $timeout));
+				usleep($timeout * 1000000);
+				return false;
+			}
 			$job = Resque_Job::reserveBlocking($queues, $timeout);
 			if($job) {
 				$this->logger->log(Psr\Log\LogLevel::INFO, 'Found job on {queue}', array('queue' => $job->queue));

Spacing +40 added lines, -40 removed lines

@@ -1,5 +1,5 @@ 
 <?php
-declare(ticks = 1);
+declare(ticks=1);
 
 /**
  * Resque worker that handles checking queues for jobs, fetching them
@@ -76,14 +76,14 @@ 
     {
         $this->logger = new Resque_Log();
 
-        if(!is_array($queues)) {
+        if (!is_array($queues)) {
             $queues = array($queues);
         }
 
         $this->queues = $queues;
         $this->hostname = php_uname('n');
 
-        $this->id = $this->hostname . ':'.getmypid() . ':' . implode(',', $this->queues);
+        $this->id = $this->hostname . ':' . getmypid() . ':' . implode(',', $this->queues);
     }
 
 	/**
@@ -102,12 +102,12 @@ 
 	public static function all()
 	{
 		$workers = Resque::redis()->smembers('workers');
-		if(!is_array($workers)) {
+		if (!is_array($workers)) {
 			$workers = array();
 		}
 
 		$instances = array();
-		foreach($workers as $workerId) {
+		foreach ($workers as $workerId) {
 			$instances[] = self::find($workerId);
 		}
 		return $instances;
@@ -132,7 +132,7 @@ 
 	 */
 	public static function find($workerId)
 	{
-		if(!self::exists($workerId) || false === strpos($workerId, ":")) {
+		if (!self::exists($workerId) || false === strpos($workerId, ":")) {
 			return false;
 		}
 
@@ -166,12 +166,12 @@ 
 		$this->updateProcLine('Starting');
 		$this->startup();
 
-        if(function_exists('pcntl_signal_dispatch')) {
+        if (function_exists('pcntl_signal_dispatch')) {
             pcntl_signal_dispatch();
         }
 
-		while(true) {
-			if($this->shutdown) {
+		while (true) {
+			if ($this->shutdown) {
 				break;
 			}
 
@@ -189,8 +189,8 @@ 
 
 			// Attempt to find and reserve a job
 			$job = false;
-			if(!$this->paused) {
-				if($blocking === true) {
+			if (!$this->paused) {
+				if ($blocking === true) {
 					$this->logger->log(Psr\Log\LogLevel::INFO, 'Starting blocking with timeout of {interval}', array('interval' => $interval));
 					$this->updateProcLine('Waiting with blocking timeout ' . $interval);
 				} else {
@@ -200,17 +200,17 @@ 
 				$job = $this->reserve($blocking, $interval);
 			}
 
-			if(!$job) {
+			if (!$job) {
 				// For an interval of 0, break now - helps with unit testing etc
-				if($interval == 0) {
+				if ($interval == 0) {
 					break;
 				}
 
-				if($blocking === false)
+				if ($blocking === false)
 				{
 					// If no job was found, we sleep for $interval before continuing and checking again
 					$this->logger->log(Psr\Log\LogLevel::INFO, 'Sleeping for {interval}', array('interval' => $interval));
-					if($this->paused) {
+					if ($this->paused) {
 						$this->updateProcLine('Paused');
 					}
 					else {
@@ -235,13 +235,13 @@ 
 				$this->updateProcLine($status);
 				$this->logger->log(Psr\Log\LogLevel::INFO, $status);
 
-				if(!empty($job->payload['id'])) {
+				if (!empty($job->payload['id'])) {
 					Resque_Job_PID::create($job->payload['id']);
 				}
 
 				$this->perform($job);
 
-				if(!empty($job->payload['id'])) {
+				if (!empty($job->payload['id'])) {
 					Resque_Job_PID::del($job->payload['id']);
 				}
 
@@ -250,7 +250,7 @@ 
 				}
 			}
 
-			if($this->child > 0) {
+			if ($this->child > 0) {
 				// Parent process, sit and wait
 				$status = 'Forked ' . $this->child . ' at ' . strftime('%F %T');
 				$this->updateProcLine($status);
@@ -258,7 +258,7 @@ 
 
 				// Wait until the child process finishes before continuing
 				while (pcntl_wait($status, WNOHANG) === 0) {
-					if(function_exists('pcntl_signal_dispatch')) {
+					if (function_exists('pcntl_signal_dispatch')) {
 			            pcntl_signal_dispatch();
 			        }
 
@@ -302,12 +302,12 @@ 
 			Resque_Event::trigger('afterFork', $job);
 			$result = $job->perform();
 		}
-		catch(Exception $e) {
+		catch (Exception $e) {
 			$this->logger->log(Psr\Log\LogLevel::CRITICAL, '{job} has failed {exception}', array('job' => $job, 'exception' => $e));
 			$job->fail($e);
 			return;
 		}
-		catch(Error $e) {
+		catch (Error $e) {
 			$this->logger->log(Psr\Log\LogLevel::CRITICAL, '{job} has failed {exception}', array('job' => $job, 'exception' => $e));
 			$job->fail($e);
 			return;
@@ -331,26 +331,26 @@ 
 		}
 
 		$queues = $this->queues();
-		if(!is_array($queues)) {
+		if (!is_array($queues)) {
 			return;
 		}
 
-		if($blocking === true) {
-		    if(empty($queues)){
+		if ($blocking === true) {
+		    if (empty($queues)) {
                 $this->logger->log(Psr\Log\LogLevel::INFO, 'No queue was found, sleeping for {interval}', array('interval' => $timeout));
                 usleep($timeout * 1000000);
                 return false;
             }
 			$job = Resque_Job::reserveBlocking($queues, $timeout);
-			if($job) {
+			if ($job) {
 				$this->logger->log(Psr\Log\LogLevel::INFO, 'Found job on {queue}', array('queue' => $job->queue));
 				return $job;
 			}
 		} else {
-			foreach($queues as $queue) {
+			foreach ($queues as $queue) {
 				$this->logger->log(Psr\Log\LogLevel::INFO, 'Checking {queue} for jobs', array('queue' => $queue));
 				$job = Resque_Job::reserve($queue);
-				if($job) {
+				if ($job) {
 					$this->logger->log(Psr\Log\LogLevel::INFO, 'Found job on {queue}', array('queue' => $job->queue));
 					return $job;
 				}
@@ -373,7 +373,7 @@ 
 	 */
 	public function queues($fetch = true)
 	{
-		if(!in_array('*', $this->queues) || $fetch == false) {
+		if (!in_array('*', $this->queues) || $fetch == false) {
 			return $this->queues;
 		}
 
@@ -403,10 +403,10 @@ 
 	private function updateProcLine($status)
 	{
 		$processTitle = static::$processPrefix . '-' . Resque::VERSION . ' (' . implode(',', $this->queues) . '): ' . $status;
-		if(function_exists('cli_set_process_title') && PHP_OS !== 'Darwin') {
+		if (function_exists('cli_set_process_title') && PHP_OS !== 'Darwin') {
 			cli_set_process_title($processTitle);
 		}
-		else if(function_exists('setproctitle')) {
+		else if (function_exists('setproctitle')) {
 			setproctitle($processTitle);
 		}
 	}
@@ -421,7 +421,7 @@ 
 	 */
 	private function registerSigHandlers()
 	{
-		if(!function_exists('pcntl_signal')) {
+		if (!function_exists('pcntl_signal')) {
 			return;
 		}
 
@@ -486,13 +486,13 @@ 
 	 */
 	public function killChild()
 	{
-		if(!$this->child) {
+		if (!$this->child) {
 			$this->logger->log(Psr\Log\LogLevel::DEBUG, 'No child to kill.');
 			return;
 		}
 
 		$this->logger->log(Psr\Log\LogLevel::INFO, 'Killing child at {child}', array('child' => $this->child));
-		if(exec('ps -o pid,s -p ' . $this->child, $output, $returnCode) && $returnCode != 1) {
+		if (exec('ps -o pid,s -p ' . $this->child, $output, $returnCode) && $returnCode != 1) {
 			$this->logger->log(Psr\Log\LogLevel::DEBUG, 'Child {child} found, killing.', array('child' => $this->child));
 			posix_kill($this->child, SIGKILL);
 			$this->child = null;
@@ -515,10 +515,10 @@ 
 	{
 		$workerPids = $this->workerPids();
 		$workers = self::all();
-		foreach($workers as $worker) {
+		foreach ($workers as $worker) {
 			if (is_object($worker)) {
 				list($host, $pid, $queues) = explode(':', (string)$worker, 3);
-				if($host != $this->hostname || in_array($pid, $workerPids) || $pid == getmypid()) {
+				if ($host != $this->hostname || in_array($pid, $workerPids) || $pid == getmypid()) {
 					continue;
 				}
 				$this->logger->log(Psr\Log\LogLevel::INFO, 'Pruning dead worker: {worker}', array('worker' => (string)$worker));
@@ -538,14 +538,14 @@ 
 		$pids = array();
 		if (strtoupper(substr(PHP_OS, 0, 3)) === 'WIN') {
 			exec('WMIC path win32_process get Processid,Commandline | findstr resque | findstr /V findstr', $cmdOutput);
-			foreach($cmdOutput as $line) {
+			foreach ($cmdOutput as $line) {
 				$line = preg_replace('/\s+/m', ' ', $line);
-				list(,,$pids[]) = explode(' ', trim($line), 3);
+				list(,, $pids[]) = explode(' ', trim($line), 3);
 			}
 		}
 		else {
 			exec('ps -A -o pid,args | grep [r]esque', $cmdOutput);
-			foreach($cmdOutput as $line) {
+			foreach ($cmdOutput as $line) {
 				list($pids[],) = explode(' ', trim($line), 2);
 			}
 		}
@@ -566,7 +566,7 @@ 
 	 */
 	public function unregisterWorker()
 	{
-		if(is_object($this->currentJob)) {
+		if (is_object($this->currentJob)) {
 			$this->currentJob->fail(new Resque_Job_DirtyExitException);
 		}
 
@@ -626,7 +626,7 @@ 
 	public function job()
 	{
 		$job = Resque::redis()->get('worker:' . $this);
-		if(!$job) {
+		if (!$job) {
 			return array();
 		}
 		else {

Braces +8 added lines, -16 removed lines

@@ -212,8 +212,7 @@ 
 					$this->logger->log(Psr\Log\LogLevel::INFO, 'Sleeping for {interval}', array('interval' => $interval));
 					if($this->paused) {
 						$this->updateProcLine('Paused');
-					}
-					else {
+					} else {
 						$this->updateProcLine('Waiting');
 					}
 
@@ -272,8 +271,7 @@ 
 					$job->fail(new Resque_Job_DirtyExitException(
 						'Job exited with exit code ' . $exitStatus
 					));
-				}
-				else
+				} else
 				{
 					if (in_array($job->getStatus(), array(Resque_Job_Status::STATUS_WAITING, Resque_Job_Status::STATUS_RUNNING)))
 					{
@@ -301,13 +299,11 @@ 
 		try {
 			Resque_Event::trigger('afterFork', $job);
 			$result = $job->perform();
-		}
-		catch(Exception $e) {
+		} catch(Exception $e) {
 			$this->logger->log(Psr\Log\LogLevel::CRITICAL, '{job} has failed {exception}', array('job' => $job, 'exception' => $e));
 			$job->fail($e);
 			return;
-		}
-		catch(Error $e) {
+		} catch(Error $e) {
 			$this->logger->log(Psr\Log\LogLevel::CRITICAL, '{job} has failed {exception}', array('job' => $job, 'exception' => $e));
 			$job->fail($e);
 			return;
@@ -405,8 +401,7 @@ 
 		$processTitle = static::$processPrefix . '-' . Resque::VERSION . ' (' . implode(',', $this->queues) . '): ' . $status;
 		if(function_exists('cli_set_process_title') && PHP_OS !== 'Darwin') {
 			cli_set_process_title($processTitle);
-		}
-		else if(function_exists('setproctitle')) {
+		} else if(function_exists('setproctitle')) {
 			setproctitle($processTitle);
 		}
 	}
@@ -496,8 +491,7 @@ 
 			$this->logger->log(Psr\Log\LogLevel::DEBUG, 'Child {child} found, killing.', array('child' => $this->child));
 			posix_kill($this->child, SIGKILL);
 			$this->child = null;
-		}
-		else {
+		} else {
 			$this->logger->log(Psr\Log\LogLevel::INFO, 'Child {child} not found, restarting.', array('child' => $this->child));
 			$this->shutdown();
 		}
@@ -542,8 +536,7 @@ 
 				$line = preg_replace('/\s+/m', ' ', $line);
 				list(,,$pids[]) = explode(' ', trim($line), 3);
 			}
-		}
-		else {
+		} else {
 			exec('ps -A -o pid,args | grep [r]esque', $cmdOutput);
 			foreach($cmdOutput as $line) {
 				list($pids[],) = explode(' ', trim($line), 2);
@@ -628,8 +621,7 @@ 
 		$job = Resque::redis()->get('worker:' . $this);
 		if(!$job) {
 			return array();
-		}
-		else {
+		} else {
 			return json_decode($job, true);
 		}
 	}

lib/Resque/Job/Status.php

Indentation +20 added lines, -20 removed lines

@@ -14,8 +14,8 @@ 
 	const STATUS_COMPLETE = 4;
 
 	/**
- 	 * @var string The prefix of the job status id.
- 	 */
+	 * @var string The prefix of the job status id.
+	 */
  	private $prefix;
 
 	/**
@@ -143,33 +143,33 @@ 
 	}
 
 	/**
- 	 * Fetch the last update timestamp of the job being monitored.
- 	 *
- 	 * @return mixed False if the job is not being monitored, otherwise the
+	 * Fetch the last update timestamp of the job being monitored.
+	 *
+	 * @return mixed False if the job is not being monitored, otherwise the
 	 *  update timestamp.
- 	 */
+	 */
 	public function updated()
 	{
 		return $this->fetch('updated');
  	}
 
 	/**
- 	 * Fetch the start timestamp of the job being monitored.
- 	 *
- 	 * @return mixed False if the job is not being monitored, otherwise the
+	 * Fetch the start timestamp of the job being monitored.
+	 *
+	 * @return mixed False if the job is not being monitored, otherwise the
 	 *  start timestamp.
- 	 */
+	 */
 	public function started()
 	{
 		return $this->fetch('started');
  	}
 
 	/**
- 	 * Fetch the result of the job being monitored.
- 	 *
- 	 * @return mixed False if the job is not being monitored, otherwise the result
- 	 * 	as mixed
- 	 */
+	 * Fetch the result of the job being monitored.
+	 *
+	 * @return mixed False if the job is not being monitored, otherwise the result
+	 * 	as mixed
+	 */
 	public function result()
 	{
 		return $this->fetch('result');
@@ -194,11 +194,11 @@ 
 	}
 
 	/**
-	* Fetch a value from the status packet for the job being monitored.
-	*
-	* @return mixed False if the status is not being monitored, otherwise the
-	*  requested value from the status packet.
-	*/
+	 * Fetch a value from the status packet for the job being monitored.
+	 *
+	 * @return mixed False if the status is not being monitored, otherwise the
+	 *  requested value from the status packet.
+	 */
 	protected function fetch($value = null)
 	{
 		if(!$this->isTracking()) {

Spacing +11 added lines, -11 removed lines

@@ -63,7 +63,7 @@ 
 			'started' => time(),
 			'result'  => null,
 		);
-		Resque::redis()->set((string) $status, json_encode($statusPacket));
+		Resque::redis()->set((string)$status, json_encode($statusPacket));
 
 		return $status;
 	}
@@ -76,11 +76,11 @@ 
 	 */
 	public function isTracking()
 	{
-		if($this->isTracking === false) {
+		if ($this->isTracking === false) {
 			return false;
 		}
 
-		if(!Resque::redis()->exists((string)$this)) {
+		if (!Resque::redis()->exists((string)$this)) {
 			$this->isTracking = false;
 			return false;
 		}
@@ -96,13 +96,13 @@ 
 	 */
 	public function update($status, $result = null)
 	{
-		$status = (int) $status;
+		$status = (int)$status;
 
-		if(!$this->isTracking()) {
+		if (!$this->isTracking()) {
 			return;
 		}
 
-		if($status < self::STATUS_WAITING || $status > self::STATUS_COMPLETE) {
+		if ($status < self::STATUS_WAITING || $status > self::STATUS_COMPLETE) {
 			return;
 		}
 
@@ -115,7 +115,7 @@ 
 		Resque::redis()->set((string)$this, json_encode($statusPacket));
 
 		// Expire the status for completed jobs after 24 hours
-		if(in_array($status, self::$completeStatuses)) {
+		if (in_array($status, self::$completeStatuses)) {
 			Resque::redis()->expire((string)$this, 86400);
 		}
 	}
@@ -201,19 +201,19 @@ 
 	*/
 	protected function fetch($value = null)
 	{
-		if(!$this->isTracking()) {
+		if (!$this->isTracking()) {
 			return false;
 		}
 
 		$statusPacket = json_decode(Resque::redis()->get((string)$this), true);
-		if(!$statusPacket) {
+		if (!$statusPacket) {
 			return false;
 		}
 
-		if(empty($value)) {
+		if (empty($value)) {
 			return $statusPacket;
 		} else {
-			if(isset($statusPacket[$value])) {
+			if (isset($statusPacket[$value])) {
 				return $statusPacket[$value];
 			} else {
 				return null;