MajorityQuorum::isMet() - Code Metrics - Inspection of "change quorum implementation to be able to give ot..." - remi-san/lock - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( c80709...02f185 )

by Rémi

created 2016-08-31 08:49 UTC

MajorityQuorum::isMet() A

↳ Parent: MajorityQuorum

Complexity

Conditions	3
Paths	2

Size

Total Lines	9
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	9
rs	9.6666
cc	3
eloc	5
nc	2
nop	1

<?php

namespace RemiSan\Lock\Quorum;

use RemiSan\Lock\Quorum;

class MajorityQuorum implements Quorum
{
    /**
     * @var int
     */
    private $total;

    /**
     * @var int
     */
    private $quorum;

    /**
     * @inheritDoc
     */
    public function init($totalNumber)
    {
        if ($totalNumber < 1) {
            throw new \InvalidArgumentException();
        }

        $this->total = $totalNumber;
        $this->quorum = floor($totalNumber / 2) + 1;
$answer = 42;

$correct = false;

$correct = (bool) $answer;
    }

    /**
     * @inheritDoc
     */
    public function isMet($numberOfSuccess)
    {
        if ($numberOfSuccess < 0 ||
            $numberOfSuccess > $this->total) {
            throw new \InvalidArgumentException();
        }

        return $numberOfSuccess >= $this->quorum;
    }
}


1			<?php
2
3			namespace RemiSan\Lock\Quorum;
4
5			use RemiSan\Lock\Quorum;
6
7			class MajorityQuorum implements Quorum
8			{
9			/**
10			* @var int
11			*/
12			private $total;
13
14			/**
15			* @var int
16			*/
17			private $quorum;
18
19			/**
20			* @inheritDoc
21			*/
22			public function init($totalNumber)
23			{
24			if ($totalNumber < 1) {
25			throw new \InvalidArgumentException();
26			}
27
28			$this->total = $totalNumber;
29			$this->quorum = floor($totalNumber / 2) + 1;
			0 ignored issues – show Documentation Bug introduced 2016-08-31 09:07 UTC by Report Bug Copy Issue Report The property `$quorum` was declared of type `integer`, but `floor($totalNumber / 2) + 1` is of type `double`. Maybe add a type cast? This check looks for assignments to scalar types that may be of the wrong type. To ensure the code behaves as expected, it may be a good idea to add an explicit type cast. $answer = 42; $correct = false; $correct = (bool) $answer; Loading history...
30			}
31
32			/**
33			* @inheritDoc
34			*/
35			public function isMet($numberOfSuccess)
36			{
37			if ($numberOfSuccess < 0 \|\|
38			$numberOfSuccess > $this->total) {
39			throw new \InvalidArgumentException();
40			}
41
42			return $numberOfSuccess >= $this->quorum;
43			}
44			}
45

remi-san / lock

GitHub Access Token became invalid

Push — master ( c80709...02f185 )

MajorityQuorum::isMet() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like