RemiSan\Lock\Quorum\MajorityQuorum

Complexity

Total Complexity

5

Size/Duplication

Total Lines	38
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	init()	0	9	2
A	isMet()	0	9	3

<?php

namespace RemiSan\Lock\Quorum;

use RemiSan\Lock\Quorum;

class MajorityQuorum implements Quorum
{
    /**
     * @var int
     */
    private $total;

    /**
     * @var int
     */
    private $quorum;

    /**
     * @inheritDoc
     */
    public function init($totalNumber)
    {
        if ($totalNumber < 1) {
            throw new \InvalidArgumentException();
        }

        $this->total = $totalNumber;
        $this->quorum = floor($totalNumber / 2) + 1;

The property $quorum was declared of type integer, but floor($totalNumber / 2) + 1 is of type double. Maybe add a type cast?

    }

    /**
     * @inheritDoc
     */
    public function isMet($numberOfSuccess)
    {
        if ($numberOfSuccess < 0 ||
            $numberOfSuccess > $this->total) {
            throw new \InvalidArgumentException();
        }

        return $numberOfSuccess >= $this->quorum;
    }
}