redelivre / login-cidadao

src/LoginCidadao/CoreBundle/Form/Type/PlaceholderFormType.php

Unused Use Statements -6 removed lines

@@ -4,12 +4,6 @@
 
 use Symfony\Component\Form\FormBuilderInterface;
 use Doctrine\ORM\EntityRepository;
-use LoginCidadao\CoreBundle\Entity\Country;
-use LoginCidadao\CoreBundle\Entity\State;
-use LoginCidadao\CoreBundle\Entity\City;
-use Symfony\Component\Form\FormEvent;
-use Symfony\Component\Form\FormEvents;
-use Doctrine\ORM\EntityManager;
 use Symfony\Component\Form\AbstractType;
 use Symfony\Component\Security\Core\SecurityContext;
 

Indentation +5 added lines, -5 removed lines

@@ -21,27 +21,27 @@
     public function buildForm(FormBuilderInterface $builder, array $options)
     {
         $builder->add('name', 'text',
-                      array(
+                        array(
             'required' => true
         ));
         $builder->add('default', 'text',
-                      array(
+                        array(
             'required' => false
         ));
         $builder->add('id', 'hidden',
-                      array(
+                        array(
             'required' => false
         ));
         $user = $this->getUser();
         $builder->add('category', 'hidden_entity',
-                      array(
+                        array(
             'required' => true,
             'class' => 'LoginCidadaoNotificationBundle:Category',
             'choice_label' => 'name',
             'query_builder' => function (EntityRepository $er) use(&$user) {
                 return $er->createQueryBuilder('u')
                         ->join('LoginCidadaoOAuthBundle:Client', 'c', 'with',
-                               'u.client = c')
+                                'u.client = c')
                         ->where(':person MEMBER OF c.owners')
                         ->setParameter('person', $user)
                         ->orderBy('u.id', 'desc');

Spacing +1 added lines, -1 removed lines

@@ -38,7 +38,7 @@
             'required' => true,
             'class' => 'LoginCidadaoNotificationBundle:Category',
             'choice_label' => 'name',
-            'query_builder' => function (EntityRepository $er) use(&$user) {
+            'query_builder' => function(EntityRepository $er) use(&$user) {
                 return $er->createQueryBuilder('u')
                         ->join('LoginCidadaoOAuthBundle:Client', 'c', 'with',
                                'u.client = c')

src/LoginCidadao/CoreBundle/Form/Type/PlaceOfBirthType.php

Unused Use Statements -1 removed lines

@@ -7,7 +7,6 @@
 use Symfony\Component\Form\FormEvent;
 use Symfony\Component\Form\FormEvents;
 use Symfony\Component\OptionsResolver\OptionsResolver;
-use Doctrine\ORM\EntityManager;
 use Doctrine\ORM\EntityRepository;
 use LoginCidadao\CoreBundle\Entity\State;
 

Spacing +2 added lines, -2 removed lines

@@ -29,7 +29,7 @@ 
     public function buildForm(FormBuilderInterface $builder, array $options)
     {
         $builder->addEventListener(FormEvents::PRE_SET_DATA,
-            function (FormEvent $event) {
+            function(FormEvent $event) {
             $form   = $event->getForm()->getParent();
             $person = $form->getData();
 
@@ -39,7 +39,7 @@ 
             $form->add('city', new CitySelectorComboType($person->getState()));
         });
         $builder->addEventListener(FormEvents::PRE_SUBMIT,
-            function (FormEvent $event) {
+            function(FormEvent $event) {
             $data = $event->getData();
             $form = $event->getForm()->getParent();
 

src/LoginCidadao/CoreBundle/Form/Type/ProfileFormType.php

Unused Use Statements -3 removed lines

@@ -8,10 +8,7 @@
 use LoginCidadao\CoreBundle\Entity\Country;
 use LoginCidadao\CoreBundle\Entity\State;
 use LoginCidadao\CoreBundle\Entity\City;
-use Symfony\Component\Form\FormEvent;
-use Symfony\Component\Form\FormEvents;
 use Doctrine\ORM\EntityManager;
-use LoginCidadao\CoreBundle\Model\PersonInterface;
 
 class ProfileFormType extends BaseType
 {

src/LoginCidadao/CoreBundle/Handler/AuthenticationSuccessHandler.php

Doc Comments +1 added lines, -1 removed lines

@@ -56,7 +56,7 @@
      * is called by authentication listeners inheriting from AbstractAuthenticationListener.
      * @param Request        $request
      * @param TokenInterface $token
-     * @return Response The response to return
+     * @return RedirectResponse The response to return
      */
     function onAuthenticationSuccess(Request $request, TokenInterface $token)
     {

Unused Use Statements -2 removed lines

@@ -5,12 +5,10 @@
 use Symfony\Component\Security\Core\Authentication\Token\TokenInterface;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\Security\Http\Authentication\DefaultAuthenticationSuccessHandler;
-use Symfony\Component\Security\Http\Authentication\AuthenticationSuccessHandlerInterface;
 use Symfony\Component\HttpFoundation\RedirectResponse;
 use Symfony\Component\HttpFoundation\Session\Session;
 use Symfony\Component\Routing\RouterInterface;
 use Doctrine\ORM\EntityManager;
-use LoginCidadao\CoreBundle\Entity\Person;
 use LoginCidadao\CoreBundle\Entity\AccessSession;
 use Symfony\Component\Security\Http\HttpUtils;
 use Symfony\Component\Routing\Generator\UrlGeneratorInterface;

src/LoginCidadao/CoreBundle/Helper/GridHelper.php

Doc Comments +15 added lines, -1 removed lines

@@ -62,12 +62,18 @@ 
         return $this;
     }
 
+    /**
+     * @param integer $var
+     */
     public function setPerPage($var)
     {
         $this->perPage = $var;
         return $this;
     }
 
+    /**
+     * @param integer $var
+     */
     public function setMaxResult($var)
     {
         $this->maxResult = $var;
@@ -76,7 +82,6 @@ 
 
     /**
      * @deprecated since version 1.1.0
-     * @param QueryBuilder $var
      * @return GridHelper
      */
     public function setQueryBuilder(QueryBuilder &$queryBuilder)
@@ -177,6 +182,9 @@ 
         return $this->infiniteGrid;
     }
 
+    /**
+     * @param string $var
+     */
     public function setId($var)
     {
         $this->id = $var;
@@ -188,12 +196,18 @@ 
         return $this->id;
     }
 
+    /**
+     * @param string $var
+     */
     public function setRoute($var)
     {
         $this->route = $var;
         return $this;
     }
 
+    /**
+     * @param string[] $var
+     */
     public function setRouteParams($var)
     {
         $this->routeParams = $var;

Spacing +1 added lines, -1 removed lines

@@ -79,7 +79,7 @@
      * @param QueryBuilder $var
      * @return GridHelper
      */
-    public function setQueryBuilder(QueryBuilder &$queryBuilder)
+    public function setQueryBuilder(QueryBuilder & $queryBuilder)
     {
         $this->queryBuilder = $queryBuilder;
         // create QueryBuilderIterator for legacy code

src/LoginCidadao/CoreBundle/Security/User/Provider/FacebookProvider.php

Doc Comments +3 added lines

@@ -210,6 +210,9 @@
         return $this->loadUserByUsername($user->getFacebookId());
     }
 
+    /**
+     * @param string $username
+     */
     private function prepareFacebookUsername($username, $fbdata)
     {
         $defaultUsername      = $username.'@facebook.com';

src/LoginCidadao/NotificationBundle/Controller/BroadcastController.php

Unused Use Statements -1 removed lines

@@ -14,7 +14,6 @@
 use LoginCidadao\NotificationBundle\Entity\Notification;
 use LoginCidadao\CoreBundle\Helper\GridHelper;
 use LoginCidadao\NotificationBundle\Entity\Broadcast;
-use LoginCidadao\NotificationBundle\Handler\NotificationHandler;
 
 /**
  * @Route("/dev/broadcasts")

Indentation +23 added lines, -23 removed lines

@@ -112,7 +112,7 @@ 
             $em->persist($broadcast);
             $em->flush();
             $url = $this->generateUrl('lc_dev_broadcast_settings',
-              array('broadcastId' => $broadcast->getId()));
+                array('broadcastId' => $broadcast->getId()));
             return $this->redirect($url);
         }
 
@@ -138,23 +138,23 @@ 
 
         $form->handleRequest($request);
         if ($form->isValid()) {
-          $placeholders = $form->get('placeholders')->getData();
-          $broadcast->setHtmlTemplate($placeholders, $form->get('title')->getData(), $form->get('shortText')->getData());
+            $placeholders = $form->get('placeholders')->getData();
+            $broadcast->setHtmlTemplate($placeholders, $form->get('title')->getData(), $form->get('shortText')->getData());
 
-          $translator = $this->get('translator');
-          if ($form->get('saveAndAdd')->isClicked()) {
+            $translator = $this->get('translator');
+            if ($form->get('saveAndAdd')->isClicked()) {
             $this->sendBroadcast($broadcast, $form->get('shortText')->getData(), $form->get('title')->getData());
             $broadcast->setSent(true);
             $this->get('session')->getFlashBag()->add('success', $translator->trans("Broadcast sent"));
-          } else {
+            } else {
             $this->get('session')->getFlashBag()->add('success', $translator->trans("Broadcast saved"));
-          }
+            }
 
-          $em = $this->getDoctrine()->getManager();
-          $em->persist($broadcast);
-          $em->flush();
+            $em = $this->getDoctrine()->getManager();
+            $em->persist($broadcast);
+            $em->flush();
 
-          return $this->redirect($this->generateUrl('lc_dev_broadcasts'));
+            return $this->redirect($this->generateUrl('lc_dev_broadcasts'));
         }
 
         return array('form' => $form->createView());
@@ -165,18 +165,18 @@ 
         $html = $broadcast->getHtmlTemplate();
 
         foreach ($broadcast->getReceivers() as $person) {
-          $notification = new Notification();
-          $notification->setIcon($broadcast->getCategory()->getDefaultIcon());
-          //$notification->setCallbackUrl("url");
-          $notification->setShortText($shortText);
-          $notification->setTitle($title);
-          $notification->setHtmlTemplate($html);
-          $notification->setPerson($person);
-          $notification->setSender($broadcast->getCategory()->getClient());
-          $notification->setCategory($broadcast->getCategory());
-          $notification->setMailTemplate($broadcast->getMailTemplate());
-
-          $helper->send($notification);
+            $notification = new Notification();
+            $notification->setIcon($broadcast->getCategory()->getDefaultIcon());
+            //$notification->setCallbackUrl("url");
+            $notification->setShortText($shortText);
+            $notification->setTitle($title);
+            $notification->setHtmlTemplate($html);
+            $notification->setPerson($person);
+            $notification->setSender($broadcast->getCategory()->getClient());
+            $notification->setCategory($broadcast->getCategory());
+            $notification->setMailTemplate($broadcast->getMailTemplate());
+
+            $helper->send($notification);
         }
     }
 

Spacing +2 added lines, -2 removed lines

@@ -32,7 +32,7 @@ 
         return array('grid' => $grid->createView($request));
     }
 
-    private function getBroadcastGrid(){
+    private function getBroadcastGrid() {
         $em = $this->getDoctrine()->getManager();
         $sql = $em->getRepository('LoginCidadaoNotificationBundle:Broadcast')->createQueryBuilder('c')
             ->where('c.person = :person')
@@ -199,7 +199,7 @@ 
             $sql = $em->getRepository('LoginCidadaoCoreBundle:Person')->getFindAuthorizedByClientIdQuery($parms['client_id']);
             $sql->andWhere('p.cpf like ?1 or p.username like ?1 or p.email like ?1 or p.firstName like ?1 or p.surname like ?1');
             $sql->setParameter('1',
-                '%' . addcslashes($parms['username'], '\\%_') . '%');
+                '%'.addcslashes($parms['username'], '\\%_').'%');
             $sql->addOrderBy('p.id', 'desc');
             $grid->setQueryBuilder($sql);
         }

src/LoginCidadao/NotificationBundle/Controller/JsAPI/NotificationController.php

Unused Use Statements -3 removed lines

@@ -2,10 +2,7 @@
 
 namespace LoginCidadao\NotificationBundle\Controller\JsAPI;
 
-use FOS\RestBundle\Util\Codes;
 use Nelmio\ApiDocBundle\Annotation\ApiDoc;
-use Symfony\Component\HttpFoundation\Request;
-use FOS\RestBundle\Request\ParamFetcherInterface;
 use FOS\RestBundle\Controller\Annotations as REST;
 use FOS\RestBundle\Controller\FOSRestController;
 use LoginCidadao\NotificationBundle\Handler\NotificationHandlerInterface;

src/LoginCidadao/NotificationBundle/Entity/Category.php

Doc Comments +7 added lines, -3 removed lines

@@ -169,6 +169,7 @@ 
 
     /**
      * Set defaultTitle
+     * @param string $defaultTitle
      */
     public function setDefaultTitle($defaultTitle)
     {
@@ -393,13 +394,16 @@ 
     }
 
     /**
-     * @return ClientInterface
+     * @return string
      */
     public function getClient()
     {
         return $this->client;
     }
 
+    /**
+     * @param Client $client
+     */
     public function setClient($client)
     {
         $this->client = $client;
@@ -436,8 +440,8 @@ 
 
     /**
      * Sets the Unique Id of the Entity.
-     * @param string $id the entity UID
-     * @return AbstractUniqueEntity
+     * @param string $uid the entity UID
+     * @return Category
      */
     public function setUid($uid = null)
     {