redelivre / login-cidadao

src/LoginCidadao/APIBundle/Controller/AddressController.php

Unused Use Statements -1 removed lines

@@ -3,7 +3,6 @@
 namespace LoginCidadao\APIBundle\Controller;
 
 use FOS\RestBundle\Controller\FOSRestController;
-use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
 use FOS\RestBundle\Controller\Annotations as REST;
 use Symfony\Component\HttpFoundation\Request;
 use LoginCidadao\CoreBundle\Entity\Country;

Spacing +3 added lines, -3 removed lines

@@ -24,7 +24,7 @@ 
     {
         $query = $this->getDoctrine()->getRepository('LoginCidadaoCoreBundle:Country')
         ->createQueryBuilder('cty')
-        ->where('cty.reviewed = ' . Country::REVIEWED_OK)
+        ->where('cty.reviewed = '.Country::REVIEWED_OK)
         ->orderBy('cty.id', 'ASC');
         return $this->handleView($this->view($query->getQuery()->getResult(Query::HYDRATE_ARRAY)));
     }
@@ -38,7 +38,7 @@ 
     {
         $query = $this->getDoctrine()->getRepository('LoginCidadaoCoreBundle:State')
         ->createQueryBuilder('state')
-        ->where('state.reviewed = ' . Country::REVIEWED_OK);
+        ->where('state.reviewed = '.Country::REVIEWED_OK);
         $country = $request->get('country_id');
         if ($country) {
             $query->join('LoginCidadaoCoreBundle:Country', 'cty', 'WITH', 'state.country = cty');
@@ -58,7 +58,7 @@ 
     {
         $query = $this->getDoctrine()->getRepository('LoginCidadaoCoreBundle:City')
         ->createQueryBuilder('c')
-        ->where('c.reviewed = ' . Country::REVIEWED_OK);
+        ->where('c.reviewed = '.Country::REVIEWED_OK);
         $country = $request->get('country_id');
         $state = $request->get('state_id');
         if ($country || $state) {

src/LoginCidadao/APIBundle/Controller/BaseController.php

Doc Comments +3 added lines

@@ -14,6 +14,9 @@
 class BaseController extends FOSRestController
 {
 
+    /**
+     * @param SerializationContext $context
+     */
     protected function renderWithContext($content, $context = null)
     {
         $person = $this->getUser();

Unused Use Statements -2 removed lines

@@ -5,11 +5,9 @@
 use FOS\RestBundle\Controller\FOSRestController;
 use JMS\Serializer\SerializationContext;
 use Symfony\Component\HttpKernel\Exception\AccessDeniedHttpException;
-use LoginCidadao\CoreBundle\Entity\Person;
 use LoginCidadao\CoreBundle\Entity\Authorization;
 use LoginCidadao\CoreBundle\Model\PersonInterface;
 use LoginCidadao\OAuthBundle\Model\ClientInterface;
-use LoginCidadao\OAuthBundle\Model\ClientUser;
 
 class BaseController extends FOSRestController
 {

Indentation +2 added lines, -2 removed lines

@@ -33,11 +33,11 @@
         $person = $this->getUser();
         $serializer = $this->get('jms_serializer');
         return $serializer->serialize($person, 'json',
-                                      SerializationContext::create()->setGroups($scope));
+                                        SerializationContext::create()->setGroups($scope));
     }
 
     protected function getClientScope(PersonInterface $user,
-                                      ClientInterface $client = null)
+                                        ClientInterface $client = null)
     {
         if ($client === null) {
             $client = $this->getClient();

src/LoginCidadao/APIBundle/Controller/NotificationCallbackController.php

Doc Comments +1 added lines, -3 removed lines

@@ -26,13 +26,11 @@
      *   templateVar="failedCallbacks"
      * )
      *
-     * @param Request                $request       the request object
-     * @param ParamFetcherInterface  $paramFetcher  param fetcher service
      *
      * @REST\Get("/notifications/callbacks/failed", name="api_1_get_failed_notification_callbacks")
      * @Audit\Loggable(type="SELECT")
      *
-     * @return array
+     * @return \Symfony\Component\HttpFoundation\Response
      */
     public function getFailedByClientAction()
     {

src/LoginCidadao/APIBundle/Controller/NotificationController.php

Doc Comments +3 added lines, -4 removed lines

@@ -49,7 +49,7 @@ 
      * @param ParamFetcherInterface  $paramFetcher  param fetcher service
      * @Audit\Loggable(type="SELECT")
      *
-     * @return array
+     * @return \Symfony\Component\HttpFoundation\Response
      */
     public function getNotificationsAction(Request $request,
                                            ParamFetcherInterface $paramFetcher)
@@ -93,9 +93,8 @@ 
      *   }
      * )
      * @REST\View(templateVar="notification")
-     * @param Request $request the request object
      * @param int     $id
-     * @return \LoginCidadao\NotificationBundle\Entity\Notification
+     * @return \Symfony\Component\HttpFoundation\Response
      * @throws NotFoundHttpException when notification not exist
      * @throws AccessDeniedHttpException when trying to access another user's Notification
      * @REST\Get("/notifications/{id}", name="api_1_get_notification")
@@ -172,7 +171,7 @@ 
     /**
      * Fetch a Notification or throw an 404 Exception.
      *
-     * @param mixed $id
+     * @param integer $id
      * @return NotificationInterface
      * @throws NotFoundHttpException
      */

Indentation +7 added lines, -7 removed lines

@@ -52,7 +52,7 @@ 
      * @return array
      */
     public function getNotificationsAction(Request $request,
-                                           ParamFetcherInterface $paramFetcher)
+                                            ParamFetcherInterface $paramFetcher)
     {
         $offset = $paramFetcher->get('offset');
         $offset = null == $offset ? 0 : $offset;
@@ -64,13 +64,13 @@ 
 
         if (array_search('get_all_notifications', $scopes) === false) {
             $notifications = $this->getNotificationHandler()->getAllFromPersonByClient($person,
-                                                                                       $client,
-                                                                                       $limit,
-                                                                                       $offset);
+                                                                                        $client,
+                                                                                        $limit,
+                                                                                        $offset);
         } else {
             $notifications = $this->getNotificationHandler()->getAllFromPerson($person,
-                                                                               $limit,
-                                                                               $offset);
+                                                                                $limit,
+                                                                                $offset);
         }
 
         return $this->renderWithContext($notifications);
@@ -192,7 +192,7 @@ 
         $user = $token->getUser();
         if ($user instanceof ClientUser) {
             return $this->validateNotificationAsClient($user->getClient(),
-                                                       $request);
+                                                        $request);
         } elseif ($user instanceof PersonInterface) {
             return $this->validateNotificationAsPerson($user, $request);
         } else {

src/LoginCidadao/APIBundle/Controller/PersonController.php

Doc Comments +6 added lines

@@ -104,6 +104,9 @@ 
         return $this->handleView($view);
     }
 
+    /**
+     * @param \Closure $callback
+     */
     private function runTimeLimited($callback, $waitTime = 1)
     {
         $maxExecutionTime = ini_get('max_execution_time');
@@ -127,6 +130,9 @@ 
         throw new RequestTimeoutException("Request Timeout");
     }
 
+    /**
+     * @param \DateTime $updatedAt
+     */
     private function getCheckUpdateCallback($id, $updatedAt, $lastUpdatedAt)
     {
         $em     = $this->getDoctrine()->getEntityManager();

Unused Use Statements -4 removed lines

@@ -7,15 +7,11 @@
 use LoginCidadao\APIBundle\Exception\RequestTimeoutException;
 use LoginCidadao\CoreBundle\Entity\Person;
 use LoginCidadao\CoreBundle\Entity\Authorization;
-use Symfony\Component\HttpKernel\Exception\BadRequestHttpException;
-use Symfony\Component\Security\Core\Exception\AccessDeniedException;
 use Symfony\Component\HttpFoundation\Request;
-use Symfony\Component\HttpKernel\Exception\HttpException;
 use LoginCidadao\NotificationBundle\Entity\Notification;
 use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
 use Nelmio\ApiDocBundle\Annotation\ApiDoc;
 use LoginCidadao\CoreBundle\Model\PersonInterface;
-use LoginCidadao\OAuthBundle\Model\ClientInterface;
 use Symfony\Component\HttpKernel\Exception\AccessDeniedHttpException;
 use LoginCidadao\OAuthBundle\Model\ClientUser;
 use LoginCidadao\APIBundle\Security\Audit\Annotation as Audit;

Indentation +2 added lines, -2 removed lines

@@ -173,10 +173,10 @@
             ->createQueryBuilder('a')
             ->select('cnc, p')
             ->join('LoginCidadaoCoreBundle:Person', 'p', 'WITH',
-                   'a.person = p')
+                    'a.person = p')
             ->join('LoginCidadaoOAuthBundle:Client', 'c', 'WITH', 'a.client = c')
             ->join('LoginCidadaoCoreBundle:ConfigNotCli', 'cnc', 'WITH',
-                   'cnc.client = c')
+                    'cnc.client = c')
             ->where('c.id = '.$client->getId().' and p.id = :person_id and cnc.id = :config_id')
             ->getQuery();
         $rowR      = array();

Spacing +3 added lines, -3 removed lines

@@ -167,7 +167,7 @@ 
 
         $body = json_decode($request->getContent(), 1);
 
-        $chkAuth   = $this->getDoctrine()
+        $chkAuth = $this->getDoctrine()
             ->getManager()
             ->getRepository('LoginCidadaoCoreBundle:Authorization')
             ->createQueryBuilder('a')
@@ -191,7 +191,7 @@ 
                     $rowR[$idx] = array('person_id' => $row['person_id'], 'error' => 'missing authorization or configuration');
                     continue;
                 }
-                $not    = new Notification();
+                $not = new Notification();
                 $not->setPerson($res[0]);
                 $not->setConfigNotCli($res[1])
                     ->setIcon(isset($row['icon']) && $row['icon'] ? $row['icon']
@@ -242,7 +242,7 @@ 
             ->findOneBy(array(
             'token' => $token->getToken()
         ));
-        $client      = $accessToken->getClient();
+        $client = $accessToken->getClient();
 
         $people = $this->getDoctrine()->getRepository('LoginCidadaoCoreBundle:Person');
         $person = $people->find($id);

src/LoginCidadao/APIBundle/Entity/ActionLog.php

Doc Comments +2 added lines, -2 removed lines

@@ -410,7 +410,7 @@ 
     /**
      * Get response code
      *
-     * @return integer
+     * @return string
      */
     public function getResponseCode()
     {
@@ -428,7 +428,7 @@ 
     }
 
     /**
-     * @return Client
+     * @return ClientInterface
      */
     public function getClient()
     {

Unused Use Statements -1 removed lines

@@ -3,7 +3,6 @@
 namespace LoginCidadao\APIBundle\Entity;
 
 use Doctrine\ORM\Mapping as ORM;
-use LoginCidadao\CoreBundle\Model\PersonInterface;
 use LoginCidadao\OAuthBundle\Model\ClientInterface;
 
 /**

src/LoginCidadao/APIBundle/Entity/LogoutKey.php

Doc Comments +3 added lines

@@ -79,6 +79,9 @@
         return $this;
     }
 
+    /**
+     * @param string $logoutKey
+     */
     public function setKey($logoutKey)
     {
         $this->logoutKey = $logoutKey;

src/LoginCidadao/APIBundle/Security/Audit/ActionLogger.php

Doc Comments +6 added lines, -1 removed lines

@@ -57,6 +57,9 @@ 
         $annotation->setActionLogId($log->getId());
     }
 
+    /**
+     * @param integer $responseCode
+     */
     public function updateResponseCode($actionLogId, $responseCode)
     {
 
@@ -83,7 +86,6 @@ 
     }
 
     /**
-     * @param Loggable $annotation
      * @param Request $request
      * @param array $controllerAction
      * @param string $auditUsername
@@ -137,6 +139,9 @@ 
         $this->em->flush($log);
     }
 
+    /**
+     * @param boolean $isImpersonating
+     */
     public function registerImpersonate(Request $request,
                                         PersonInterface $person,
                                         PersonInterface $impersonator,

Indentation +2 added lines, -2 removed lines

@@ -90,7 +90,7 @@ 
      * @return ActionLog
      */
     private function initLog(Request $request, $actionType, $controllerAction,
-                             $auditUsername)
+                                $auditUsername)
     {
         $controller = get_class($controllerAction[0]);
         $action     = $controllerAction[1];
@@ -124,7 +124,7 @@ 
     }
 
     public function registerLogin(Request $request, PersonInterface $person,
-                                  array $controllerAction)
+                                    array $controllerAction)
     {
         $auditUsername = $this->auditConfig->getCurrentUsername();
         $actionType    = ActionLog::TYPE_LOGIN;

src/LoginCidadao/CoreBundle/Command/PopulateDatabaseCommand.php

Doc Comments +10 added lines

@@ -31,6 +31,9 @@ 
         $this->createCategories($output);
     }
 
+    /**
+     * @param string $dir
+     */
     private function loadDumpFiles($dir, OutputInterface $output)
     {
         $em = $this->getManager();
@@ -94,6 +97,10 @@ 
         return compact('id', 'name', 'state_id', 'stat', 'reviewed');
     }
 
+    /**
+     * @param string $fileName
+     * @param \Doctrine\DBAL\Statement $query
+     */
     private function loopInsert($dir, $fileName, $query, $prepareFunction, $debug = false)
     {
         $entries = 0;
@@ -112,6 +119,9 @@ 
         return $entries;
     }
 
+    /**
+     * @param string $dir
+     */
     protected function createDefaultOAuthClient($dir, OutputInterface $output)
     {
         if (!($this->getDefaultOAuthClient() instanceof Client)) {

Unused Use Statements -1 removed lines

@@ -5,7 +5,6 @@
 use Symfony\Bundle\FrameworkBundle\Command\ContainerAwareCommand;
 use Symfony\Component\Console\Input\InputArgument;
 use Symfony\Component\Console\Input\InputInterface;
-use Symfony\Component\Console\Input\InputOption;
 use Symfony\Component\Console\Output\OutputInterface;
 use Doctrine\ORM\EntityManager;
 use LoginCidadao\NotificationBundle\Entity\Category;

Spacing +2 added lines, -2 removed lines

@@ -97,7 +97,7 @@ 
     private function loopInsert($dir, $fileName, $query, $prepareFunction, $debug = false)
     {
         $entries = 0;
-        $file = $dir . DIRECTORY_SEPARATOR . $fileName;
+        $file = $dir.DIRECTORY_SEPARATOR.$fileName;
         if (($handle = fopen($file, 'r')) !== false) {
             while (($row = fgetcsv($handle)) !== false) {
                 $data = $prepareFunction($row);
@@ -117,7 +117,7 @@ 
         if (!($this->getDefaultOAuthClient() instanceof Client)) {
             $uid = $this->getContainer()->getParameter('oauth_default_client.uid');
             $pictureName = 'client_logo.png';
-            $picture = new File($dir . DIRECTORY_SEPARATOR . $pictureName);
+            $picture = new File($dir.DIRECTORY_SEPARATOR.$pictureName);
             $domain = $this->getContainer()->getParameter('site_domain');
             $url = "//$domain";
             $grantTypes = array(