Issues in Module.php (master) - Issues in master - redaxscript/redaxscript - Measure and Improve Code Quality continuously with Scrutinizer

Issues (201)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

includes/Module/Module.php (1 issue)

Labels

Bug 1

Severity

Critical 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
namespace Redaxscript\Module;

use Redaxscript\Config;
use Redaxscript\Installer;
use Redaxscript\Language;
use Redaxscript\Model;
use Redaxscript\Registry;
use Redaxscript\Request;
use function array_key_exists;
use function array_merge;
use function is_array;
use function is_dir;

/**
 * parent class to create a module
 *
 * @since 2.2.0
 *
 * @package Redaxscript
 * @category Module
 * @author Henry Ruhs
 */

class Module
{
	/**
	 * array of the module
	 *
	 * @var array
	 */

	protected static array $_moduleArray = [];


	/**
	 * constructor of the class
	 *
	 * @since 3.0.0
	 *
	 * @param Registry $_registry instance of the registry class
	 * @param Request $_request instance of the request class
	 * @param Language $_language instance of the language class
	 * @param Config $_config instance of the config class
	 */

	public function __construct(protected Registry $_registry, protected Request $_request, protected Language $_language, protected Config $_config)
	{
	}

	/**
	 * init the class
	 *
	 * @since 2.4.0
	 *
	 * @param array $moduleArray custom module setup
	 */

	public function init(array $moduleArray = []) : void
	{
		static::$_moduleArray = array_merge(static::$_moduleArray, $moduleArray);

		/* load the language */

		if (is_array(static::$_moduleArray) && array_key_exists('alias', static::$_moduleArray))
		{
			$this->_language->load(
			[
				'modules' . DIRECTORY_SEPARATOR . static::$_moduleArray['alias'] . DIRECTORY_SEPARATOR . 'languages' . DIRECTORY_SEPARATOR . 'en.json',
				'modules' . DIRECTORY_SEPARATOR . static::$_moduleArray['alias'] . DIRECTORY_SEPARATOR . 'languages' . DIRECTORY_SEPARATOR . $this->_registry->get('language') . '.json'
			]);
		}
	}

	/**
	 * install the module
	 *
	 * @since 2.6.0
	 *
	 * @return bool
	 */

	public function install() : bool
	{
		if (is_array(static::$_moduleArray) && array_key_exists('alias', static::$_moduleArray))
		{
			$moduleModel = new Model\Module();
			$moduleModel->createByArray(static::$_moduleArray);

			/* create from sql */

			$directory = 'modules' . DIRECTORY_SEPARATOR . static::$_moduleArray['alias'] . DIRECTORY_SEPARATOR . 'database';
			if (is_dir($directory))
			{
				$installer = new Installer($this->_registry, $this->_request, $this->_language, $this->_config);
				$installer->init($directory);
				$installer->rawCreate();
			}
			$moduleModel->clearCache();
			return $moduleModel->query()->where('alias', static::$_moduleArray['alias'])->count() === 1;
		}
		return false;
	}

	/**
	 * uninstall the module
	 *
	 * @since 2.6.0
	 *
	 * @return bool
	 */

	public function uninstall() : bool
	{
		if (is_array(static::$_moduleArray) && array_key_exists('alias', static::$_moduleArray))
		{
			$moduleModel = new Model\Module();
			$moduleModel->deleteByAlias(static::$_moduleArray['alias']);

			/* drop from sql */

			$directory = 'modules' . DIRECTORY_SEPARATOR . static::$_moduleArray['alias'] . DIRECTORY_SEPARATOR . 'database';
			if (is_dir($directory))
			{
				$installer = new Installer($this->_registry, $this->_request, $this->_language, $this->_config);
				$installer->init($directory);
				$installer->rawDrop();
			}
			$moduleModel->clearCache();
			return $moduleModel->query()->where('alias', static::$_moduleArray['alias'])->count() === 0;
		}
		return false;
	}

	/**
	 * reinstall the module
	 *
	 * @since 4.3.0
	 *
	 * @return bool
	 */

	public function reinstall() : bool
	{
		return $this->uninstall() && $this->install();
	}
}


1		<?php
2		namespace Redaxscript\Module;
3
4		use Redaxscript\Config;
5		use Redaxscript\Installer;
6		use Redaxscript\Language;
7		use Redaxscript\Model;
8		use Redaxscript\Registry;
9		use Redaxscript\Request;
10		use function array_key_exists;
11		use function array_merge;
12		use function is_array;
13		use function is_dir;
14
15		/**
16		* parent class to create a module
17		*
18		* @since 2.2.0
19		*
20		* @package Redaxscript
21		* @category Module
22		* @author Henry Ruhs
23		*/
24
25		class Module
26		{
27		/**
28		* array of the module
29		*
30		* @var array
31		*/
32
33		protected static array $_moduleArray = [];
		0 ignored issues – show Bug introduced 2021-03-27 00:09 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code did not parse for me. Apparently, there is an error somewhere around this line: Syntax error, unexpected T_ARRAY, expecting T_FUNCTION or T_CONST Loading history...
34
35		/**
36		* constructor of the class
37		*
38		* @since 3.0.0
39		*
40		* @param Registry $_registry instance of the registry class
41		* @param Request $_request instance of the request class
42		* @param Language $_language instance of the language class
43		* @param Config $_config instance of the config class
44		*/
45
46		public function __construct(protected Registry $_registry, protected Request $_request, protected Language $_language, protected Config $_config)
47		{
48		}
49
50		/**
51		* init the class
52		*
53		* @since 2.4.0
54		*
55		* @param array $moduleArray custom module setup
56		*/
57
58		public function init(array $moduleArray = []) : void
59		{
60		static::$_moduleArray = array_merge(static::$_moduleArray, $moduleArray);
61
62		/* load the language */
63
64		if (is_array(static::$_moduleArray) && array_key_exists('alias', static::$_moduleArray))
65		{
66		$this->_language->load(
67		[
68		'modules' . DIRECTORY_SEPARATOR . static::$_moduleArray['alias'] . DIRECTORY_SEPARATOR . 'languages' . DIRECTORY_SEPARATOR . 'en.json',
69		'modules' . DIRECTORY_SEPARATOR . static::$_moduleArray['alias'] . DIRECTORY_SEPARATOR . 'languages' . DIRECTORY_SEPARATOR . $this->_registry->get('language') . '.json'
70		]);
71		}
72		}
73
74		/**
75		* install the module
76		*
77		* @since 2.6.0
78	3	*
79		* @return bool
80	3	*/
81	3
82	3	public function install() : bool
83	3	{
84	3	if (is_array(static::$_moduleArray) && array_key_exists('alias', static::$_moduleArray))
85		{
86		$moduleModel = new Model\Module();
87		$moduleModel->createByArray(static::$_moduleArray);
88
89		/* create from sql */
90
91		$directory = 'modules' . DIRECTORY_SEPARATOR . static::$_moduleArray['alias'] . DIRECTORY_SEPARATOR . 'database';
92		if (is_dir($directory))
93		{
94	3	$installer = new Installer($this->_registry, $this->_request, $this->_language, $this->_config);
95		$installer->init($directory);
96	3	$installer->rawCreate();
97		}
98		$moduleModel->clearCache();
99		return $moduleModel->query()->where('alias', static::$_moduleArray['alias'])->count() === 1;
100	3	}
101		return false;
102	2	}
103
104	2	/**
105	2	* uninstall the module
106		*
107		* @since 2.6.0
108	3	*
109		* @return bool
110		*/
111
112		public function uninstall() : bool
113		{
114		if (is_array(static::$_moduleArray) && array_key_exists('alias', static::$_moduleArray))
115		{
116		$moduleModel = new Model\Module();
117		$moduleModel->deleteByAlias(static::$_moduleArray['alias']);
118	2
119		/* drop from sql */
120	2
121		$directory = 'modules' . DIRECTORY_SEPARATOR . static::$_moduleArray['alias'] . DIRECTORY_SEPARATOR . 'database';
122	1	if (is_dir($directory))
123	1	{
124		$installer = new Installer($this->_registry, $this->_request, $this->_language, $this->_config);
125		$installer->init($directory);
126		$installer->rawDrop();
127	1	}
128	1	$moduleModel->clearCache();
129		return $moduleModel->query()->where('alias', static::$_moduleArray['alias'])->count() === 0;
130	1	}
131	1	return false;
132	1	}
133
134	1	/**
135	1	* reinstall the module
136		*
137	1	* @since 4.3.0
138		*
139		* @return bool
140		*/
141
142		public function reinstall() : bool
143		{
144		return $this->uninstall() && $this->install();
145		}
146		}
147

redaxscript / redaxscript

Issues (201)

Security Analysis no request data

includes/Module/Module.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like