Issues in Hash.php (master) - Issues in master - redaxscript/redaxscript - Measure and Improve Code Quality continuously with Scrutinizer

Issues (201)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

includes/Hash.php (1 issue)

Labels

Severity

Minor 1

redaxmedia 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
namespace Redaxscript;

use function constant;
use function defined;
use function is_numeric;
use function is_string;
use function password_hash;
use function password_verify;

/**
 * parent class to create a salted hash
 *
 * @since 2.6.0
 *
 * @package Redaxscript
 * @category Hash
 * @author Henry Ruhs
 */

class Hash
{
	/**
	 * plain raw
	 *
	 * @var string|int
	 */

	protected $_raw;

	/**
	 * salted hash
	 *
	 * @var string
	 */

	protected $_hash;

	/**
	 * init the class
	 *
	 * @since 2.6.0
	 *
	 * @param string|int $raw plain raw
	 */

	public function init($raw = null) : void
	{
		if (is_numeric($raw) || is_string($raw))
		{
			$this->_raw = $raw;
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
		}
		$this->_create();
	}

	/**
	 * get the algorithm
	 *
	 * @since 4.3.0
	 *
	 * @return string|null
	 */

	public function getAlgorithm() : ?string
	{
		if (defined('PASSWORD_ARGON2ID'))
		{
			return constant('PASSWORD_ARGON2ID');
		}
		if (defined('PASSWORD_ARGON2I'))
		{
			return constant('PASSWORD_ARGON2I');
		}
		return constant('PASSWORD_BCRYPT');
	}

	/**
	 * get the raw
	 *
	 * @since 2.6.0
	 *
	 * @return string|int
	 */

	public function getRaw()
	{
		return $this->_raw;
	}

	/**
	 * get the hash
	 *
	 * @since 2.6.0
	 *
	 * @return string
	 */

	public function getHash() : string
	{
		return $this->_hash;
	}

	/**
	 * validate raw again hash
	 *
	 * @since 2.6.0
	 *
	 * @param string|int $raw plain raw
	 * @param string $hash salted hash
	 *
	 * @return bool
	 */

	public function validate($raw = null, string $hash = null) : bool
	{
		return password_verify($raw, $hash);
	}

	/**
	 * create a salted hash
	 *
	 * @since 4.0.0
	 */

	protected function _create() : void
	{
		$this->_hash = password_hash($this->_raw, $this->getAlgorithm());
	}
}


1		<?php
2		namespace Redaxscript;
3
4		use function constant;
5		use function defined;
6		use function is_numeric;
7		use function is_string;
8		use function password_hash;
9		use function password_verify;
10
11		/**
12		* parent class to create a salted hash
13		*
14		* @since 2.6.0
15		*
16		* @package Redaxscript
17		* @category Hash
18		* @author Henry Ruhs
19		*/
20
21		class Hash
22		{
23		/**
24		* plain raw
25		*
26		* @var string\|int
27		*/
28
29		protected $_raw;
30
31		/**
32		* salted hash
33		*
34		* @var string
35		*/
36
37		protected $_hash;
38
39		/**
40		* init the class
41		*
42		* @since 2.6.0
43		*
44		* @param string\|int $raw plain raw
45		*/
46
47	8	public function init($raw = null) : void
48		{
49	8	if (is_numeric($raw) \|\| is_string($raw))
50		{
51	4	$this->_raw = $raw;
		0 ignored issues – show Documentation Bug introduced 2017-10-31 19:54 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$raw` can also be of type `double`. However, the property `$_raw` is declared as type `string\|integer`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
52		}
53	8	$this->_create();
54	8	}
55
56		/**
57		* get the algorithm
58		*
59		* @since 4.3.0
60		*
61		* @return string\|null
62		*/
63
64	8	public function getAlgorithm() : ?string
65		{
66	8	if (defined('PASSWORD_ARGON2ID'))
67		{
68	8	return constant('PASSWORD_ARGON2ID');
69		}
70		if (defined('PASSWORD_ARGON2I'))
71		{
72		return constant('PASSWORD_ARGON2I');
73		}
74		return constant('PASSWORD_BCRYPT');
75		}
76
77		/**
78		* get the raw
79		*
80		* @since 2.6.0
81		*
82		* @return string\|int
83		*/
84
85	4	public function getRaw()
86		{
87	4	return $this->_raw;
88		}
89
90		/**
91		* get the hash
92		*
93		* @since 2.6.0
94		*
95		* @return string
96		*/
97
98	4	public function getHash() : string
99		{
100	4	return $this->_hash;
101		}
102
103		/**
104		* validate raw again hash
105		*
106		* @since 2.6.0
107		*
108		* @param string\|int $raw plain raw
109		* @param string $hash salted hash
110		*
111		* @return bool
112		*/
113
114	2	public function validate($raw = null, string $hash = null) : bool
115		{
116	2	return password_verify($raw, $hash);
117		}
118
119		/**
120		* create a salted hash
121		*
122		* @since 4.0.0
123		*/
124
125	8	protected function _create() : void
126		{
127	8	$this->_hash = password_hash($this->_raw, $this->getAlgorithm());
128	8	}
129		}
130

redaxscript / redaxscript

Issues (201)

Security Analysis no request data

includes/Hash.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like