Issues in InstallTest.php - All Issues - Inspection of "Transition to PHP8 testing part15" - redaxscript/redaxscript - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 4eb4a8...a52438 )

by Henry

created 2021-03-26 22:17 UTC

tests/unit/Controller/InstallTest.php (4 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
namespace Redaxscript\Tests\Controller;

use org\bovigo\vfs\vfsStream as Stream;
use org\bovigo\vfs\vfsStreamFile as StreamFile;
use org\bovigo\vfs\vfsStreamWrapper as StreamWrapper;
use Redaxscript\Controller;
use Redaxscript\Tests\TestCaseAbstract;

/**
 * InstallTest
 *
 * @since 3.0.0
 *
 * @package Redaxscript
 * @category Tests
 * @author Henry Ruhs
 * @author Balázs Szilágyi
 *
 * @covers Redaxscript\Controller\ControllerAbstract
 * @covers Redaxscript\Controller\Install
 *
 * @requires OS Linux
 */

class InstallTest extends TestCaseAbstract
{
	/**
	 * setUp
	 *
	 * @since 3.0.0
	 */

	public function setUp() : void
	{
		parent::setUp();
		Stream::setup('root');
		$file = new StreamFile('config.php');
		StreamWrapper::getRoot()->addChild($file);
	}

	/**
	 * tearDown
	 *
	 * @since 3.1.0
	 */

	public function tearDown() : void
	{
		$this->dropDatabase();
	}

	/**
	 * testProcess
	 *
	 * @since 3.0.0
	 *
	 * @param array $postArray
	 * @param string $method
	 * @param string $expect
	 *
	 * @dataProvider providerAutoloader
	 */

	public function testProcess(array $postArray = [], string $method = null, string $expect = null) : void
	{
		/* setup */

		$postArray['db-type'] = $postArray['db-type'] === '%CURRENT%' ? $this->_config->get('dbType') : $postArray['db-type'];
		$postArray['db-host'] = $postArray['db-host'] === '%CURRENT%' ? $this->_config->get('dbHost') : $postArray['db-host'];
		$postArray['db-name'] = $postArray['db-name'] === '%CURRENT%' ? $this->_config->get('dbName') : $postArray['db-name'];
		$postArray['db-user'] = $postArray['db-user'] === '%CURRENT%' ? $this->_config->get('dbUser') : $postArray['db-user'];
		$postArray['db-password'] = $postArray['db-password'] === '%CURRENT%' ? $this->_config->get('dbPassword') : $postArray['db-password'];
		$postArray['db-prefix'] = $postArray['db-prefix'] === '%CURRENT%' ? $this->_config->get('dbPrefix') : $postArray['db-prefix'];
		$this->_request->set('post', $postArray);
		$this->_config->init(Stream::url('root' . DIRECTORY_SEPARATOR . 'config.php'));
		if ($method)
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
		{
			$installController = $this
				->getMockBuilder('Redaxscript\Controller\Install')
				->setConstructorArgs(
				[
					$this->_registry,
					$this->_request,
					$this->_language,
					$this->_config
				])
				->setMethods(
				[
					$method
				])
				->getMock();

			/* override */

			$installController
				->expects($this->any())
				->method($method);
		}
		else
		{
			$installController = new Controller\Install($this->_registry, $this->_request, $this->_language, $this->_config);
		}

		/* actual */

		$actual = $installController->process();

		/* compare */

		$this->assertEquals($expect, $actual);
	}

	/**
	 * testValidateDatabase
	 *
	 * @since 3.0.0
	 *
	 * @param array $postArray
	 * @param array $expectArray
	 *
	 * @dataProvider providerAutoloader
	 */

	public function testValidateDatabase(array $postArray = [], array $expectArray = []) : void
	{
		/* setup */

		$installController = new Controller\Install($this->_registry, $this->_request, $this->_language, $this->_config);

		/* actual */

		$actualArray = $this->callMethod($installController, '_validateDatabase',
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
		[
			$postArray
		]);

		/* compare */

		$this->assertEquals($expectArray, $actualArray);
	}

	/**
	 * testValidateAccount
	 *
	 * @since 3.0.0
	 *
	 * @param array $postArray
	 * @param array $expectArray
	 *
	 * @dataProvider providerAutoloader
	 */

	public function testValidateAccount(array $postArray = [], array $expectArray = []) : void
	{
		/* setup */

		$installController = new Controller\Install($this->_registry, $this->_request, $this->_language, $this->_config);

		/* actual */

		$actualArray = $this->callMethod($installController, '_validateAccount',
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
		[
			$postArray
		]);

		/* compare */

		$this->assertEquals($expectArray, $actualArray);
	}

	/**
	 * testInstall
	 *
	 * @since 3.0.0
	 *
	 * @param array $installArray
	 * @param bool $expect
	 *
	 * @dataProvider providerAutoloader
	 */

	public function testInstall(array $installArray = [], bool $expect = null) : void
	{
		/* setup */

		$installController = new Controller\Install($this->_registry, $this->_request, $this->_language, $this->_config);

		/* actual */

		$actual = $this->callMethod($installController, '_install',
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
		[
			$installArray
		]);

		/* compare */

		$this->assertEquals($expect, $actual);
	}
}


1			<?php
2			namespace Redaxscript\Tests\Controller;
3
4			use org\bovigo\vfs\vfsStream as Stream;
5			use org\bovigo\vfs\vfsStreamFile as StreamFile;
6			use org\bovigo\vfs\vfsStreamWrapper as StreamWrapper;
7			use Redaxscript\Controller;
8			use Redaxscript\Tests\TestCaseAbstract;
9
10			/**
11			* InstallTest
12			*
13			* @since 3.0.0
14			*
15			* @package Redaxscript
16			* @category Tests
17			* @author Henry Ruhs
18			* @author Balázs Szilágyi
19			*
20			* @covers Redaxscript\Controller\ControllerAbstract
21			* @covers Redaxscript\Controller\Install
22			*
23			* @requires OS Linux
24			*/
25
26			class InstallTest extends TestCaseAbstract
27			{
28			/**
29			* setUp
30			*
31			* @since 3.0.0
32			*/
33
34			public function setUp() : void
35			{
36			parent::setUp();
37			Stream::setup('root');
38			$file = new StreamFile('config.php');
39			StreamWrapper::getRoot()->addChild($file);
40			}
41
42			/**
43			* tearDown
44			*
45			* @since 3.1.0
46			*/
47
48			public function tearDown() : void
49			{
50			$this->dropDatabase();
51			}
52
53			/**
54			* testProcess
55			*
56			* @since 3.0.0
57			*
58			* @param array $postArray
59			* @param string $method
60			* @param string $expect
61			*
62			* @dataProvider providerAutoloader
63			*/
64
65			public function testProcess(array $postArray = [], string $method = null, string $expect = null) : void
66			{
67			/* setup */
68
69			$postArray['db-type'] = $postArray['db-type'] === '%CURRENT%' ? $this->_config->get('dbType') : $postArray['db-type'];
70			$postArray['db-host'] = $postArray['db-host'] === '%CURRENT%' ? $this->_config->get('dbHost') : $postArray['db-host'];
71			$postArray['db-name'] = $postArray['db-name'] === '%CURRENT%' ? $this->_config->get('dbName') : $postArray['db-name'];
72			$postArray['db-user'] = $postArray['db-user'] === '%CURRENT%' ? $this->_config->get('dbUser') : $postArray['db-user'];
73			$postArray['db-password'] = $postArray['db-password'] === '%CURRENT%' ? $this->_config->get('dbPassword') : $postArray['db-password'];
74			$postArray['db-prefix'] = $postArray['db-prefix'] === '%CURRENT%' ? $this->_config->get('dbPrefix') : $postArray['db-prefix'];
75			$this->_request->set('post', $postArray);
76			$this->_config->init(Stream::url('root' . DIRECTORY_SEPARATOR . 'config.php'));
77			if ($method)
			0 ignored issues – show Bug Best Practice introduced 2018-08-25 11:32 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `$method` of type `null\|string` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
78			{
79			$installController = $this
80			->getMockBuilder('Redaxscript\Controller\Install')
81			->setConstructorArgs(
82			[
83			$this->_registry,
84			$this->_request,
85			$this->_language,
86			$this->_config
87			])
88			->setMethods(
89			[
90			$method
91			])
92			->getMock();
93
94			/* override */
95
96			$installController
97			->expects($this->any())
98			->method($method);
99			}
100			else
101			{
102			$installController = new Controller\Install($this->_registry, $this->_request, $this->_language, $this->_config);
103			}
104
105			/* actual */
106
107			$actual = $installController->process();
108
109			/* compare */
110
111			$this->assertEquals($expect, $actual);
112			}
113
114			/**
115			* testValidateDatabase
116			*
117			* @since 3.0.0
118			*
119			* @param array $postArray
120			* @param array $expectArray
121			*
122			* @dataProvider providerAutoloader
123			*/
124
125			public function testValidateDatabase(array $postArray = [], array $expectArray = []) : void
126			{
127			/* setup */
128
129			$installController = new Controller\Install($this->_registry, $this->_request, $this->_language, $this->_config);
130
131			/* actual */
132
133			$actualArray = $this->callMethod($installController, '_validateDatabase',
			0 ignored issues – show Documentation introduced 2018-09-11 17:09 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$installController` is of type `object<Redaxscript\Controller\Install>`, but the function expects a `null\|object<Redaxscript\Tests\object>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
134			[
135			$postArray
136			]);
137
138			/* compare */
139
140			$this->assertEquals($expectArray, $actualArray);
141			}
142
143			/**
144			* testValidateAccount
145			*
146			* @since 3.0.0
147			*
148			* @param array $postArray
149			* @param array $expectArray
150			*
151			* @dataProvider providerAutoloader
152			*/
153
154			public function testValidateAccount(array $postArray = [], array $expectArray = []) : void
155			{
156			/* setup */
157
158			$installController = new Controller\Install($this->_registry, $this->_request, $this->_language, $this->_config);
159
160			/* actual */
161
162			$actualArray = $this->callMethod($installController, '_validateAccount',
			0 ignored issues – show Documentation introduced 2018-09-11 17:09 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$installController` is of type `object<Redaxscript\Controller\Install>`, but the function expects a `null\|object<Redaxscript\Tests\object>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
163			[
164			$postArray
165			]);
166
167			/* compare */
168
169			$this->assertEquals($expectArray, $actualArray);
170			}
171
172			/**
173			* testInstall
174			*
175			* @since 3.0.0
176			*
177			* @param array $installArray
178			* @param bool $expect
179			*
180			* @dataProvider providerAutoloader
181			*/
182
183			public function testInstall(array $installArray = [], bool $expect = null) : void
184			{
185			/* setup */
186
187			$installController = new Controller\Install($this->_registry, $this->_request, $this->_language, $this->_config);
188
189			/* actual */
190
191			$actual = $this->callMethod($installController, '_install',
			0 ignored issues – show Documentation introduced 2018-09-11 17:09 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$installController` is of type `object<Redaxscript\Controller\Install>`, but the function expects a `null\|object<Redaxscript\Tests\object>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
192			[
193			$installArray
194			]);
195
196			/* compare */
197
198			$this->assertEquals($expect, $actual);
199			}
200			}
201

redaxscript / redaxscript

Push — master ( 4eb4a8...a52438 )

tests/unit/Controller/InstallTest.php (4 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like