redaxscript / redaxscript

modules/CssValidator/CssValidator.php

<?php
namespace Redaxscript\Modules\CssValidator;

use Redaxscript\Module;
use Redaxscript\Reader;
use function array_key_exists;
use function http_build_query;
use function urldecode;

/**
 * realtime w3c validator for your css
 *
 * @since 4.0.0
 *
 * @package Redaxscript
 * @category Modules
 * @author Henry Ruhs
 */

class CssValidator extends Module\Metadata
{
	/**
	 * array of the module
	 *
	 * @var array
	 */

	protected static $_moduleArray =
	[
		'name' => 'CSS Validator',
		'alias' => 'CssValidator',
		'author' => 'Redaxmedia',
		'description' => 'Realtime W3C validator for your CSS',
		'version' => '5.0.0',
		'license' => 'MIT',
		'access' => '[1]'
	];

	/**
	 * array of the option
	 *
	 * @var array
	 */

	protected $_optionArray =
	[
		'apiUrl' => 'http://jigsaw.w3.org/css-validator/validator',
		'profile' => 'css3svg'
	];

	/**
	 * adminNotification
	 *
	 * @since 4.0.0
	 *
	 * @return array
	 */

	public function adminNotification() : array
	{
		if ($this->_registry->get('firstParameter') !== 'admin')
		{
			/* load result */

			$url = $this->_optionArray['apiUrl'] . '?' . urldecode(http_build_query(
			[
				'uri' => $this->_registry->get('root') . '/' . $this->_registry->get('parameterRoute') . $this->_registry->get('fullRoute'),
				'profile' => $this->_optionArray['profile'],
				'output' => 'json'
			]));
			$reader = new Reader();
			$reader->init(
			[
				'curl' =>
				[
					CURLOPT_USERAGENT => $this->_language->get('_package')['name']
				]
			]);
			$result = $reader->loadJSON($url)->getArray();

			/* process result */

			if ($result['cssvalidation']['errors'])
			{
				foreach ($result['cssvalidation']['errors'] as $value)
				{
					$message =
					[
						'text' => $value['message'],
						'attr' =>
						[
							'href' => $url,
							'target' => '_blank'
						]
					];
					$this->setNotification('error', $message);
				}
			}
			if (!$result)

The expression $result of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using empty($expr) instead to make it clear that you intend to check for an array without elements.

			{
				$this->setNotification('warning', $this->_language->get('_validator')['service_no'] . $this->_language->get('point'));
			}
			else if (!array_key_exists('error', $this->getNotificationArray()))
			{
				$this->setNotification('success', $this->_language->get('_validator')['document_validate'] . $this->_language->get('point'));
			}
		}
		return $this->getNotificationArray();
	}
}