Issues in ModuleTable.php - All Issues - Inspection of "Transition to PHP8 testing part15" - redaxscript/redaxscript - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 4eb4a8...a52438 )

by Henry

created 2021-03-26 22:17 UTC

includes/Admin/View/ModuleTable.php (2 issues)

Showing only issues like (Show All)

call_checks.maybe_mismatching_type_passed_with_def

Bug Minor

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
namespace Redaxscript\Admin\View;

use Redaxscript\Admin;
use Redaxscript\Filesystem;
use Redaxscript\Filter;
use Redaxscript\Html;
use Redaxscript\Module;
use function array_diff;
use function count;

/**
 * children class to create the admin module table
 *
 * @since 4.0.0
 *
 * @package Redaxscript
 * @category View
 * @author Henry Ruhs
 */

class ModuleTable extends ViewAbstract
{
	/**
	 * render the view
	 *
	 * @since 4.0.0
	 *
	 * @return string
	 */

	public function render() : string
	{
		$output = Module\Hook::trigger('adminModuleTableStart');

		/* html element */

		$element = new Html\Element();
		$titleElement = $element
			->copy()
			->init('h2',
			[
				'class' => 'rs-admin-title-content',
			])
			->text($this->_language->get('modules'));

		/* collect output */

		$output .= $titleElement . $this->_renderTable();
		$output .= Module\Hook::trigger('adminModuleTableEnd');
		return $output;
	}

	/**
	 * render the table
	 *
	 * @since 4.0.0
	 *
	 * @return string|null
	 */

	protected function _renderTable() : ?string
	{
		$output = null;
		$outputHead = null;
		$outputBody = null;
		$outputFoot = null;
		$tableArray =
		[
			'name' => $this->_language->get('name'),
			'description' => $this->_language->get('description'),
			'version' => $this->_language->get('version'),
			'license' => $this->_language->get('license')
		];
		$aliasFilter = new Filter\Alias();
		$adminControl = new Helper\Control($this->_registry, $this->_language);
		$adminControl->init();
		$moduleModel = new Admin\Model\Module();
		$modules = $moduleModel->getAll();
		$modulesTotal = $modules->count();
		$modulesFilesystem = new Filesystem\Filesystem();
		$modulesFilesystem->init('modules');
		$modulesFilesystemArray = $modulesFilesystem->getSortArray();

		/* html element */

		$element = new Html\Element();
		$wrapperElement = $element
			->copy()
			->init('div',
			[
				'class' => 'rs-admin-wrapper-table'
			]);
		$tableElement = $element
			->copy()
			->init('table',
			[
				'class' => 'rs-admin-table-default rs-admin-table-module'
			]);
		$theadElement = $element->copy()->init('thead');
		$tbodyElement = $element->copy()->init('tbody');
		$tfootElement = $element->copy()->init('tfoot');
		$trElement = $element->copy()->init('tr');
		$thElement = $element->copy()->init('th');
		$tdElement = $element->copy()->init('td');
		$linkElement = $element
			->copy()
			->init('a',
			[
				'target' => '_blank'
			]);

		/* process table */

		foreach ($tableArray as $key => $value)
		{
			$outputHead .= $thElement->copy()->text($value);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
			$outputFoot .= $tdElement->copy()->text($value);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
		}

		/* process modules */

		if ($modulesTotal)
		{
			foreach ($modules as $key => $value)
			{
				$outputBody .= $trElement
					->copy()
					->attr('id', 'row-' . $value->id)
					->addClass($value->license === 'Sponsor' ? 'rs-admin-is-sponsored' : null)
					->addClass(!$value->status ? 'rs-admin-is-disabled' : null)
					->html(
						$tdElement->copy()->html(
							$linkElement
								->copy()
								->attr('href', $this->_language->get('_package')['service'] . '/modules/' . $value->alias)
								->text($value->name) .
							$adminControl->render('modules', $value->id, $value->alias, $value->status)) .
						$tdElement->copy()->text($value->description) .
						$tdElement->copy()->text($value->version) .
						$tdElement->copy()->html(
							$linkElement
								->copy()
								->attr('href', $this->_language->get('_package')['service'] . '/licenses/' . $aliasFilter->sanitize($value->license))
								->text($value->license))
				);
				$modulesFilesystemArray = array_diff($modulesFilesystemArray,
				[
					$value->alias
				]);
			}
		}
		if ($modulesFilesystemArray)
		{
			foreach ($modulesFilesystemArray as $key => $value)
			{
				$outputBody .= $trElement
					->copy()
					->html(
						$tdElement
							->copy()
							->attr('colspan', count($tableArray))
							->html($value . $adminControl->render('modules', null, $value, null))
					);
			}
		}
		if (!$modulesTotal && !$modulesFilesystemArray)
		{
			$outputBody .= $trElement
				->copy()
				->html(
					$tdElement
						->copy()
						->attr('colspan', count($tableArray))
						->text($this->_language->get('module_no'))
				);
		}

		/* collect output */

		$outputHead = $theadElement->html(
			$trElement->html($outputHead)
		);
		$outputBody = $tbodyElement->html($outputBody);
		$outputFoot = $tfootElement->html(
			$trElement->html($outputFoot)
		);
		$output .= $wrapperElement->copy()->html(
			$tableElement->html($outputHead . $outputBody . $outputFoot)
		);
		return $output;
	}
}


1		<?php
2		namespace Redaxscript\Admin\View;
3
4		use Redaxscript\Admin;
5		use Redaxscript\Filesystem;
6		use Redaxscript\Filter;
7		use Redaxscript\Html;
8		use Redaxscript\Module;
9		use function array_diff;
10		use function count;
11
12		/**
13		* children class to create the admin module table
14		*
15		* @since 4.0.0
16		*
17		* @package Redaxscript
18		* @category View
19		* @author Henry Ruhs
20		*/
21
22		class ModuleTable extends ViewAbstract
23		{
24		/**
25		* render the view
26		*
27		* @since 4.0.0
28		*
29		* @return string
30		*/
31
32		public function render() : string
33	1	{
34		$output = Module\Hook::trigger('adminModuleTableStart');
35	1
36		/* html element */
37
38		$element = new Html\Element();
39	1	$titleElement = $element
40		->copy()
41	1	->init('h2',
42	1	[
43		'class' => 'rs-admin-title-content',
44	1	])
45		->text($this->_language->get('modules'));
46	1
47		/* collect output */
48
49		$output .= $titleElement . $this->_renderTable();
50	1	$output .= Module\Hook::trigger('adminModuleTableEnd');
51	1	return $output;
52	1	}
53
54		/**
55		* render the table
56		*
57		* @since 4.0.0
58		*
59		* @return string\|null
60		*/
61
62		protected function _renderTable() : ?string
63	1	{
64		$output = null;
65	1	$outputHead = null;
66	1	$outputBody = null;
67	1	$outputFoot = null;
68	1	$tableArray =
69		[
70		'name' => $this->_language->get('name'),
71	1	'description' => $this->_language->get('description'),
72	1	'version' => $this->_language->get('version'),
73	1	'license' => $this->_language->get('license')
74	1	];
75		$aliasFilter = new Filter\Alias();
76	1	$adminControl = new Helper\Control($this->_registry, $this->_language);
77	1	$adminControl->init();
78	1	$moduleModel = new Admin\Model\Module();
79	1	$modules = $moduleModel->getAll();
80	1	$modulesTotal = $modules->count();
81	1	$modulesFilesystem = new Filesystem\Filesystem();
82	1	$modulesFilesystem->init('modules');
83	1	$modulesFilesystemArray = $modulesFilesystem->getSortArray();
84	1
85		/* html element */
86
87		$element = new Html\Element();
88	1	$wrapperElement = $element
89		->copy()
90	1	->init('div',
91	1	[
92		'class' => 'rs-admin-wrapper-table'
93	1	]);
94		$tableElement = $element
95		->copy()
96	1	->init('table',
97	1	[
98		'class' => 'rs-admin-table-default rs-admin-table-module'
99	1	]);
100		$theadElement = $element->copy()->init('thead');
101	1	$tbodyElement = $element->copy()->init('tbody');
102	1	$tfootElement = $element->copy()->init('tfoot');
103	1	$trElement = $element->copy()->init('tr');
104	1	$thElement = $element->copy()->init('th');
105	1	$tdElement = $element->copy()->init('td');
106	1	$linkElement = $element
107		->copy()
108	1	->init('a',
109	1	[
110		'target' => '_blank'
111	1	]);
112
113		/* process table */
114
115		foreach ($tableArray as $key => $value)
116	1	{
117		$outputHead .= $thElement->copy()->text($value);
		0 ignored issues – show Bug introduced 2018-10-17 01:12 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$value` defined by `$value` on line `115` can also be of type `array`; however, `Redaxscript\Html\Element::text()` does only seem to accept `string\|integer\|null`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
118	1	$outputFoot .= $tdElement->copy()->text($value);
		0 ignored issues – show Bug introduced 2018-10-17 01:12 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$value` defined by `$value` on line `115` can also be of type `array`; however, `Redaxscript\Html\Element::text()` does only seem to accept `string\|integer\|null`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
119	1	}
120
121		/* process modules */
122
123		if ($modulesTotal)
124	1	{
125		foreach ($modules as $key => $value)
126	1	{
127		$outputBody .= $trElement
128		->copy()
129	1	->attr('id', 'row-' . $value->id)
130	1	->addClass($value->license === 'Sponsor' ? 'rs-admin-is-sponsored' : null)
131	1	->addClass(!$value->status ? 'rs-admin-is-disabled' : null)
132	1	->html(
133	1	$tdElement->copy()->html(
134	1	$linkElement
135		->copy()
136	1	->attr('href', $this->_language->get('_package')['service'] . '/modules/' . $value->alias)
137	1	->text($value->name) .
138	1	$adminControl->render('modules', $value->id, $value->alias, $value->status)) .
139	1	$tdElement->copy()->text($value->description) .
140	1	$tdElement->copy()->text($value->version) .
141	1	$tdElement->copy()->html(
142	1	$linkElement
143		->copy()
144	1	->attr('href', $this->_language->get('_package')['service'] . '/licenses/' . $aliasFilter->sanitize($value->license))
145	1	->text($value->license))
146	1	);
147		$modulesFilesystemArray = array_diff($modulesFilesystemArray,
148	1	[
149		$value->alias
150	1	]);
151		}
152		}
153		if ($modulesFilesystemArray)
154	1	{
155		foreach ($modulesFilesystemArray as $key => $value)
156	1	{
157		$outputBody .= $trElement
158		->copy()
159	1	->html(
160	1	$tdElement
161		->copy()
162	1	->attr('colspan', count($tableArray))
163	1	->html($value . $adminControl->render('modules', null, $value, null))
164	1	);
165		}
166		}
167		if (!$modulesTotal && !$modulesFilesystemArray)
168	1	{
169		$outputBody .= $trElement
170		->copy()
171		->html(
172		$tdElement
173		->copy()
174		->attr('colspan', count($tableArray))
175		->text($this->_language->get('module_no'))
176		);
177		}
178
179		/* collect output */
180
181		$outputHead = $theadElement->html(
182	1	$trElement->html($outputHead)
183	1	);
184		$outputBody = $tbodyElement->html($outputBody);
185	1	$outputFoot = $tfootElement->html(
186	1	$trElement->html($outputFoot)
187	1	);
188		$output .= $wrapperElement->copy()->html(
189	1	$tableElement->html($outputHead . $outputBody . $outputFoot)
190	1	);
191		return $output;
192	1	}
193		}
194

redaxscript / redaxscript

Push — master ( 4eb4a8...a52438 )

includes/Admin/View/ModuleTable.php (2 issues)

Showing only issues like (Show All)

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like