Issues in CommentTest.php - Fixed Issues - Inspection of "Introduce live reload as option for serving" - redaxscript/redaxscript - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 1da492...320203 )

by Henry

created 2019-12-14 10:20 UTC

tests/unit/Controller/CommentTest.php (7 issues)

Labels

Severity

Henry Ruhs 7

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
namespace Redaxscript\Tests\Controller;

use Redaxscript\Controller;
use Redaxscript\Db;
use Redaxscript\Tests\TestCaseAbstract;

/**
 * CommentTest
 *
 * @since 3.0.0
 *
 * @package Redaxscript
 * @category Tests
 * @author Henry Ruhs
 * @author Balázs Szilágyi
 *
 * @covers Redaxscript\Controller\Comment
 * @covers Redaxscript\Controller\ControllerAbstract
 */

class CommentTest extends TestCaseAbstract
{
	/**
	 * setUp
	 *
	 * @since 3.1.0
	 */

	public function setUp() : void
	{
		parent::setUp();
		$optionArray = $this->getOptionArray();

		$installer = $this->installerFactory();

		$installer->init();
		$installer->rawCreate();
		$installer->insertSettings($optionArray);
		Db::forTablePrefix('articles')
			->create()
			->set(
			[
				'title' => 'Article One',
				'alias' => 'article-one'

			])
			->save();
		$setting = $this->settingFactory();

		$setting->set('captcha', 1);
	}

	/**
	 * tearDown
	 *
	 * @since 3.1.0
	 */

	public function tearDown() : void
	{
		$this->dropDatabase();

	}

	/**
	 * testProcess
	 *
	 * @since 3.0.0
	 *
	 * @param array $postArray
	 * @param array $settingArray
	 * @param string $method
	 * @param string $expect
	 *
	 * @dataProvider providerAutoloader
	 */

	public function testProcess(array $postArray = [], array $settingArray = [], string $method = null, string $expect = null) : void
	{
		/* setup */

		$this->_request->set('post', $postArray);
		$setting = $this->settingFactory();

		$setting->set('notification', $settingArray['notification']);
		$setting->set('moderation', $settingArray['moderation']);
		if ($method)
		{
			$commentController = $this

				->getMockBuilder('Redaxscript\Controller\Comment')
				->setConstructorArgs(
				[
					$this->_registry,
					$this->_request,
					$this->_language,
					$this->_config
				])
				->setMethods(
				[
					$method
				])
				->getMock();

			/* override */

			$commentController
				->expects($this->any())
				->method($method);
		}
		else
		{
			$commentController = new Controller\Comment($this->_registry, $this->_request, $this->_language, $this->_config);
		}

		/* actual */

		$actual = $commentController->process();
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

		/* compare */

		$this->assertEquals($expect, $actual);
	}
}


1			<?php
2			namespace Redaxscript\Tests\Controller;
3
4			use Redaxscript\Controller;
5			use Redaxscript\Db;
6			use Redaxscript\Tests\TestCaseAbstract;
7
8			/**
9			* CommentTest
10			*
11			* @since 3.0.0
12			*
13			* @package Redaxscript
14			* @category Tests
15			* @author Henry Ruhs
16			* @author Balázs Szilágyi
17			*
18			* @covers Redaxscript\Controller\Comment
19			* @covers Redaxscript\Controller\ControllerAbstract
20			*/
21
22			class CommentTest extends TestCaseAbstract
23			{
24			/**
25			* setUp
26			*
27			* @since 3.1.0
28			*/
29
30			public function setUp() : void
31			{
32			parent::setUp();
33			$optionArray = $this->getOptionArray();
			0 ignored issues – show Bug introduced 2019-09-24 20:34 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `getOptionArray()` does not seem to exist on `object<Redaxscript\Tests\Controller\CommentTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
34			$installer = $this->installerFactory();
			0 ignored issues – show Bug introduced 2018-12-21 00:24 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `installerFactory()` does not seem to exist on `object<Redaxscript\Tests\Controller\CommentTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
35			$installer->init();
36			$installer->rawCreate();
37			$installer->insertSettings($optionArray);
38			Db::forTablePrefix('articles')
39			->create()
40			->set(
41			[
42			'title' => 'Article One',
43			'alias' => 'article-one'
44
45			])
46			->save();
47			$setting = $this->settingFactory();
			0 ignored issues – show Bug introduced 2018-12-21 00:24 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `settingFactory()` does not seem to exist on `object<Redaxscript\Tests\Controller\CommentTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
48			$setting->set('captcha', 1);
49			}
50
51			/**
52			* tearDown
53			*
54			* @since 3.1.0
55			*/
56
57			public function tearDown() : void
58			{
59			$this->dropDatabase();
			0 ignored issues – show Bug introduced 2018-12-21 00:24 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `dropDatabase()` does not seem to exist on `object<Redaxscript\Tests\Controller\CommentTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
60			}
61
62			/**
63			* testProcess
64			*
65			* @since 3.0.0
66			*
67			* @param array $postArray
68			* @param array $settingArray
69			* @param string $method
70			* @param string $expect
71			*
72			* @dataProvider providerAutoloader
73			*/
74
75			public function testProcess(array $postArray = [], array $settingArray = [], string $method = null, string $expect = null) : void
76			{
77			/* setup */
78
79			$this->_request->set('post', $postArray);
80			$setting = $this->settingFactory();
			0 ignored issues – show Bug introduced 2018-12-21 00:24 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `settingFactory()` does not seem to exist on `object<Redaxscript\Tests\Controller\CommentTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
81			$setting->set('notification', $settingArray['notification']);
82			$setting->set('moderation', $settingArray['moderation']);
83			if ($method)
84			{
85			$commentController = $this
			0 ignored issues – show Deprecated Code introduced 2019-09-24 20:34 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `PHPUnit\Framework\MockOb...ckBuilder::setMethods()` has been deprecated with message: https://github.com/sebastianbergmann/phpunit/pull/3687 This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history...
86			->getMockBuilder('Redaxscript\Controller\Comment')
87			->setConstructorArgs(
88			[
89			$this->_registry,
90			$this->_request,
91			$this->_language,
92			$this->_config
93			])
94			->setMethods(
95			[
96			$method
97			])
98			->getMock();
99
100			/* override */
101
102			$commentController
103			->expects($this->any())
104			->method($method);
105			}
106			else
107			{
108			$commentController = new Controller\Comment($this->_registry, $this->_request, $this->_language, $this->_config);
109			}
110
111			/* actual */
112
113			$actual = $commentController->process();
			0 ignored issues – show Bug introduced 2019-04-22 21:27 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `process` does only exist in `Redaxscript\Controller\Comment`, but not in `PHPUnit\Framework\MockObject\MockObject`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
114
115			/* compare */
116
117			$this->assertEquals($expect, $actual);
118			}
119			}
120

redaxscript / redaxscript

Push — master ( 1da492...320203 )

tests/unit/Controller/CommentTest.php (7 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Duplication Side-by-Side

Filter issues like