Template::autorun() - Code Metrics - Inspection of "Transition to PHP8 testing part9" - redaxscript/redaxscript - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( e9cd30...c2303d )

by Henry

created 2021-02-21 12:13 UTC

Template::autorun() A

↳ Parent: Template

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	16
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	23
ccs	16
cts	16
cp	1
rs	9.552
c	0
b	0
f	0
cc	2
nc	2
nop	0
crap	2

<?php
namespace Redaxscript\Detector;

use Redaxscript\Filter;
use Redaxscript\Model;

/**
 * children class to detect the current template
 *
 * @since 2.0.0
 *
 * @package Redaxscript
 * @category Detector
 * @author Henry Ruhs
 */

class Template extends DetectorAbstract
{
	/**
	 * automate run
	 *
	 * @since 2.1.0
	 */

	public function autorun() : void
	{
		$settingModel = new Model\Setting();
		$contentModel = new Model\Content();
		$specialFilter = new Filter\Special();
		$dbStatus = $this->_registry->get('dbStatus');
		$lastTable = $this->_registry->get('lastTable');
		$lastId = $this->_registry->get('lastId');
		$content = $contentModel->getByTableAndId($lastTable, $lastId);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
		$path = 'templates' . DIRECTORY_SEPARATOR . $this->_filePlaceholder . DIRECTORY_SEPARATOR . 'index.phtml';
		$setupArray =
		[
			'query' => $specialFilter->sanitize($this->_request->getQuery('t')),

			'session' => $this->_request->getSession('template'),
			'contents' => $content->template ?? null,
			'settings' => $dbStatus === 2 ? $settingModel->get('template') : null,
			'fallback' => 'default'
		];

		/* detect template */

		$this->_output = $this->_detect('template', $path, $setupArray);
	}
}


1		<?php
2		namespace Redaxscript\Detector;
3
4		use Redaxscript\Filter;
5		use Redaxscript\Model;
6
7		/**
8		* children class to detect the current template
9		*
10		* @since 2.0.0
11		*
12		* @package Redaxscript
13		* @category Detector
14		* @author Henry Ruhs
15		*/
16
17		class Template extends DetectorAbstract
18		{
19		/**
20		* automate run
21		*
22		* @since 2.1.0
23		*/
24
25	7	public function autorun() : void
26		{
27	7	$settingModel = new Model\Setting();
28	7	$contentModel = new Model\Content();
29	7	$specialFilter = new Filter\Special();
30	7	$dbStatus = $this->_registry->get('dbStatus');
31	7	$lastTable = $this->_registry->get('lastTable');
32	7	$lastId = $this->_registry->get('lastId');
33	7	$content = $contentModel->getByTableAndId($lastTable, $lastId);
		0 ignored issues – show Bug introduced 2021-02-21 12:18 UTC by Report Bug Copy Issue Report It seems like `$lastTable` defined by `$this->_registry->get('lastTable')` on line `31` can also be of type `array`; however, `Redaxscript\Model\Content::getByTableAndId()` does only seem to accept `null\|string`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string / function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history... Bug introduced 2021-02-21 12:18 UTC by Report Bug Copy Issue Report It seems like `$lastId` defined by `$this->_registry->get('lastId')` on line `32` can also be of type `array` or `string`; however, `Redaxscript\Model\Content::getByTableAndId()` does only seem to accept `null\|integer`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /* * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
34	7	$path = 'templates' . DIRECTORY_SEPARATOR . $this->_filePlaceholder . DIRECTORY_SEPARATOR . 'index.phtml';
35		$setupArray =
36		[
37	7	'query' => $specialFilter->sanitize($this->_request->getQuery('t')),
		0 ignored issues – show Bug introduced 2020-07-04 08:24 UTC by Report Bug Copy Issue Report It seems like `$this->_request->getQuery('t')` targeting `Redaxscript\Request::getQuery()` can also be of type `array`; however, `Redaxscript\Filter\Special::sanitize()` does only seem to accept `null\|string`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
38	7	'session' => $this->_request->getSession('template'),
39	7	'contents' => $content->template ?? null,
40	7	'settings' => $dbStatus === 2 ? $settingModel->get('template') : null,
41	7	'fallback' => 'default'
42		];
43
44		/* detect template */
45
46	7	$this->_output = $this->_detect('template', $path, $setupArray);
47	7	}
48		}
49

redaxscript / redaxscript

Push — master ( e9cd30...c2303d )

Template::autorun() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like