Issues in InstallForm.php - New Issues - Inspection of "Show disabled select on missing PDO drivers" - redaxscript/redaxscript - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( c9f770...4e7f70 )

by Henry

created 2020-07-22 22:03 UTC

includes/View/InstallForm.php (1 issue)

Labels

Bug 1

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
namespace Redaxscript\View;

use Redaxscript\Html;
use Redaxscript\Module;
use Redaxscript\Validator;

/**
 * children class to create the install form
 *
 * @since 3.0.0
 *
 * @package Redaxscript
 * @category View
 * @author Henry Ruhs
 */

class InstallForm extends ViewAbstract
{
	/**
	 * render the view
	 *
	 * @param array $installArray
	 *
	 * @since 3.0.0
	 *
	 * @return string
	 */

	public function render(array $installArray = []) : string
	{
		$output = Module\Hook::trigger('installFormStart');
		$nameValidator = new Validator\Name();
		$userValidator = new Validator\User();
		$passwordValidator = new Validator\Password();

		/* html element */

		$titleElement = new Html\Element();
		$titleElement
			->init('h2',
			[
				'class' => 'rs-title-content'
			])
			->text($this->_language->get('installation'));
		$formElement = new Html\Form($this->_registry, $this->_language);
		$formElement->init(
		[
			'form' =>
			[
				'class' => 'rs-js-validate rs-js-behavior rs-component-accordion rs-form-default rs-form-install'
			],
			'button' =>
			[
				'submit' =>
				[
					'class' => 'rs-js-submit rs-button-default rs-is-full',
					'name' => self::class
				]
			]
		]);

		/* create the form */

		$formElement

			/* database */

			->radio(
			[
				'id' => self::class . '\Database',
				'class' => 'rs-fn-status-accordion',
				'name' => self::class . '\Accordion',
				'checked' => 'checked'
			])
			->label($this->_language->get('database_setup'),
			[
				'class' => 'rs-fn-toggle-accordion rs-label-accordion',
				'for' => self::class . '\Database'
			])
			->append('<ul class="rs-fn-content-accordion rs-box-accordion"><li>')
			->label($this->_language->get('type'),
			[
				'for' => 'db-type'
			])
			->select($this->_registry->get('driverArray'),

			[
				$installArray['dbType']
			],
			$this->_registry->get('driverArray') ?
			[
				'id' => 'db-type',
				'name' => 'db-type'
			] :
			[
				'id' => 'db-type',
				'name' => 'db-type',
				'disabled' => 'disabled'
			])
			->append('</li><li>')
			->label($this->_language->get('host'),
			[
				'for' => 'db-host'
			])
			->text(
			[
				'id' => 'db-host',
				'name' => 'db-host',
				'required' => 'required',
				'value' => $installArray['dbHost']
			])
			->append('</li><li>')
			->label($this->_language->get('name'),
			[
				'for' => 'db-name'
			])
			->text(
			[
				'id' => 'db-name',
				'name' => 'db-name',
				'required' => 'required',
				'value' => $installArray['dbName']
			])
			->append('</li><li>')
			->label($this->_language->get('user'),
			[
				'for' => 'db-user'
			])
			->text(
			[
				'id' => 'db-user',
				'name' => 'db-user',
				'required' => 'required',
				'value' => $installArray['dbUser']
			])
			->append('</li><li>')
			->label($this->_language->get('password'),
			[
				'for' => 'db-password'
			])
			->password(
			[
				'id' => 'db-password',
				'name' => 'db-password',
				'value' => $installArray['dbPassword']
			])
			->append('</li><li>')
			->label($this->_language->get('prefix'),
			[
				'for' => 'db-prefix'
			])
			->text(
			[
				'id' => 'db-prefix',
				'name' => 'db-prefix',
				'value' => $installArray['dbPrefix']
			])
			->append('</li></ul>')

			/* account */

			->radio(
			[
				'id' => self::class . '\Account',
				'class' => 'rs-fn-status-accordion',
				'name' => self::class . '\Accordion'
			])
			->label($this->_language->get('account_create'),
			[
				'class' => 'rs-fn-toggle-accordion rs-label-accordion',
				'for' => self::class . '\Account'
			])
			->append('<ul class="rs-fn-content-accordion rs-box-accordion"><li>')
			->label($this->_language->get('name'),
			[
				'for' => 'name'
			])
			->text(
			[
				'id' => 'admin-name',
				'name' => 'admin-name',
				'pattern' => $nameValidator->getPattern(),
				'required' => 'required',
				'value' => $installArray['adminName']
			])
			->append('</li><li>')
			->label($this->_language->get('user'),
			[
				'for' => 'admin-user'
			])
			->text(
			[
				'id' => 'admin-user',
				'name' => 'admin-user',
				'pattern' => $userValidator->getPattern(),
				'required' => 'required',
				'value' => $installArray['adminUser']
			])
			->append('</li><li>')
			->label($this->_language->get('password'),
			[
				'for' => 'admin-password'
			])
			->password(
			[
				'id' => 'admin-password',
				'name' => 'admin-password',
				'pattern' => $passwordValidator->getPattern(),
				'required' => 'required',
				'value' => $installArray['adminPassword']
			])
			->append('</li><li>')
			->label($this->_language->get('email'),
			[
				'for' => 'admin-email'
			])
			->email(
			[
				'id' => 'admin-email',
				'name' => 'admin-email',
				'required' => 'required',
				'value' => $installArray['adminEmail']
			])
			->append('</li></ul>')
			->hidden(
			[
				'name' => 'refresh-connection',
				'value' => 1
			])
			->token()
			->submit($this->_language->get('install'));

		/* collect output */

		$output .= $titleElement . $formElement;
		$output .= Module\Hook::trigger('installFormEnd');
		return $output;
	}
}


1		<?php
2		namespace Redaxscript\View;
3
4		use Redaxscript\Html;
5		use Redaxscript\Module;
6		use Redaxscript\Validator;
7
8		/**
9		* children class to create the install form
10		*
11		* @since 3.0.0
12		*
13		* @package Redaxscript
14		* @category View
15		* @author Henry Ruhs
16		*/
17
18		class InstallForm extends ViewAbstract
19		{
20		/**
21		* render the view
22		*
23		* @param array $installArray
24		*
25		* @since 3.0.0
26		*
27		* @return string
28		*/
29
30	1	public function render(array $installArray = []) : string
31		{
32	1	$output = Module\Hook::trigger('installFormStart');
33	1	$nameValidator = new Validator\Name();
34	1	$userValidator = new Validator\User();
35	1	$passwordValidator = new Validator\Password();
36
37		/* html element */
38
39	1	$titleElement = new Html\Element();
40		$titleElement
41	1	->init('h2',
42		[
43	1	'class' => 'rs-title-content'
44		])
45	1	->text($this->_language->get('installation'));
46	1	$formElement = new Html\Form($this->_registry, $this->_language);
47	1	$formElement->init(
48		[
49	1	'form' =>
50		[
51		'class' => 'rs-js-validate rs-js-behavior rs-component-accordion rs-form-default rs-form-install'
52		],
53		'button' =>
54		[
55		'submit' =>
56		[
57		'class' => 'rs-js-submit rs-button-default rs-is-full',
58		'name' => self::class
59		]
60		]
61		]);
62
63		/* create the form */
64
65		$formElement
66
67		/* database */
68
69	1	->radio(
70		[
71	1	'id' => self::class . '\Database',
72		'class' => 'rs-fn-status-accordion',
73		'name' => self::class . '\Accordion',
74		'checked' => 'checked'
75		])
76	1	->label($this->_language->get('database_setup'),
77		[
78	1	'class' => 'rs-fn-toggle-accordion rs-label-accordion',
79		'for' => self::class . '\Database'
80		])
81	1	->append('<ul class="rs-fn-content-accordion rs-box-accordion"><li>')
82	1	->label($this->_language->get('type'),
83		[
84		'for' => 'db-type'
85	1	])
86	1	->select($this->_registry->get('driverArray'),
		0 ignored issues – show Bug introduced 2020-07-22 22:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$this->_registry->get('driverArray')` targeting `Redaxscript\Registry::get()` can also be of type `null` or `string`; however, `Redaxscript\Html\Form::select()` does only seem to accept `array`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
87		[
88	1	$installArray['dbType']
89		],
90	1	$this->_registry->get('driverArray') ?
91		[
92	1	'id' => 'db-type',
93		'name' => 'db-type'
94		] :
95	1	[
96		'id' => 'db-type',
97		'name' => 'db-type',
98	1	'disabled' => 'disabled'
99		])
100		->append('</li><li>')
101	1	->label($this->_language->get('host'),
102	1	[
103		'for' => 'db-host'
104	1	])
105		->text(
106	1	[
107		'id' => 'db-host',
108	1	'name' => 'db-host',
109	1	'required' => 'required',
110	1	'value' => $installArray['dbHost']
111	1	])
112		->append('</li><li>')
113	1	->label($this->_language->get('name'),
114	1	[
115		'for' => 'db-name'
116	1	])
117		->text(
118	1	[
119		'id' => 'db-name',
120	1	'name' => 'db-name',
121	1	'required' => 'required',
122	1	'value' => $installArray['dbName']
123	1	])
124		->append('</li><li>')
125	1	->label($this->_language->get('user'),
126	1	[
127		'for' => 'db-user'
128	1	])
129		->text(
130	1	[
131		'id' => 'db-user',
132	1	'name' => 'db-user',
133	1	'required' => 'required',
134	1	'value' => $installArray['dbUser']
135	1	])
136		->append('</li><li>')
137	1	->label($this->_language->get('password'),
138	1	[
139		'for' => 'db-password'
140	1	])
141		->password(
142	1	[
143		'id' => 'db-password',
144	1	'name' => 'db-password',
145	1	'value' => $installArray['dbPassword']
146	1	])
147		->append('</li><li>')
148	1	->label($this->_language->get('prefix'),
149	1	[
150		'for' => 'db-prefix'
151	1	])
152		->text(
153	1	[
154		'id' => 'db-prefix',
155	1	'name' => 'db-prefix',
156	1	'value' => $installArray['dbPrefix']
157	1	])
158		->append('</li></ul>')
159	1
160		/* account */
161
162		->radio(
163	1	[
164		'id' => self::class . '\Account',
165	1	'class' => 'rs-fn-status-accordion',
166		'name' => self::class . '\Accordion'
167		])
168		->label($this->_language->get('account_create'),
169	1	[
170		'class' => 'rs-fn-toggle-accordion rs-label-accordion',
171	1	'for' => self::class . '\Account'
172		])
173		->append('<ul class="rs-fn-content-accordion rs-box-accordion"><li>')
174	1	->label($this->_language->get('name'),
175	1	[
176		'for' => 'name'
177	1	])
178		->text(
179	1	[
180		'id' => 'admin-name',
181	1	'name' => 'admin-name',
182	1	'pattern' => $nameValidator->getPattern(),
183	1	'required' => 'required',
184	1	'value' => $installArray['adminName']
185	1	])
186		->append('</li><li>')
187	1	->label($this->_language->get('user'),
188	1	[
189		'for' => 'admin-user'
190	1	])
191		->text(
192	1	[
193		'id' => 'admin-user',
194	1	'name' => 'admin-user',
195	1	'pattern' => $userValidator->getPattern(),
196	1	'required' => 'required',
197	1	'value' => $installArray['adminUser']
198	1	])
199		->append('</li><li>')
200	1	->label($this->_language->get('password'),
201	1	[
202		'for' => 'admin-password'
203	1	])
204		->password(
205	1	[
206		'id' => 'admin-password',
207	1	'name' => 'admin-password',
208	1	'pattern' => $passwordValidator->getPattern(),
209	1	'required' => 'required',
210	1	'value' => $installArray['adminPassword']
211	1	])
212		->append('</li><li>')
213	1	->label($this->_language->get('email'),
214	1	[
215		'for' => 'admin-email'
216	1	])
217		->email(
218	1	[
219		'id' => 'admin-email',
220	1	'name' => 'admin-email',
221	1	'required' => 'required',
222	1	'value' => $installArray['adminEmail']
223	1	])
224		->append('</li></ul>')
225	1	->hidden(
226	1	[
227		'name' => 'refresh-connection',
228	1	'value' => 1
229		])
230		->token()
231	1	->submit($this->_language->get('install'));
232	1
233		/* collect output */
234
235		$output .= $titleElement . $formElement;
236	1	$output .= Module\Hook::trigger('installFormEnd');
237	1	return $output;
238	1	}
239		}
240

redaxscript / redaxscript

Push — master ( c9f770...4e7f70 )

includes/View/InstallForm.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like