Redaxscript\Navigation\Category

Complexity

Total Complexity

9

Size/Duplication

Total Lines	126
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	8

Test Coverage

Coverage

100%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	render()	0	21	1
B	renderList()	0	64	8

<?php
namespace Redaxscript\Navigation;

use Redaxscript\Html;
use Redaxscript\Model;
use Redaxscript\Module;
use Redaxscript\Validator;

/**
 * children class to create the category navigation
 *
 * @since 3.3.0
 *
 * @package Redaxscript
 * @category Navigation
 * @author Henry Ruhs
 */

class Category extends NavigationAbstract
{
	/**
	 * options of the navigation
	 *
	 * @var array
	 */

	protected $_optionArray =
	[
		'className' =>
		[
			'list' => 'rs-list-categories',
			'children' => 'rs-list-children',
			'active' => 'rs-item-active'
		],
		'orderColumn' => 'rank',
		'parentId' => 0
	];

	/**
	 * render the view
	 *
	 * @since 3.3.0
	 *
	 * @return string
	 */

	public function render() : string
	{
		$output = Module\Hook::trigger('navigationCategoryStart');
		$categoryModel = new Model\Category();

		/* query categories */

		$categories = $categoryModel
			->query()
			->whereLanguageIs($this->_registry->get('language'))

It seems like $this->_registry->get('language') targeting Redaxscript\Registry::get() can also be of type array; however, Redaxscript\Db::whereLanguageIs() does only seem to accept null|string, maybe add an additional type check?

			->where('status', 1)
			->orderBySetting($this->_optionArray['orderColumn'])
			->limit($this->_optionArray['limit'])
			->findMany();

		/* collect output */

		$output .= $this->renderList($categories, $this->_optionArray);
		$output .= Module\Hook::trigger('navigationCategoryEnd');
		return $output;
	}

	/**
	 * render the list
	 *
	 * @since 3.3.0
	 *
	 * @param object $categories
	 * @param array $optionArray
	 *
	 * @return string|null
	 */

	protected function renderList(object $categories = null, array $optionArray = []) : ?string
	{
		$output = null;
		$outputItem = null;
		$categoryModel = new Model\Category();
		$accessValidator = new Validator\Access();

		/* html element */

		$element = new Html\Element();
		$listElement = $element
			->copy()
			->init('ul',
			[
				'class' => $optionArray['className']['list']
			]);
		$itemElement = $element->copy()->init('li');
		$linkElement = $element->copy()->init('a');

		/* collect item output */

		foreach ($categories as $value)

The expression $categories of type null|object<Redaxscript\Navigation\object> is not guaranteed to be traversable. How about adding an additional type check?

		{
			if ($accessValidator->validate($value->access, $this->_registry->get('myGroups')) && $optionArray['parentId'] === (int)$value->parent)

It seems like $this->_registry->get('myGroups') targeting Redaxscript\Registry::get() can also be of type array; however, Redaxscript\Validator\Access::validate() does only seem to accept null|string, maybe add an additional type check?

			{
				$outputItem .= $itemElement
					->copy()
					->addClass((int)$this->_registry->get('categoryId') === (int)$value->id ? $this->_optionArray['className']['active'] : null)
					->html($linkElement
						->copy()
						->attr(
						[
							'href' => $this->_registry->get('parameterRoute') . $categoryModel->getRouteById($value->id)
						])
						->text($value->title)
					)
					->append(
						$this->renderList($categories,
						[
							'className' =>
							[
								'list' => $value->parent ? $optionArray['className']['list'] : $optionArray['className']['children'],
								'active' => $optionArray['className']['active'],
							],
							'parentId' => (int)$value->id
						])
					);
			}
		}

		/* collect output */

		if ($outputItem)

The expression $outputItem of type string|null is loosely compared to true; this is ambiguous if the string can be empty. You might want to explicitly use !== null instead.

		{
			$output .= $listElement->html($outputItem);
		}
		else if (!$categories->count())
		{
			$output .= $listElement->html(
				$itemElement->text($this->_language->get('category_no'))

It seems like $this->_language->get('category_no') targeting Redaxscript\Language::get() can also be of type array; however, Redaxscript\Html\Element::text() does only seem to accept string|integer|null, maybe add an additional type check?

			);
		}
		return $output;
	}
}