Issues in RecoverTest.php - All Issues - Inspection of "Modernize Singleton class" - redaxscript/redaxscript - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 7de195...5f1ca1 )

by Henry

created 2021-02-21 20:51 UTC

tests/unit/Controller/RecoverTest.php (2 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
namespace Redaxscript\Tests\Controller;

use Redaxscript\Controller;
use Redaxscript\Tests\TestCaseAbstract;

/**
 * RecoverTest
 *
 * @since 3.0.0
 *
 * @package Redaxscript
 * @category Tests
 * @author Henry Ruhs
 * @author Balázs Szilágyi
 *
 * @covers Redaxscript\Controller\ControllerAbstract
 * @covers Redaxscript\Controller\Recover
 *
 * @requires OS Linux
 */

class RecoverTest extends TestCaseAbstract
{
	/**
	 * setUp
	 *
	 * @since 3.1.0
	 */

	public function setUp() : void
	{
		parent::setUp();
		$optionArray = $this->getOptionArray();
		$installer = $this->installerFactory();
		$installer->init();
		$installer->rawCreate();
		$installer->insertSettings($optionArray);
		$installer->insertUsers($optionArray);
		$setting = $this->settingFactory();
		$setting->set('captcha', 1);
	}

	/**
	 * tearDown
	 *
	 * @since 3.1.0
	 */

	public function tearDown() : void
	{
		$this->dropDatabase();
	}

	/**
	 * testProcess
	 *
	 * @since 3.0.0
	 *
	 * @param array $postArray
	 * @param string $method
	 * @param string $expect
	 *
	 * @dataProvider providerAutoloader
	 */

	public function testProcess(array $postArray = [], string $method = null, string $expect = null) : void
	{
		/* setup */

		$this->_request->set('post', $postArray);
		if ($method)
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
		{
			$recoverController = $this
				->getMockBuilder('Redaxscript\Controller\Recover')
				->setConstructorArgs(
				[
					$this->_registry,
					$this->_request,
					$this->_language,
					$this->_config
				])
				->setMethods(
				[
					$method
				])
				->getMock();

			/* override */

			$recoverController
				->expects($this->any())
				->method($method);
		}
		else
		{
			$recoverController = new Controller\Recover($this->_registry, $this->_request, $this->_language, $this->_config);
		}

		/* actual */

		$actual = $recoverController->process();
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

		/* compare */

		$this->assertEquals($expect, $actual);
	}
}


1			<?php
2			namespace Redaxscript\Tests\Controller;
3
4			use Redaxscript\Controller;
5			use Redaxscript\Tests\TestCaseAbstract;
6
7			/**
8			* RecoverTest
9			*
10			* @since 3.0.0
11			*
12			* @package Redaxscript
13			* @category Tests
14			* @author Henry Ruhs
15			* @author Balázs Szilágyi
16			*
17			* @covers Redaxscript\Controller\ControllerAbstract
18			* @covers Redaxscript\Controller\Recover
19			*
20			* @requires OS Linux
21			*/
22
23			class RecoverTest extends TestCaseAbstract
24			{
25			/**
26			* setUp
27			*
28			* @since 3.1.0
29			*/
30
31			public function setUp() : void
32			{
33			parent::setUp();
34			$optionArray = $this->getOptionArray();
35			$installer = $this->installerFactory();
36			$installer->init();
37			$installer->rawCreate();
38			$installer->insertSettings($optionArray);
39			$installer->insertUsers($optionArray);
40			$setting = $this->settingFactory();
41			$setting->set('captcha', 1);
42			}
43
44			/**
45			* tearDown
46			*
47			* @since 3.1.0
48			*/
49
50			public function tearDown() : void
51			{
52			$this->dropDatabase();
53			}
54
55			/**
56			* testProcess
57			*
58			* @since 3.0.0
59			*
60			* @param array $postArray
61			* @param string $method
62			* @param string $expect
63			*
64			* @dataProvider providerAutoloader
65			*/
66
67			public function testProcess(array $postArray = [], string $method = null, string $expect = null) : void
68			{
69			/* setup */
70
71			$this->_request->set('post', $postArray);
72			if ($method)
			0 ignored issues – show Bug Best Practice introduced 2018-08-25 11:32 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `$method` of type `null\|string` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
73			{
74			$recoverController = $this
75			->getMockBuilder('Redaxscript\Controller\Recover')
76			->setConstructorArgs(
77			[
78			$this->_registry,
79			$this->_request,
80			$this->_language,
81			$this->_config
82			])
83			->setMethods(
84			[
85			$method
86			])
87			->getMock();
88
89			/* override */
90
91			$recoverController
92			->expects($this->any())
93			->method($method);
94			}
95			else
96			{
97			$recoverController = new Controller\Recover($this->_registry, $this->_request, $this->_language, $this->_config);
98			}
99
100			/* actual */
101
102			$actual = $recoverController->process();
			0 ignored issues – show Bug introduced 2019-04-22 21:27 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `process` does only exist in `Redaxscript\Controller\Recover`, but not in `PHPUnit\Framework\MockObject\MockObject`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
103
104			/* compare */
105
106			$this->assertEquals($expect, $actual);
107			}
108			}
109

redaxscript / redaxscript

Push — master ( 7de195...5f1ca1 )

tests/unit/Controller/RecoverTest.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Duplication Side-by-Side

Filter issues like