Issues in Cache.php - Fixed Issues - Inspection of "Modernize Singleton class" - redaxscript/redaxscript - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 7de195...5f1ca1 )

by Henry

created 2021-02-21 20:51 UTC

includes/Bootstrap/Cache.php (4 issues)

Labels

Documentation 4

Severity

Minor 4

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
namespace Redaxscript\Bootstrap;

use Redaxscript\Filter;
use function getenv;

/**
 * children class to boot the cache
 *
 * @since 3.1.0
 *
 * @package Redaxscript
 * @category Bootstrap
 * @author Henry Ruhs
 */

class Cache extends BootstrapAbstract
{
	/**
	 * automate run
	 *
	 * @since 3.1.0
	 */

	public function autorun() : void
	{
		$filterBoolean = new Filter\Boolean();
		$noCache = $filterBoolean->sanitize($this->_request->getQuery('no-cache')) || getenv('NO_CACHE');

		/* set the registry */

		$this->_registry->set('noAssetCache', false);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
		$this->_registry->set('noPageCache', false);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
		if ($this->_registry->get('loggedIn') === $this->_registry->get('token') || $noCache)
		{
			$this->_registry->set('noAssetCache', true);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
			$this->_registry->set('noPageCache', true);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
		}
	}
}


1		<?php
2		namespace Redaxscript\Bootstrap;
3
4		use Redaxscript\Filter;
5		use function getenv;
6
7		/**
8		* children class to boot the cache
9		*
10		* @since 3.1.0
11		*
12		* @package Redaxscript
13		* @category Bootstrap
14		* @author Henry Ruhs
15		*/
16
17		class Cache extends BootstrapAbstract
18		{
19		/**
20		* automate run
21		*
22		* @since 3.1.0
23		*/
24
25	3	public function autorun() : void
26		{
27	3	$filterBoolean = new Filter\Boolean();
28	3	$noCache = $filterBoolean->sanitize($this->_request->getQuery('no-cache')) \|\| getenv('NO_CACHE');
29
30		/* set the registry */
31
32	3	$this->_registry->set('noAssetCache', false);
		0 ignored issues – show Documentation introduced 2019-06-22 14:54 UTC by Report Bug Copy Issue Report Show Similar Issues like this `false` is of type `boolean`, but the function expects a `string\|array\|null`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
33	3	$this->_registry->set('noPageCache', false);
		0 ignored issues – show Documentation introduced 2018-09-08 16:06 UTC by Report Bug Copy Issue Report Show Similar Issues like this `false` is of type `boolean`, but the function expects a `string\|array\|null`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
34	3	if ($this->_registry->get('loggedIn') === $this->_registry->get('token') \|\| $noCache)
35		{
36	2	$this->_registry->set('noAssetCache', true);
		0 ignored issues – show Documentation introduced 2019-06-22 14:54 UTC by Report Bug Copy Issue Report Show Similar Issues like this `true` is of type `boolean`, but the function expects a `string\|array\|null`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
37	2	$this->_registry->set('noPageCache', true);
		0 ignored issues – show Documentation introduced 2018-09-08 16:06 UTC by Report Bug Copy Issue Report Show Similar Issues like this `true` is of type `boolean`, but the function expects a `string\|array\|null`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
38		}
39	3	}
40		}
41

redaxscript / redaxscript

Push — master ( 7de195...5f1ca1 )

includes/Bootstrap/Cache.php (4 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like