These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more
1 | <?php |
||
2 | namespace Redaxscript\Detector; |
||
3 | |||
4 | use Redaxscript\Filter; |
||
5 | use Redaxscript\Model; |
||
6 | |||
7 | /** |
||
8 | * children class to detect the current template |
||
9 | * |
||
10 | * @since 2.0.0 |
||
11 | * |
||
12 | * @package Redaxscript |
||
13 | * @category Detector |
||
14 | * @author Henry Ruhs |
||
15 | */ |
||
16 | |||
17 | class Template extends DetectorAbstract |
||
18 | { |
||
19 | /** |
||
20 | * automate run |
||
21 | * |
||
22 | * @since 2.1.0 |
||
23 | */ |
||
24 | |||
25 | 7 | public function autorun() : void |
|
26 | { |
||
27 | 7 | $settingModel = new Model\Setting(); |
|
28 | 7 | $contentModel = new Model\Content(); |
|
29 | 7 | $specialFilter = new Filter\Special(); |
|
30 | 7 | $dbStatus = $this->_registry->get('dbStatus'); |
|
31 | 7 | $lastTable = $this->_registry->get('lastTable'); |
|
32 | 7 | $lastId = $this->_registry->get('lastId'); |
|
33 | 7 | $content = $contentModel->getByTableAndId($lastTable, $lastId); |
|
0 ignored issues
–
show
It seems like
$lastId defined by $this->_registry->get('lastId') on line 32 can also be of type array or string ; however, Redaxscript\Model\Content::getByTableAndId() does only seem to accept null|integer , maybe add an additional type check?
If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /**
* @return array|string
*/
function returnsDifferentValues($x) {
if ($x) {
return 'foo';
}
return array();
}
$x = returnsDifferentValues($y);
if (is_array($x)) {
// $x is an array.
}
If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue.
Loading history...
|
|||
34 | 7 | $path = 'templates' . DIRECTORY_SEPARATOR . $this->_filePlaceholder . DIRECTORY_SEPARATOR . 'index.phtml'; |
|
35 | $setupArray = |
||
36 | [ |
||
37 | 7 | 'query' => $specialFilter->sanitize($this->_request->getQuery('t')), |
|
38 | 7 | 'session' => $this->_request->getSession('template'), |
|
39 | 7 | 'contents' => $content->template ?? null, |
|
40 | 7 | 'settings' => $dbStatus === 2 ? $settingModel->get('template') : null, |
|
41 | 7 | 'fallback' => 'default' |
|
42 | ]; |
||
43 | |||
44 | /* detect template */ |
||
45 | |||
46 | 7 | $this->_output = $this->_detect('template', $path, $setupArray); |
|
47 | 7 | } |
|
48 | } |
||
49 |
If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check:
If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue.