Issues in CommentTest.php - Fixed Issues - Inspection of "Transition to PHP8 testing part16" - redaxscript/redaxscript - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 4e146b...a6625c )

by Henry

created 2021-04-08 19:44 UTC

tests/unit/Controller/CommentTest.php (2 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
namespace Redaxscript\Tests\Controller;

use Redaxscript\Controller;
use Redaxscript\Db;
use Redaxscript\Tests\TestCaseAbstract;

/**
 * CommentTest
 *
 * @since 3.0.0
 *
 * @package Redaxscript
 * @category Tests
 * @author Henry Ruhs
 * @author Balázs Szilágyi
 *
 * @covers Redaxscript\Controller\Comment
 * @covers Redaxscript\Controller\ControllerAbstract
 *
 * @requires OS Linux
 */

class CommentTest extends TestCaseAbstract
{
	/**
	 * setUp
	 *
	 * @since 3.1.0
	 */

	public function setUp() : void
	{
		parent::setUp();
		$optionArray = $this->getOptionArray();
		$installer = $this->installerFactory();
		$installer->init();
		$installer->rawCreate();
		$installer->insertSettings($optionArray);
		Db::forTablePrefix('articles')
			->create()
			->set(
			[
				'title' => 'Article One',
				'alias' => 'article-one'

			])
			->save();
		$setting = $this->settingFactory();
		$setting->set('captcha', 1);
	}

	/**
	 * tearDown
	 *
	 * @since 3.1.0
	 */

	public function tearDown() : void
	{
		$this->dropDatabase();
	}

	/**
	 * testProcess
	 *
	 * @since 3.0.0
	 *
	 * @param array $postArray
	 * @param array $settingArray
	 * @param string $method
	 * @param string $expect
	 *
	 * @dataProvider providerAutoloader
	 */

	public function testProcess(array $postArray = [], array $settingArray = [], string $method = null, string $expect = null) : void
	{
		/* setup */

		$this->_request->set('post', $postArray);
		$setting = $this->settingFactory();
		$setting->set('notification', $settingArray['notification']);
		$setting->set('moderation', $settingArray['moderation']);
		if ($method)
		{
			$commentController = $this

				->getMockBuilder('Redaxscript\Controller\Comment')
				->setConstructorArgs(
				[
					$this->_registry,
					$this->_request,
					$this->_language,
					$this->_config
				])
				->setMethods(
				[
					$method
				])
				->getMock();

			/* override */

			$commentController
				->expects($this->any())
				->method($method);
		}
		else
		{
			$commentController = new Controller\Comment($this->_registry, $this->_request, $this->_language, $this->_config);
		}

		/* actual */

		$actual = $commentController->process();
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

		/* compare */

		$this->assertEquals($expect, $actual);
	}
}


1			<?php
2			namespace Redaxscript\Tests\Controller;
3
4			use Redaxscript\Controller;
5			use Redaxscript\Db;
6			use Redaxscript\Tests\TestCaseAbstract;
7
8			/**
9			* CommentTest
10			*
11			* @since 3.0.0
12			*
13			* @package Redaxscript
14			* @category Tests
15			* @author Henry Ruhs
16			* @author Balázs Szilágyi
17			*
18			* @covers Redaxscript\Controller\Comment
19			* @covers Redaxscript\Controller\ControllerAbstract
20			*
21			* @requires OS Linux
22			*/
23
24			class CommentTest extends TestCaseAbstract
25			{
26			/**
27			* setUp
28			*
29			* @since 3.1.0
30			*/
31
32			public function setUp() : void
33			{
34			parent::setUp();
35			$optionArray = $this->getOptionArray();
36			$installer = $this->installerFactory();
37			$installer->init();
38			$installer->rawCreate();
39			$installer->insertSettings($optionArray);
40			Db::forTablePrefix('articles')
41			->create()
42			->set(
43			[
44			'title' => 'Article One',
45			'alias' => 'article-one'
46
47			])
48			->save();
49			$setting = $this->settingFactory();
50			$setting->set('captcha', 1);
51			}
52
53			/**
54			* tearDown
55			*
56			* @since 3.1.0
57			*/
58
59			public function tearDown() : void
60			{
61			$this->dropDatabase();
62			}
63
64			/**
65			* testProcess
66			*
67			* @since 3.0.0
68			*
69			* @param array $postArray
70			* @param array $settingArray
71			* @param string $method
72			* @param string $expect
73			*
74			* @dataProvider providerAutoloader
75			*/
76
77			public function testProcess(array $postArray = [], array $settingArray = [], string $method = null, string $expect = null) : void
78			{
79			/* setup */
80
81			$this->_request->set('post', $postArray);
82			$setting = $this->settingFactory();
83			$setting->set('notification', $settingArray['notification']);
84			$setting->set('moderation', $settingArray['moderation']);
85			if ($method)
86			{
87			$commentController = $this
			0 ignored issues – show Deprecated Code introduced 2019-09-24 20:34 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `PHPUnit\Framework\MockOb...ckBuilder::setMethods()` has been deprecated with message: https://github.com/sebastianbergmann/phpunit/pull/3687 This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history...
88			->getMockBuilder('Redaxscript\Controller\Comment')
89			->setConstructorArgs(
90			[
91			$this->_registry,
92			$this->_request,
93			$this->_language,
94			$this->_config
95			])
96			->setMethods(
97			[
98			$method
99			])
100			->getMock();
101
102			/* override */
103
104			$commentController
105			->expects($this->any())
106			->method($method);
107			}
108			else
109			{
110			$commentController = new Controller\Comment($this->_registry, $this->_request, $this->_language, $this->_config);
111			}
112
113			/* actual */
114
115			$actual = $commentController->process();
			0 ignored issues – show Bug introduced 2019-04-22 21:27 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `process` does only exist in `Redaxscript\Controller\Comment`, but not in `PHPUnit\Framework\MockObject\MockObject`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
116
117			/* compare */
118
119			$this->assertEquals($expect, $actual);
120			}
121			}
122

redaxscript / redaxscript

Push — master ( 4e146b...a6625c )

tests/unit/Controller/CommentTest.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Duplication Side-by-Side

Filter issues like