Issues in CategoryForm.php - Fixed Issues - Inspection of "Filter n validator workover (#650)" - redaxscript/redaxscript - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 9458ed...7d322b )

by Henry

created 2020-05-16 11:14 UTC

includes/Admin/View/CategoryForm.php (1 issue)

Labels

Bug 1

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
namespace Redaxscript\Admin\View;

use Redaxscript\Admin;
use Redaxscript\Dater;
use Redaxscript\Html;
use Redaxscript\Module;
use Redaxscript\Validator;
use function count;
use function json_decode;

/**
 * children class to create the category form
 *
 * @since 3.0.0
 *
 * @package Redaxscript
 * @category View
 * @author Henry Ruhs
 */

class CategoryForm extends ViewAbstract
{
	/**
	 * render the view
	 *
	 * @since 3.0.0
	 *
	 * @param int $categoryId identifier of the category
	 *
	 * @return string
	 */

	public function render(int $categoryId = null) : string
	{
		$output = Module\Hook::trigger('adminCategoryFormStart');
		$helperOption = new Helper\Option($this->_language);
		$categoryModel = new Admin\Model\Category();
		$category = $categoryModel->getById($categoryId);
		$aliasValidator = new Validator\Alias();
		$dater = new Dater();
		$dater->init($category->date);

		/* html element */

		$titleElement = new Html\Element();
		$titleElement
			->init('h2',
			[
				'class' => 'rs-admin-title-content',
			])
			->text($category->title ? : $this->_language->get('category_new'));
		$formElement = new Admin\Html\Form($this->_registry, $this->_language);
		$formElement->init(
		[
			'form' =>
			[
				'class' => 'rs-admin-js-validate rs-admin-js-alias rs-admin-fn-tab rs-admin-component-tab rs-admin-form-default'
			],
			'button' =>
			[
				'create' =>
				[
					'name' => self::class
				],
				'save' =>
				[
					'name' => self::class
				]
			],
			'link' =>
			[
				'cancel' =>
				[
					'href' => $this->_registry->get('categoriesEdit') && $this->_registry->get('categoriesDelete') ? $this->_registry->get('parameterRoute') . 'admin/view/categories' : $this->_registry->get('parameterRoute') . 'admin'
				],
				'delete' =>
				[
					'href' => $category->id ? $this->_registry->get('parameterRoute') . 'admin/delete/categories/' . $category->id . '/' . $this->_registry->get('token') : null
				]
			]
		]);

		/* create the form */

		$formElement

			/* category */

			->radio(
			[
				'id' => self::class . '\Category',
				'class' => 'rs-admin-fn-status-tab',
				'name' => self::class . '\Tab',
				'checked' => 'checked'
			])
			->label($this->_language->get('category'),
			[
				'class' => 'rs-admin-fn-toggle-tab rs-admin-label-tab',
				'for' => self::class . '\Category'
			])
			->append('<ul class="rs-admin-fn-content-tab rs-admin-box-tab"><li>')
			->label($this->_language->get('title'),
			[
				'for' => 'title'
			])
			->text(
			[
				'autofocus' => 'autofocus',
				'class' => 'rs-admin-js-alias-input rs-admin-field-default rs-admin-field-text',
				'id' => 'title',
				'name' => 'title',
				'required' => 'required',
				'value' => $category->title
			])
			->append('</li><li>')
			->label($this->_language->get('alias'),
			[
				'for' => 'alias'
			])
			->text(
			[
				'class' => 'rs-admin-js-alias-output rs-admin-field-default rs-admin-field-text',
				'id' => 'alias',
				'name' => 'alias',
				'pattern' => $aliasValidator->getFormPattern(),
				'required' => 'required',
				'value' => $category->alias
			])
			->append('</li><li>')
			->label($this->_language->get('description'),
			[
				'for' => 'description'
			])
			->textarea(
			[
				'class' => 'rs-admin-js-resize rs-admin-field-textarea rs-admin-field-small',
				'id' => 'description',
				'name' => 'description',
				'rows' => 1,
				'value' => $category->description
			])
			->append('</li><li>')
			->label($this->_language->get('keywords'),
			[
				'for' => 'keywords'
			])
			->textarea(
			[
				'class' => 'rs-admin-js-resize rs-admin-field-textarea rs-admin-field-small',
				'id' => 'keywords',
				'name' => 'keywords',
				'rows' => 1,
				'value' => $category->keywords
			])
			->append('</li><li>')
			->label($this->_language->get('robots'),
			[
				'for' => 'robots'
			])
			->select($helperOption->getRobotArray(),
			[
				$category->robots
			],
			[
				'id' => 'robots',
				'name' => 'robots'
			])
			->append('</li></ul>')

			/* general */

			->radio(
			[
				'id' => self::class . '\General',
				'class' => 'rs-admin-fn-status-tab',
				'name' => self::class . '\Tab'
			])
			->label($this->_language->get('general'),
			[
				'class' => 'rs-admin-fn-toggle-tab rs-admin-label-tab',
				'for' => self::class . '\General'
			])
			->append('<ul class="rs-admin-fn-content-tab rs-admin-box-tab"><li>')
			->label($this->_language->get('language'),
			[
				'for' => 'language'
			])
			->select($helperOption->getLanguageArray(),
			[
				$category->language
			],
			[
				'id' => 'language',
				'name' => 'language'
			])
			->append('</li><li>')
			->label($this->_language->get('template'),
			[
				'for' => 'template'
			])
			->select($helperOption->getTemplateArray(),
			[
				$category->template
			],
			[
				'id' => 'template',
				'name' => 'template'
			])
			->append('</li><li>')
			->label($this->_language->get('category_sibling'),
			[
				'for' => 'sibling'
			])
			->select($helperOption->getSiblingForCategoryArray($category->id),
			[
				$category->sibling
			],
			[
				'id' => 'sibling',
				'name' => 'sibling'
			])
			->append('</li><li>')
			->label($this->_language->get('category_parent'),
			[
				'for' => 'parent'
			])
			->select($helperOption->getParentForCategoryArray($category->id),
			[
				$category->parent
			],
			[
				'id' => 'parent',
				'name' => 'parent'
			])
			->append('</li></ul>')

			/* customize */

			->radio(
			[
				'id' => self::class . '\Customize',
				'class' => 'rs-admin-fn-status-tab',
				'name' => self::class . '\Tab'
			])
			->label($this->_language->get('customize'),
			[
				'class' => 'rs-admin-fn-toggle-tab rs-admin-label-tab',
				'for' => self::class . '\Customize'
			])
			->append('<ul class="rs-admin-fn-content-tab rs-admin-box-tab"><li>')
			->label($this->_language->get('status'),

			[
				'for' => 'status'
			])
			->checkbox(!$category->id || $category->status ?
			[
				'id' => 'status',
				'class' => 'rs-admin-fn-status-switch',
				'name' => 'status',
				'checked' => 'checked'
			] :
			[
				'id' => 'status',
				'class' => 'rs-admin-fn-status-switch',
				'name' => 'status'
			])
			->label(null,
			[
				'class' => 'rs-admin-label-switch',
				'for' => 'status',
				'data-on' => $this->_language->get('publish'),
				'data-off' => $this->_language->get('unpublish')
			])
			->append('</li><li>')
			->label($this->_language->get('rank'),
			[
				'for' => 'rank'
			])
			->number(
			[
				'id' => 'rank',
				'name' => 'rank',
				'value' => $category->id ? $category->rank : $categoryModel->query()->max('rank') + 1
			])
			->append('</li>');
		if ($this->_registry->get('groupsEdit'))
		{
			$formElement
				->append('<li>')
				->label($this->_language->get('access'),
				[
					'for' => 'access'
				])
				->select($helperOption->getGroupArray(),
				(array)json_decode($category->access),
				[
					'id' => 'access',
					'name' => 'access[]',
					'multiple' => 'multiple',
					'size' => count($helperOption->getGroupArray())
				])
				->append('</li>');
		}
		$formElement
			->append('<li>')
			->label($this->_language->get('date'),
			[
				'for' => 'date'
			])
			->datetime(
			[
				'id' => 'date',
				'name' => 'date',
				'value' => $dater->formatField()
			])
			->append('</li></ul>')
			->hidden(
			[
				'name' => 'id',
				'value' => $category->id
			])
			->token()
			->append('<div class="rs-admin-wrapper-button">')
			->cancel();
		if ($category->id)
		{
			if ($this->_registry->get('categoriesDelete'))
			{
				$formElement->delete();
			}
			if ($this->_registry->get('categoriesEdit'))
			{
				$formElement->save();
			}
		}
		else if ($this->_registry->get('categoriesNew'))
		{
			$formElement->create();
		}
		$formElement->append('</div>');

		/* collect output */

		$output .= $titleElement . $formElement;
		$output .= Module\Hook::trigger('adminCategoryFormEnd');
		return $output;
	}
}


1		<?php
2		namespace Redaxscript\Admin\View;
3
4		use Redaxscript\Admin;
5		use Redaxscript\Dater;
6		use Redaxscript\Html;
7		use Redaxscript\Module;
8		use Redaxscript\Validator;
9		use function count;
10		use function json_decode;
11
12		/**
13		* children class to create the category form
14		*
15		* @since 3.0.0
16		*
17		* @package Redaxscript
18		* @category View
19		* @author Henry Ruhs
20		*/
21
22		class CategoryForm extends ViewAbstract
23		{
24		/**
25		* render the view
26		*
27		* @since 3.0.0
28		*
29		* @param int $categoryId identifier of the category
30		*
31		* @return string
32		*/
33
34	4	public function render(int $categoryId = null) : string
35		{
36	4	$output = Module\Hook::trigger('adminCategoryFormStart');
37	4	$helperOption = new Helper\Option($this->_language);
38	4	$categoryModel = new Admin\Model\Category();
39	4	$category = $categoryModel->getById($categoryId);
40	4	$aliasValidator = new Validator\Alias();
41	4	$dater = new Dater();
42	4	$dater->init($category->date);
43
44		/* html element */
45
46	4	$titleElement = new Html\Element();
47		$titleElement
48	4	->init('h2',
49		[
50	4	'class' => 'rs-admin-title-content',
51		])
52	4	->text($category->title ? : $this->_language->get('category_new'));
53	4	$formElement = new Admin\Html\Form($this->_registry, $this->_language);
54	4	$formElement->init(
55		[
56	4	'form' =>
57		[
58		'class' => 'rs-admin-js-validate rs-admin-js-alias rs-admin-fn-tab rs-admin-component-tab rs-admin-form-default'
59		],
60		'button' =>
61		[
62		'create' =>
63		[
64		'name' => self::class
65		],
66		'save' =>
67		[
68		'name' => self::class
69		]
70		],
71		'link' =>
72		[
73		'cancel' =>
74		[
75	4	'href' => $this->_registry->get('categoriesEdit') && $this->_registry->get('categoriesDelete') ? $this->_registry->get('parameterRoute') . 'admin/view/categories' : $this->_registry->get('parameterRoute') . 'admin'
76		],
77		'delete' =>
78		[
79	4	'href' => $category->id ? $this->_registry->get('parameterRoute') . 'admin/delete/categories/' . $category->id . '/' . $this->_registry->get('token') : null
80		]
81		]
82		]);
83
84		/* create the form */
85
86		$formElement
87
88		/* category */
89
90	4	->radio(
91		[
92	4	'id' => self::class . '\Category',
93		'class' => 'rs-admin-fn-status-tab',
94		'name' => self::class . '\Tab',
95		'checked' => 'checked'
96		])
97	4	->label($this->_language->get('category'),
98		[
99	4	'class' => 'rs-admin-fn-toggle-tab rs-admin-label-tab',
100		'for' => self::class . '\Category'
101		])
102	4	->append('<ul class="rs-admin-fn-content-tab rs-admin-box-tab"><li>')
103	4	->label($this->_language->get('title'),
104		[
105	4	'for' => 'title'
106		])
107	4	->text(
108		[
109	4	'autofocus' => 'autofocus',
110	4	'class' => 'rs-admin-js-alias-input rs-admin-field-default rs-admin-field-text',
111	4	'id' => 'title',
112	4	'name' => 'title',
113	4	'required' => 'required',
114	4	'value' => $category->title
115		])
116	4	->append('</li><li>')
117	4	->label($this->_language->get('alias'),
118		[
119	4	'for' => 'alias'
120		])
121	4	->text(
122		[
123	4	'class' => 'rs-admin-js-alias-output rs-admin-field-default rs-admin-field-text',
124	4	'id' => 'alias',
125	4	'name' => 'alias',
126	4	'pattern' => $aliasValidator->getFormPattern(),
127	4	'required' => 'required',
128	4	'value' => $category->alias
129		])
130	4	->append('</li><li>')
131	4	->label($this->_language->get('description'),
132		[
133	4	'for' => 'description'
134		])
135	4	->textarea(
136		[
137	4	'class' => 'rs-admin-js-resize rs-admin-field-textarea rs-admin-field-small',
138	4	'id' => 'description',
139	4	'name' => 'description',
140	4	'rows' => 1,
141	4	'value' => $category->description
142		])
143	4	->append('</li><li>')
144	4	->label($this->_language->get('keywords'),
145		[
146	4	'for' => 'keywords'
147		])
148	4	->textarea(
149		[
150	4	'class' => 'rs-admin-js-resize rs-admin-field-textarea rs-admin-field-small',
151	4	'id' => 'keywords',
152	4	'name' => 'keywords',
153	4	'rows' => 1,
154	4	'value' => $category->keywords
155		])
156	4	->append('</li><li>')
157	4	->label($this->_language->get('robots'),
158		[
159	4	'for' => 'robots'
160		])
161	4	->select($helperOption->getRobotArray(),
162		[
163	4	$category->robots
164		],
165		[
166	4	'id' => 'robots',
167		'name' => 'robots'
168		])
169	4	->append('</li></ul>')
170
171		/* general */
172
173	4	->radio(
174		[
175	4	'id' => self::class . '\General',
176		'class' => 'rs-admin-fn-status-tab',
177		'name' => self::class . '\Tab'
178		])
179	4	->label($this->_language->get('general'),
180		[
181	4	'class' => 'rs-admin-fn-toggle-tab rs-admin-label-tab',
182		'for' => self::class . '\General'
183		])
184	4	->append('<ul class="rs-admin-fn-content-tab rs-admin-box-tab"><li>')
185	4	->label($this->_language->get('language'),
186		[
187	4	'for' => 'language'
188		])
189	4	->select($helperOption->getLanguageArray(),
190		[
191	4	$category->language
192		],
193		[
194	4	'id' => 'language',
195		'name' => 'language'
196		])
197	4	->append('</li><li>')
198	4	->label($this->_language->get('template'),
199		[
200	4	'for' => 'template'
201		])
202	4	->select($helperOption->getTemplateArray(),
203		[
204	4	$category->template
205		],
206		[
207	4	'id' => 'template',
208		'name' => 'template'
209		])
210	4	->append('</li><li>')
211	4	->label($this->_language->get('category_sibling'),
212		[
213	4	'for' => 'sibling'
214		])
215	4	->select($helperOption->getSiblingForCategoryArray($category->id),
216		[
217	4	$category->sibling
218		],
219		[
220	4	'id' => 'sibling',
221		'name' => 'sibling'
222		])
223	4	->append('</li><li>')
224	4	->label($this->_language->get('category_parent'),
225		[
226	4	'for' => 'parent'
227		])
228	4	->select($helperOption->getParentForCategoryArray($category->id),
229		[
230	4	$category->parent
231		],
232		[
233	4	'id' => 'parent',
234		'name' => 'parent'
235		])
236	4	->append('</li></ul>')
237
238		/* customize */
239
240	4	->radio(
241		[
242	4	'id' => self::class . '\Customize',
243		'class' => 'rs-admin-fn-status-tab',
244		'name' => self::class . '\Tab'
245		])
246	4	->label($this->_language->get('customize'),
247		[
248	4	'class' => 'rs-admin-fn-toggle-tab rs-admin-label-tab',
249		'for' => self::class . '\Customize'
250		])
251	4	->append('<ul class="rs-admin-fn-content-tab rs-admin-box-tab"><li>')
252	4	->label($this->_language->get('status'),
		0 ignored issues – show Bug introduced 2018-09-08 16:06 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$this->_language->get('status')` targeting `Redaxscript\Language::get()` can also be of type `array`; however, `Redaxscript\Html\Form::label()` does only seem to accept `null\|string`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
253		[
254	4	'for' => 'status'
255		])
256	4	->checkbox(!$category->id \|\| $category->status ?
257		[
258	4	'id' => 'status',
259		'class' => 'rs-admin-fn-status-switch',
260		'name' => 'status',
261		'checked' => 'checked'
262		] :
263		[
264	4	'id' => 'status',
265		'class' => 'rs-admin-fn-status-switch',
266		'name' => 'status'
267		])
268	4	->label(null,
269		[
270	4	'class' => 'rs-admin-label-switch',
271	4	'for' => 'status',
272	4	'data-on' => $this->_language->get('publish'),
273	4	'data-off' => $this->_language->get('unpublish')
274		])
275	4	->append('</li><li>')
276	4	->label($this->_language->get('rank'),
277		[
278	4	'for' => 'rank'
279		])
280	4	->number(
281		[
282	4	'id' => 'rank',
283	4	'name' => 'rank',
284	4	'value' => $category->id ? $category->rank : $categoryModel->query()->max('rank') + 1
285		])
286	4	->append('</li>');
287	4	if ($this->_registry->get('groupsEdit'))
288		{
289		$formElement
290	4	->append('<li>')
291	4	->label($this->_language->get('access'),
292		[
293	4	'for' => 'access'
294		])
295	4	->select($helperOption->getGroupArray(),
296	4	(array)json_decode($category->access),
297		[
298	4	'id' => 'access',
299	4	'name' => 'access[]',
300	4	'multiple' => 'multiple',
301	4	'size' => count($helperOption->getGroupArray())
302		])
303	4	->append('</li>');
304		}
305		$formElement
306	4	->append('<li>')
307	4	->label($this->_language->get('date'),
308		[
309	4	'for' => 'date'
310		])
311	4	->datetime(
312		[
313	4	'id' => 'date',
314	4	'name' => 'date',
315	4	'value' => $dater->formatField()
316		])
317	4	->append('</li></ul>')
318	4	->hidden(
319		[
320	4	'name' => 'id',
321	4	'value' => $category->id
322		])
323	4	->token()
324	4	->append('<div class="rs-admin-wrapper-button">')
325	4	->cancel();
326	4	if ($category->id)
327		{
328	2	if ($this->_registry->get('categoriesDelete'))
329		{
330	1	$formElement->delete();
331		}
332	2	if ($this->_registry->get('categoriesEdit'))
333		{
334	2	$formElement->save();
335		}
336		}
337	2	else if ($this->_registry->get('categoriesNew'))
338		{
339	1	$formElement->create();
340		}
341	4	$formElement->append('</div>');
342
343		/* collect output */
344
345	4	$output .= $titleElement . $formElement;
346	4	$output .= Module\Hook::trigger('adminCategoryFormEnd');
347	4	return $output;
348		}
349		}
350

redaxscript / redaxscript

Push — master ( 9458ed...7d322b )

includes/Admin/View/CategoryForm.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like