redaxscript / redaxscript

includes/Template/Helper/Canonical.php

<?php
namespace Redaxscript\Template\Helper;

use Redaxscript\Db;
use Redaxscript\Model;
use function is_numeric;
use function is_string;

/**
 * helper class to provide a canonical helper
 *
 * @since 3.0.0
 *
 * @package Redaxscript
 * @category Template
 * @author Henry Ruhs
 */

class Canonical extends HelperAbstract
{
	/**
	 * process
	 *
	 * @since 3.0.0
	 *
	 * @return string|null
	 */

	public function process() : ?string
	{
		$contentModel = new Model\Content();
		$lastTable = $this->_registry->get('lastTable');
		$lastId = $this->_registry->get('lastId');
		$parameterRoute = $this->_registry->get('parameterRoute');
		$root = $this->_registry->get('root');
		$route = null;

		/* find route */

		if ($lastTable === 'categories')
		{
			$articles = Db::forTablePrefix('articles')->where('category', $lastId);
			$articlesTotal = $articles->count();
			if ($articlesTotal === 1)
			{
				$lastTable = 'articles';
				$lastId = $articles->findOne()->id;
			}
		}
		if (is_string($lastTable) && is_numeric($lastId))
		{
			$route = $contentModel->getRouteByTableAndId($lastTable, $lastId);
		}

		/* handle route */

		if ($route)

The expression $route of type string|null is loosely compared to true; this is ambiguous if the string can be empty. You might want to explicitly use !== null instead.

		{
			return $root . '/' . $parameterRoute . $route;
		}
		return $root;
	}
}