Issues in Category.php - All Issues - Inspection of "Develop (#598)" - redaxscript/redaxscript - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 0ea243...da58d4 )

by Henry

created 2019-05-29 16:08 UTC

includes/Navigation/Category.php (1 issue)

Showing only issues like (Show All)

Check for loose comparison of strings.

Best Practice Bug Major

redaxmedia 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
namespace Redaxscript\Navigation;

use Redaxscript\Html;
use Redaxscript\Model;
use Redaxscript\Module;
use Redaxscript\Validator;

/**
 * children class to create the category navigation
 *
 * @since 3.3.0
 *
 * @package Redaxscript
 * @category Navigation
 * @author Henry Ruhs
 */

class Category extends NavigationAbstract
{
	/**
	 * options of the navigation
	 *
	 * @var array
	 */

	protected $_optionArray =
	[
		'className' =>
		[
			'list' => 'rs-list-categories',
			'children' => 'rs-list-children',
			'active' => 'rs-item-active'
		],
		'orderColumn' => 'rank'
	];

	/**
	 * render the view
	 *
	 * @since 3.3.0
	 *
	 * @return string
	 */

	public function render() : string
	{
		$output = Module\Hook::trigger('navigationCategoryStart');
		$categoryModel = new Model\Category();

		/* query categories */

		$categories = $categoryModel
			->query()
			->whereLanguageIs($this->_registry->get('language'))
			->whereNull('parent')
			->where('status', 1)
			->orderBySetting($this->_optionArray['orderColumn'])
			->limit($this->_optionArray['limit'])
			->findMany();

		/* collect output */

		$output .= $this->_renderList($categories);
		$output .= Module\Hook::trigger('navigationCategoryEnd');
		return $output;
	}

	/**
	 * render the list
	 *
	 * @since 3.3.0
	 *
	 * @param object $categories
	 * @param int $level
	 *
	 * @return string|null
	 */

	protected function _renderList(object $categories = null, int $level = 0) : ?string
	{
		$output = null;
		$outputItem = null;
		$categoryModel = new Model\Category();
		$accessValidator = new Validator\Access();

		/* html element */

		$element = new Html\Element();
		$listElement = $element
			->copy()
			->init('ul',
			[
				'class' => $level === 0 ? $this->_optionArray['className']['list'] : $this->_optionArray['className']['children']
			]);
		$itemElement = $element->copy()->init('li');
		$linkElement = $element->copy()->init('a');
		$textElement = $element->copy()->init('span');

		/* collect item output */

		foreach ($categories as $value)
		{
			if ($accessValidator->validate($value->access, $this->_registry->get('myGroups')))
			{
				$outputItem .= $itemElement
					->copy()
					->addClass($this->_registry->get('firstParameter') === $value->alias ? $this->_optionArray['className']['active'] : null)
					->html($linkElement
						->copy()
						->attr(
						[
							'href' => $this->_registry->get('parameterRoute') . $categoryModel->getRouteById($value->id)
						])
						->text($value->title)
					)
					->append(
						$this->_renderList($categoryModel
							->query()
							->whereLanguageIs($this->_registry->get('language'))
							->where(
							[
								'parent' => $value->id,
								'status' => 1
							])
							->orderBySetting($this->_optionArray['orderColumn'])
							->limit($this->_optionArray['limit'])
							->findMany(), ++$level
						)
					);
			}
		}

		/* collect output */

		if ($outputItem)
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
		{
			$output .= $listElement->html($outputItem);
		}
		else if ($level === 0)
		{
			$output .= $listElement->html($itemElement->html($textElement->text($this->_language->get('category_no'))));
		}
		return $output;
	}
}


1		<?php
2		namespace Redaxscript\Navigation;
3
4		use Redaxscript\Html;
5		use Redaxscript\Model;
6		use Redaxscript\Module;
7		use Redaxscript\Validator;
8
9		/**
10		* children class to create the category navigation
11		*
12		* @since 3.3.0
13		*
14		* @package Redaxscript
15		* @category Navigation
16		* @author Henry Ruhs
17		*/
18
19		class Category extends NavigationAbstract
20		{
21		/**
22		* options of the navigation
23		*
24		* @var array
25		*/
26
27		protected $_optionArray =
28		[
29		'className' =>
30		[
31		'list' => 'rs-list-categories',
32		'children' => 'rs-list-children',
33		'active' => 'rs-item-active'
34		],
35		'orderColumn' => 'rank'
36		];
37
38		/**
39		* render the view
40		*
41		* @since 3.3.0
42		*
43		* @return string
44		*/
45
46	3	public function render() : string
47		{
48	3	$output = Module\Hook::trigger('navigationCategoryStart');
49	3	$categoryModel = new Model\Category();
50
51		/* query categories */
52
53		$categories = $categoryModel
54	3	->query()
55	3	->whereLanguageIs($this->_registry->get('language'))
56	3	->whereNull('parent')
57	3	->where('status', 1)
58	3	->orderBySetting($this->_optionArray['orderColumn'])
59	3	->limit($this->_optionArray['limit'])
60	3	->findMany();
61
62		/* collect output */
63
64	3	$output .= $this->_renderList($categories);
65	3	$output .= Module\Hook::trigger('navigationCategoryEnd');
66	3	return $output;
67		}
68
69		/**
70		* render the list
71		*
72		* @since 3.3.0
73		*
74		* @param object $categories
75		* @param int $level
76		*
77		* @return string\|null
78		*/
79
80	3	protected function _renderList(object $categories = null, int $level = 0) : ?string
81		{
82	3	$output = null;
83	3	$outputItem = null;
84	3	$categoryModel = new Model\Category();
85	3	$accessValidator = new Validator\Access();
86
87		/* html element */
88
89	3	$element = new Html\Element();
90		$listElement = $element
91	3	->copy()
92	3	->init('ul',
93		[
94	3	'class' => $level === 0 ? $this->_optionArray['className']['list'] : $this->_optionArray['className']['children']
95		]);
96	3	$itemElement = $element->copy()->init('li');
97	3	$linkElement = $element->copy()->init('a');
98	3	$textElement = $element->copy()->init('span');
99
100		/* collect item output */
101
102	3	foreach ($categories as $value)
103		{
104	3	if ($accessValidator->validate($value->access, $this->_registry->get('myGroups')))
105		{
106		$outputItem .= $itemElement
107	3	->copy()
108	3	->addClass($this->_registry->get('firstParameter') === $value->alias ? $this->_optionArray['className']['active'] : null)
109	3	->html($linkElement
110	3	->copy()
111	3	->attr(
112		[
113	3	'href' => $this->_registry->get('parameterRoute') . $categoryModel->getRouteById($value->id)
114		])
115	3	->text($value->title)
116		)
117	3	->append(
118	3	$this->_renderList($categoryModel
119	3	->query()
120	3	->whereLanguageIs($this->_registry->get('language'))
121	3	->where(
122		[
123	3	'parent' => $value->id,
124	3	'status' => 1
125		])
126	3	->orderBySetting($this->_optionArray['orderColumn'])
127	3	->limit($this->_optionArray['limit'])
128	3	->findMany(), ++$level
129		)
130		);
131		}
132		}
133
134		/* collect output */
135
136	3	if ($outputItem)
		0 ignored issues – show Bug Best Practice introduced 2018-05-10 09:59 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `$outputItem` of type `string\|null` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
137		{
138	3	$output .= $listElement->html($outputItem);
139		}
140	3	else if ($level === 0)
141		{
142		$output .= $listElement->html($itemElement->html($textElement->text($this->_language->get('category_no'))));
143		}
144	3	return $output;
145		}
146		}
147

redaxscript / redaxscript

Push — master ( 0ea243...da58d4 )

includes/Navigation/Category.php (1 issue)

Showing only issues like (Show All)

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like