Issues in ExtraTable.php - All Issues - Inspection of "Develop (#598)" - redaxscript/redaxscript - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 0ea243...da58d4 )

by Henry

created 2019-05-29 16:08 UTC

includes/Admin/View/ExtraTable.php (3 issues)

Showing only issues like (Show All)

Check for mismatching type of a variable.

Bug Minor

Henry Ruhs 3

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
namespace Redaxscript\Admin\View;

use Redaxscript\Admin;
use Redaxscript\Html;
use Redaxscript\Module;
use function count;

/**
 * children class to create the admin extra table
 *
 * @since 4.0.0
 *
 * @package Redaxscript
 * @category View
 * @author Henry Ruhs
 */

class ExtraTable extends ViewAbstract
{
	/**
	 * render the view
	 *
	 * @since 4.0.0
	 *
	 * @return string
	 */

	public function render() : string
	{
		$output = Module\Hook::trigger('adminExtraTableStart');
		$parameterRoute = $this->_registry->get('parameterRoute');
		$extrasNew = $this->_registry->get('extrasNew');

		/* html element */

		$element = new Html\Element();
		$titleElement = $element
			->copy()
			->init('h2',
			[
				'class' => 'rs-admin-title-content',
			])
			->text($this->_language->get('extras'));

		$linkElement = $element
			->copy()
			->init('a',
			[
				'class' => 'rs-admin-button-default rs-admin-button-create',
				'href' => $parameterRoute . 'admin/new/extras'
			])
			->text($this->_language->get('extra_new'));


		/* collect output */

		$output .= $titleElement;
		if ($extrasNew)
		{
			$output .= $linkElement;
		}
		$output .= $this->_renderTable();
		$output .= Module\Hook::trigger('adminExtraTableEnd');
		return $output;
	}

	/**
	 * render the table
	 *
	 * @since 4.0.0
	 *
	 * @return string|null
	 */

	protected function _renderTable() : ?string
	{
		$output = null;
		$outputHead = null;
		$outputBody = null;
		$outputFoot = null;
		$tableArray =
		[
			'title' => $this->_language->get('title'),
			'alias' => $this->_language->get('alias'),
			'rank' => $this->_language->get('rank')
		];
		$adminControl = new Helper\Control($this->_registry, $this->_language);
		$adminControl->init();
		$extraModel = new Admin\Model\Extra();
		$extras = $extraModel->getAllByOrder('rank');
		$extrasTotal = $extras->count();

		/* html element */

		$element = new Html\Element();
		$wrapperElement = $element
			->copy()
			->init('div',
			[
				'class' => 'rs-admin-wrapper-table'
			]);
		$tableElement = $element
			->copy()
			->init('table',
			[
				'class' => 'rs-admin-js-sort rs-admin-table-default'
			]);
		$theadElement = $element->copy()->init('thead');
		$tbodyElement = $element->copy()->init('tbody');
		$tfootElement = $element->copy()->init('tfoot');
		$trElement = $element->copy()->init('tr');
		$thElement = $element->copy()->init('th');
		$tdElement = $element->copy()->init('td');

		/* process table */

		foreach ($tableArray as $key => $value)
		{
			$outputHead .= $thElement->copy()->text($value);
			$outputFoot .= $tdElement->copy()->text($value);
		}

		/* process extras */

		if ($extrasTotal)
		{
			foreach ($extras as $key => $value)
			{
				$outputBody .= $trElement
					->copy()
					->attr('id', 'row-' . $value->id)
					->addClass(!$value->status ? 'rs-admin-is-disabled' : null)
					->html(
						$tdElement->copy()->html($value->title . $adminControl->render('extras', $value->id, $value->alias, $value->status)) .
						$tdElement->copy()->text($value->alias) .
						$tdElement
							->copy()
							->addClass('rs-admin-js-move rs-admin-col-move')
							->addClass($extrasTotal > 1 ? 'rs-admin-is-active' : null)
							->text($value->rank)
				);
			}
		}
		else
		{
			$outputBody .= $trElement
				->copy()
				->html(
					$tdElement
						->copy()
						->attr('colspan', count($tableArray))
						->text($this->_language->get('extra_no'))

				);
		}

		/* collect output */

		$outputHead = $theadElement->html(
			$trElement->html($outputHead)
		);
		$outputBody = $tbodyElement->html($outputBody);
		$outputFoot = $tfootElement->html(
			$trElement->html($outputFoot)
		);
		$output .= $wrapperElement->copy()->html(
			$tableElement->html($outputHead . $outputBody . $outputFoot)
		);
		return $output;
	}
}


1		<?php
2		namespace Redaxscript\Admin\View;
3
4		use Redaxscript\Admin;
5		use Redaxscript\Html;
6		use Redaxscript\Module;
7		use function count;
8
9		/**
10		* children class to create the admin extra table
11		*
12		* @since 4.0.0
13		*
14		* @package Redaxscript
15		* @category View
16		* @author Henry Ruhs
17		*/
18
19		class ExtraTable extends ViewAbstract
20		{
21		/**
22		* render the view
23		*
24		* @since 4.0.0
25		*
26		* @return string
27		*/
28
29	2	public function render() : string
30		{
31	2	$output = Module\Hook::trigger('adminExtraTableStart');
32	2	$parameterRoute = $this->_registry->get('parameterRoute');
33	2	$extrasNew = $this->_registry->get('extrasNew');
34
35		/* html element */
36
37	2	$element = new Html\Element();
38		$titleElement = $element
39	2	->copy()
40	2	->init('h2',
41		[
42	2	'class' => 'rs-admin-title-content',
43		])
44	2	->text($this->_language->get('extras'));
		0 ignored issues – show Bug introduced 2018-10-17 01:12 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$this->_language->get('extras')` targeting `Redaxscript\Language::get()` can also be of type `array`; however, `Redaxscript\Html\Element::text()` does only seem to accept `string\|integer\|null`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
45		$linkElement = $element
46	2	->copy()
47	2	->init('a',
48		[
49	2	'class' => 'rs-admin-button-default rs-admin-button-create',
50	2	'href' => $parameterRoute . 'admin/new/extras'
51		])
52	2	->text($this->_language->get('extra_new'));
		0 ignored issues – show Bug introduced 2018-10-17 01:12 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$this->_language->get('extra_new')` targeting `Redaxscript\Language::get()` can also be of type `array`; however, `Redaxscript\Html\Element::text()` does only seem to accept `string\|integer\|null`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
53
54		/* collect output */
55
56	2	$output .= $titleElement;
57	2	if ($extrasNew)
58		{
59	1	$output .= $linkElement;
60		}
61	2	$output .= $this->_renderTable();
62	2	$output .= Module\Hook::trigger('adminExtraTableEnd');
63	2	return $output;
64		}
65
66		/**
67		* render the table
68		*
69		* @since 4.0.0
70		*
71		* @return string\|null
72		*/
73
74	2	protected function _renderTable() : ?string
75		{
76	2	$output = null;
77	2	$outputHead = null;
78	2	$outputBody = null;
79	2	$outputFoot = null;
80		$tableArray =
81		[
82	2	'title' => $this->_language->get('title'),
83	2	'alias' => $this->_language->get('alias'),
84	2	'rank' => $this->_language->get('rank')
85		];
86	2	$adminControl = new Helper\Control($this->_registry, $this->_language);
87	2	$adminControl->init();
88	2	$extraModel = new Admin\Model\Extra();
89	2	$extras = $extraModel->getAllByOrder('rank');
90	2	$extrasTotal = $extras->count();
91
92		/* html element */
93
94	2	$element = new Html\Element();
95		$wrapperElement = $element
96	2	->copy()
97	2	->init('div',
98		[
99	2	'class' => 'rs-admin-wrapper-table'
100		]);
101		$tableElement = $element
102	2	->copy()
103	2	->init('table',
104		[
105	2	'class' => 'rs-admin-js-sort rs-admin-table-default'
106		]);
107	2	$theadElement = $element->copy()->init('thead');
108	2	$tbodyElement = $element->copy()->init('tbody');
109	2	$tfootElement = $element->copy()->init('tfoot');
110	2	$trElement = $element->copy()->init('tr');
111	2	$thElement = $element->copy()->init('th');
112	2	$tdElement = $element->copy()->init('td');
113
114		/* process table */
115
116	2	foreach ($tableArray as $key => $value)
117		{
118	2	$outputHead .= $thElement->copy()->text($value);
119	2	$outputFoot .= $tdElement->copy()->text($value);
120		}
121
122		/* process extras */
123
124	2	if ($extrasTotal)
125		{
126	2	foreach ($extras as $key => $value)
127		{
128		$outputBody .= $trElement
129	2	->copy()
130	2	->attr('id', 'row-' . $value->id)
131	2	->addClass(!$value->status ? 'rs-admin-is-disabled' : null)
132	2	->html(
133	2	$tdElement->copy()->html($value->title . $adminControl->render('extras', $value->id, $value->alias, $value->status)) .
134	2	$tdElement->copy()->text($value->alias) .
135		$tdElement
136	2	->copy()
137	2	->addClass('rs-admin-js-move rs-admin-col-move')
138	2	->addClass($extrasTotal > 1 ? 'rs-admin-is-active' : null)
139	2	->text($value->rank)
140		);
141		}
142		}
143		else
144		{
145		$outputBody .= $trElement
146		->copy()
147		->html(
148		$tdElement
149		->copy()
150		->attr('colspan', count($tableArray))
151		->text($this->_language->get('extra_no'))
		0 ignored issues – show Bug introduced 2018-10-17 01:12 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$this->_language->get('extra_no')` targeting `Redaxscript\Language::get()` can also be of type `array`; however, `Redaxscript\Html\Element::text()` does only seem to accept `string\|integer\|null`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
152		);
153		}
154
155		/* collect output */
156
157	2	$outputHead = $theadElement->html(
158	2	$trElement->html($outputHead)
159		);
160	2	$outputBody = $tbodyElement->html($outputBody);
161	2	$outputFoot = $tfootElement->html(
162	2	$trElement->html($outputFoot)
163		);
164	2	$output .= $wrapperElement->copy()->html(
165	2	$tableElement->html($outputHead . $outputBody . $outputFoot)
166		);
167	2	return $output;
168		}
169		}
170

redaxscript / redaxscript

Push — master ( 0ea243...da58d4 )

includes/Admin/View/ExtraTable.php (3 issues)

Showing only issues like (Show All)

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like