Issues in RegistryTest.php - Fixed Issues - Inspection of "Cosmetics for dialog" - redaxscript/redaxscript - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 8809d0...5c8ee8 )

by Henry

created 2018-12-15 23:35 UTC

tests/phpunit/RegistryTest.php (1 issue)

Labels

Bug 1

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
namespace Redaxscript\Tests;

/**
 * RegistryTest
 *
 * @since 2.1.0
 *
 * @package Redaxscript
 * @category Tests
 * @author Henry Ruhs
 * @author Gary Aylward
 *
 * @covers Redaxscript\Registry
 */

class RegistryTest extends TestCaseAbstract
{
	/**
	 * testInit
	 *
	 * @since 3.0.0
	 */

	public function testInit()
	{
		/* setup */

		$this->_registry->init();

		/* actual */

		$actual = $this->_registry;

		/* compare */

		$this->assertInstanceOf('Redaxscript\Registry', $actual);
	}

	/**
	 * testGetAndSet
	 *
	 * @since 2.1.0
	 */

	public function testGetAndSet()
	{
		/* setup */

		$this->_registry->set('testKey', 'testValue');

		/* actual */

		$actual = $this->_registry->get('testKey');

		/* compare */

		$this->assertEquals('testValue', $actual);
	}

	/**
	 * testGetAll
	 *
	 * @since 2.2.0
	 */

	public function testGetAll()
	{
		/* setup */

		$this->_registry->set('testAll', 'testAll');

		/* actual */

		$actualArray = $this->_registry->get();

		/* compare */

		$this->assertArrayHasKey('testAll', $actualArray);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
	}

	/**
	 * testGetInvalid
	 *
	 * @since 2.1.0
	 */

	public function testGetInvalid()
	{
		/* actual */

		$actual = $this->_registry->get('invalidKey');

		/* compare */

		$this->assertNull($actual);
	}
}


1			<?php
2			namespace Redaxscript\Tests;
3
4			/**
5			* RegistryTest
6			*
7			* @since 2.1.0
8			*
9			* @package Redaxscript
10			* @category Tests
11			* @author Henry Ruhs
12			* @author Gary Aylward
13			*
14			* @covers Redaxscript\Registry
15			*/
16
17			class RegistryTest extends TestCaseAbstract
18			{
19			/**
20			* testInit
21			*
22			* @since 3.0.0
23			*/
24
25			public function testInit()
26			{
27			/* setup */
28
29			$this->_registry->init();
30
31			/* actual */
32
33			$actual = $this->_registry;
34
35			/* compare */
36
37			$this->assertInstanceOf('Redaxscript\Registry', $actual);
38			}
39
40			/**
41			* testGetAndSet
42			*
43			* @since 2.1.0
44			*/
45
46			public function testGetAndSet()
47			{
48			/* setup */
49
50			$this->_registry->set('testKey', 'testValue');
51
52			/* actual */
53
54			$actual = $this->_registry->get('testKey');
55
56			/* compare */
57
58			$this->assertEquals('testValue', $actual);
59			}
60
61			/**
62			* testGetAll
63			*
64			* @since 2.2.0
65			*/
66
67			public function testGetAll()
68			{
69			/* setup */
70
71			$this->_registry->set('testAll', 'testAll');
72
73			/* actual */
74
75			$actualArray = $this->_registry->get();
76
77			/* compare */
78
79			$this->assertArrayHasKey('testAll', $actualArray);
			0 ignored issues – show Bug introduced 2018-09-08 16:06 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$actualArray` defined by `$this->_registry->get()` on line `75` can also be of type `null` or `string`; however, `PHPUnit\Framework\Assert::assertArrayHasKey()` does only seem to accept `array\|object<ArrayAccess>`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
80			}
81
82			/**
83			* testGetInvalid
84			*
85			* @since 2.1.0
86			*/
87
88			public function testGetInvalid()
89			{
90			/* actual */
91
92			$actual = $this->_registry->get('invalidKey');
93
94			/* compare */
95
96			$this->assertNull($actual);
97			}
98			}
99

redaxscript / redaxscript

Push — master ( 8809d0...5c8ee8 )

tests/phpunit/RegistryTest.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like