Issues in ArticleTest.php - All Issues - Inspection of "Remove PHP 7.4 testing because Idiorm throws depre..." - redaxscript/redaxscript - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( d0c173...e44a53 )

by Henry

created 2019-07-25 21:55 UTC

tests/unit/Model/ArticleTest.php (1 issue)

Labels

Bug 1

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
namespace Redaxscript\Tests\Model;

use Redaxscript\Db;
use Redaxscript\Model;
use Redaxscript\Tests\TestCaseAbstract;

/**
 * ArticleTest
 *
 * @since 4.0.0
 *
 * @package Redaxscript
 * @category Tests
 * @author Henry Ruhs
 *
 * @covers Redaxscript\Model\Article
 */

class ArticleTest extends TestCaseAbstract
{
	/**
	 * setUp
	 *
	 * @since 4.0.0
	 */

	public function setUp() : void
	{
		parent::setUp();
		$optionArray =
		[
			'adminName' => 'Test',
			'adminUser' => 'test',
			'adminPassword' => 'test',
			'adminEmail' => '[email protected]'
		];
		$installer = $this->installerFactory();
		$installer->init();
		$installer->rawCreate();
		$installer->insertSettings($optionArray);
		$categoryOne = Db::forTablePrefix('categories')->create();
		$categoryOne
			->set(
			[
				'title' => 'Category One',
				'alias' => 'category-one'
			])
			->save();
		$categoryTwo = Db::forTablePrefix('categories')->create();
		$categoryTwo
			->set(
			[
				'title' => 'Category Two',
				'alias' => 'category-two',
				'parent' => $categoryOne->id
			])
			->save();
		$categoryTwoSibling = Db::forTablePrefix('categories')->create();
		$categoryTwoSibling
			->set(
			[
				'title' => 'Category Two Sibling',
				'alias' => 'category-two-sibling',
				'sibling' => $categoryTwo->id
			])
			->save();
		Db::forTablePrefix('articles')
			->create()
			->set(
			[
				'title' => 'Article One',
				'alias' => 'article-one',
				'category' => $categoryOne->id
			])
			->save();
		Db::forTablePrefix('articles')
			->create()
			->set(
			[
				'title' => 'Article Two',
				'alias' => 'article-two',
				'category' => $categoryTwo->id
			])
			->save();
		$articleThree = Db::forTablePrefix('articles')
			->create()
			->set(
			[
				'title' => 'Article Three',
				'alias' => 'article-three',
				'language' => 'en',
				'category' => $categoryTwo->id
			])
			->save();
		Db::forTablePrefix('articles')
			->create()
			->set(
				[
					'title' => 'Article Three Sibling',
					'alias' => 'article-three-sibling',
					'language' => 'de',
					'sibling' => $articleThree->id,
					'category' => $categoryTwoSibling->id
				])
			->save();
		Db::forTablePrefix('articles')
			->create()
			->set(
			[
				'title' => 'Article Four',
				'alias' => 'article-four'
			])
			->save();
	}

	/**
	 * tearDown
	 *
	 * @since 4.0.0
	 */

	public function tearDown() : void
	{
		$this->dropDatabase();
	}

	/**
	 * testGetByAlias
	 *
	 * @since 4.0.0
	 *
	 * @param string $articleAlias
	 * @param int $expect
	 *
	 * @dataProvider providerAutoloader
	 */

	public function testGetByAlias(string $articleAlias = null, int $expect = null) : void
	{
		/* setup */

		$articleModel = new Model\Article();

		/* actual */

		$actual = $articleModel->getByAlias($articleAlias)->id;

		/* compare */

		$this->assertEquals($expect, $actual);
	}

	/**
	 *
	 * testCountByCategoryAndLanguage
	 *
	 * @since 4.0.0
	 *
	 * @param int $categoryId
	 * @param string $language
	 * @param int $expect
	 *
	 * @dataProvider providerAutoloader
	 */

	public function testCountByCategoryAndLanguage(int $categoryId = null, string $language = null, int $expect = null) : void
	{
		/* setup */

		$articleModel = new Model\Article();

		/* actual */

		$actual = $articleModel->countByCategoryAndLanguage($categoryId, $language);

		/* compare */

		$this->assertEquals($expect, $actual);
	}

	/**
	 * testGetSiblingByCategoryAndLanguageAndOrderAndStep
	 *
	 * @since 4.0.0
	 *
	 * @param int $categoryId
	 * @param string $language
	 * @param string $orderColumn
	 * @param int $limitStep
	 * @param array $expectArray
	 *
	 * @dataProvider providerAutoloader
	 */

	public function testGetSiblingByCategoryAndLanguageAndOrderAndStep(int $categoryId = null, string $language = null, string $orderColumn = null, int $limitStep = null, array $expectArray = []) : void
	{
		/* setup */

		$articleModel = new Model\Article();
		$setting = $this->settingFactory();
		$setting->set('limit', 1);

		/* actual */

		$actualArray = [];
		$actualObject = $articleModel->getSiblingByCategoryAndLanguageAndOrderAndStep($categoryId, $language, $orderColumn, $limitStep);

		/* process articles */

		foreach ($actualObject as $value)
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
		{
			$actualArray[] = $value->alias;
		}

		/* compare */

		$this->assertEquals($expectArray, $actualArray);
	}

	/**
	 * testGetRouteById
	 *
	 * @since 4.0.0
	 *
	 * @param int $articleId
	 * @param string $expect
	 *
	 * @dataProvider providerAutoloader
	 */

	public function testGetRouteById(int $articleId = null, string $expect = null) : void
	{
		/* setup */

		$articleModel = new Model\Article();

		/* actual */

		$actual = $articleModel->getRouteById($articleId);

		/* compare */

		$this->assertEquals($expect, $actual);
	}
}


1			<?php
2			namespace Redaxscript\Tests\Model;
3
4			use Redaxscript\Db;
5			use Redaxscript\Model;
6			use Redaxscript\Tests\TestCaseAbstract;
7
8			/**
9			* ArticleTest
10			*
11			* @since 4.0.0
12			*
13			* @package Redaxscript
14			* @category Tests
15			* @author Henry Ruhs
16			*
17			* @covers Redaxscript\Model\Article
18			*/
19
20			class ArticleTest extends TestCaseAbstract
21			{
22			/**
23			* setUp
24			*
25			* @since 4.0.0
26			*/
27
28			public function setUp() : void
29			{
30			parent::setUp();
31			$optionArray =
32			[
33			'adminName' => 'Test',
34			'adminUser' => 'test',
35			'adminPassword' => 'test',
36			'adminEmail' => '[email protected]'
37			];
38			$installer = $this->installerFactory();
39			$installer->init();
40			$installer->rawCreate();
41			$installer->insertSettings($optionArray);
42			$categoryOne = Db::forTablePrefix('categories')->create();
43			$categoryOne
44			->set(
45			[
46			'title' => 'Category One',
47			'alias' => 'category-one'
48			])
49			->save();
50			$categoryTwo = Db::forTablePrefix('categories')->create();
51			$categoryTwo
52			->set(
53			[
54			'title' => 'Category Two',
55			'alias' => 'category-two',
56			'parent' => $categoryOne->id
57			])
58			->save();
59			$categoryTwoSibling = Db::forTablePrefix('categories')->create();
60			$categoryTwoSibling
61			->set(
62			[
63			'title' => 'Category Two Sibling',
64			'alias' => 'category-two-sibling',
65			'sibling' => $categoryTwo->id
66			])
67			->save();
68			Db::forTablePrefix('articles')
69			->create()
70			->set(
71			[
72			'title' => 'Article One',
73			'alias' => 'article-one',
74			'category' => $categoryOne->id
75			])
76			->save();
77			Db::forTablePrefix('articles')
78			->create()
79			->set(
80			[
81			'title' => 'Article Two',
82			'alias' => 'article-two',
83			'category' => $categoryTwo->id
84			])
85			->save();
86			$articleThree = Db::forTablePrefix('articles')
87			->create()
88			->set(
89			[
90			'title' => 'Article Three',
91			'alias' => 'article-three',
92			'language' => 'en',
93			'category' => $categoryTwo->id
94			])
95			->save();
96			Db::forTablePrefix('articles')
97			->create()
98			->set(
99			[
100			'title' => 'Article Three Sibling',
101			'alias' => 'article-three-sibling',
102			'language' => 'de',
103			'sibling' => $articleThree->id,
104			'category' => $categoryTwoSibling->id
105			])
106			->save();
107			Db::forTablePrefix('articles')
108			->create()
109			->set(
110			[
111			'title' => 'Article Four',
112			'alias' => 'article-four'
113			])
114			->save();
115			}
116
117			/**
118			* tearDown
119			*
120			* @since 4.0.0
121			*/
122
123			public function tearDown() : void
124			{
125			$this->dropDatabase();
126			}
127
128			/**
129			* testGetByAlias
130			*
131			* @since 4.0.0
132			*
133			* @param string $articleAlias
134			* @param int $expect
135			*
136			* @dataProvider providerAutoloader
137			*/
138
139			public function testGetByAlias(string $articleAlias = null, int $expect = null) : void
140			{
141			/* setup */
142
143			$articleModel = new Model\Article();
144
145			/* actual */
146
147			$actual = $articleModel->getByAlias($articleAlias)->id;
148
149			/* compare */
150
151			$this->assertEquals($expect, $actual);
152			}
153
154			/**
155			*
156			* testCountByCategoryAndLanguage
157			*
158			* @since 4.0.0
159			*
160			* @param int $categoryId
161			* @param string $language
162			* @param int $expect
163			*
164			* @dataProvider providerAutoloader
165			*/
166
167			public function testCountByCategoryAndLanguage(int $categoryId = null, string $language = null, int $expect = null) : void
168			{
169			/* setup */
170
171			$articleModel = new Model\Article();
172
173			/* actual */
174
175			$actual = $articleModel->countByCategoryAndLanguage($categoryId, $language);
176
177			/* compare */
178
179			$this->assertEquals($expect, $actual);
180			}
181
182			/**
183			* testGetSiblingByCategoryAndLanguageAndOrderAndStep
184			*
185			* @since 4.0.0
186			*
187			* @param int $categoryId
188			* @param string $language
189			* @param string $orderColumn
190			* @param int $limitStep
191			* @param array $expectArray
192			*
193			* @dataProvider providerAutoloader
194			*/
195
196			public function testGetSiblingByCategoryAndLanguageAndOrderAndStep(int $categoryId = null, string $language = null, string $orderColumn = null, int $limitStep = null, array $expectArray = []) : void
197			{
198			/* setup */
199
200			$articleModel = new Model\Article();
201			$setting = $this->settingFactory();
202			$setting->set('limit', 1);
203
204			/* actual */
205
206			$actualArray = [];
207			$actualObject = $articleModel->getSiblingByCategoryAndLanguageAndOrderAndStep($categoryId, $language, $orderColumn, $limitStep);
208
209			/* process articles */
210
211			foreach ($actualObject as $value)
			0 ignored issues – show Bug introduced 2019-06-27 21:48 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `$actualObject` of type `object\|null` is not guaranteed to be traversable. How about adding an additional type check? There are different options of fixing this problem. If you want to be on the safe side, you can add an additional type-check: $collection = json_decode($data, true); if ( ! is_array($collection)) { throw new \RuntimeException('$collection must be an array.'); } foreach ($collection as $item) { /** ... / } If you are sure that the expression is traversable, you might want to add a doc comment cast* to improve IDE auto-completion and static analysis: /** @var array $collection / $collection = json_decode($data, true); foreach ($collection as $item) { /* .. / } Mark the issue as a false-positive*: Just hover the remove button, in the top-right corner of this issue for more options. Loading history...
212			{
213			$actualArray[] = $value->alias;
214			}
215
216			/* compare */
217
218			$this->assertEquals($expectArray, $actualArray);
219			}
220
221			/**
222			* testGetRouteById
223			*
224			* @since 4.0.0
225			*
226			* @param int $articleId
227			* @param string $expect
228			*
229			* @dataProvider providerAutoloader
230			*/
231
232			public function testGetRouteById(int $articleId = null, string $expect = null) : void
233			{
234			/* setup */
235
236			$articleModel = new Model\Article();
237
238			/* actual */
239
240			$actual = $articleModel->getRouteById($articleId);
241
242			/* compare */
243
244			$this->assertEquals($expect, $actual);
245			}
246			}
247

redaxscript / redaxscript

Push — master ( d0c173...e44a53 )

tests/unit/Model/ArticleTest.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like