redaxscript / redaxscript

includes/View/ResultList.php

<?php
namespace Redaxscript\View;

use Redaxscript\Dater;
use Redaxscript\Html;
use Redaxscript\Model;
use Redaxscript\Module;
use Redaxscript\Validator;

/**
 * children class to create the result list
 *
 * @since 3.0.0
 *
 * @package Redaxscript
 * @category View
 * @author Henry Ruhs
 * @author Balázs Szilágyi
 */

class ResultList extends ViewAbstract
{
	/**
	 * render the view
	 *
	 * @since 3.0.0
	 *
	 * @param array $resultArray array for the result
	 *
	 * @return string
	 */

	public function render(array $resultArray = []) : string
	{
		$output = Module\Hook::trigger('resultListStart');
		$accessValidator = new Validator\Access();
		$contentModel = new Model\Content();
		$dater = new Dater();
		$parameterRoute = $this->_registry->get('parameterRoute');

		/* html element */

		$element = new Html\Element();
		$titleElement = $element
			->copy()
			->init('h2',
			[
				'class' => 'rs-title-result'
			]);
		$listElement = $element
			->copy()
			->init('ol',
			[
				'class' => 'rs-list-result'
			]);
		$itemElement = $element->copy()->init('li');
		$linkElement = $element
			->copy()
			->init('a',
			[
				'class' => 'rs-link-result'
			]);
		$textElement = $element
			->copy()
			->init('span',
			[
				'class' => 'rs-text-result-date'
			]);

		/* process results */

		foreach ($resultArray as $table => $result)
		{
			$outputItem = null;
			if ($result)
			{
				/* collect item output */

				foreach ($result as $value)
				{
					if ($accessValidator->validate($result->access, $this->_registry->get('myGroups')))

It seems like $this->_registry->get('myGroups') targeting Redaxscript\Registry::get() can also be of type array; however, Redaxscript\Validator\Access::validate() does only seem to accept null|string, maybe add an additional type check?

					{
						$dater->init($value->date);
						$linkElement
							->attr('href', $parameterRoute . $contentModel->getRouteByTableAndId($table, $value->id))
							->text($value->title ? : $value->author);
						$textElement->text($dater->formatDate());
						$outputItem .= $itemElement->html($linkElement . $textElement);
					}
				}

				/* collect output */

				if ($outputItem)

The expression $outputItem of type string|null is loosely compared to true; this is ambiguous if the string can be empty. You might want to explicitly use !== null instead.

				{
					$titleElement->text($this->_language->get($table));

It seems like $this->_language->get($table) targeting Redaxscript\Language::get() can also be of type array; however, Redaxscript\Html\Element::text() does only seem to accept string|integer|null, maybe add an additional type check?

					$listElement->html($outputItem);
					$output .= $titleElement . $listElement;
				}
			}
		}
		$output .= Module\Hook::trigger('resultListEnd');
		return $output;
	}
}