Issues in TableSorter.php - All Issues - Inspection of "Display extras according to article and category" - redaxscript/redaxscript - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 03fc7e...44f12a )

by Henry

created 2018-10-19 21:03 UTC

modules/TableSorter/TableSorter.php (1 issue)

Labels

Documentation 1

Severity

Minor 1

redaxmedia 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
namespace Redaxscript\Modules\TableSorter;

use Redaxscript\Db;
use Redaxscript\Filter;
use Redaxscript\Head;
use Redaxscript\Header;
use Redaxscript\Module;

/**
 * javaScript powered table sorter
 *
 * @since 4.0.0
 *
 * @package Redaxscript
 * @category Modules
 * @author Henry Ruhs
 */

class TableSorter extends Module\Module
{
	/**
	 * array of the module
	 *
	 * @var array
	 */

	protected static $_moduleArray =
	[
		'name' => 'Table Sorter',
		'alias' => 'TableSorter',
		'author' => 'Redaxmedia',
		'description' => 'JavaScript powered table sorter',
		'version' => '4.0.0'
	];

	/**
	 * renderStart
	 *
	 * @since 4.0.0
	 */

	public function renderStart()
	{
		if ($this->_registry->get('loggedIn') === $this->_registry->get('token'))
		{
			/* link */

			$link = Head\Link::getInstance();
			$link
				->init()
				->appendFile('modules/TableSorter/dist/styles/table-sorter.min.css');

			/* script */

			$script = Head\Script::getInstance();
			$script
				->init('foot')
				->appendFile(
				[
					'https://cdnjs.cloudflare.com/ajax/libs/dragula/3.7.2/dragula.min.js',
					'modules/TableSorter/assets/scripts/init.js',
					'modules/TableSorter/dist/scripts/table-sorter.min.js'
				]);

			/* handle sort */

			if ($this->_registry->get('firstParameter') === 'module' && $this->_registry->get('secondParameter') === 'table-sorter' && $this->_registry->get('thirdParameter') === 'sort' && $this->_registry->get('tokenParameter'))
			{
				$this->_registry->set('renderBreak', true);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
				echo $this->_sort();
			}
		}
	}

	/**
	 * sort
	 *
	 * @since 4.0.0
	 *
	 * @return string|null
	 */

	protected function _sort() : ?string
	{
		if ($this->_request->getServer('HTTP_X_REQUESTED_WITH') === 'XMLHttpRequest')
		{
			$postArray = $this->_sanitizePost();
			$contents = Db::forTablePrefix($postArray['table'])->whereIn('id', $postArray['rankArray'])->findMany();

			/* process contents */

			foreach ($contents as $value)
			{
				$value->set('rank', array_search($value->id, $postArray['rankArray']));
			}

			/* handle response */

			if ($contents->save())
			{
				Header::contentType('application/json');
				return json_encode($postArray['rankArray']);
			}
		}
		Header::responseCode(404);
		exit;
	}

	/**
	 * sanitize the post
	 *
	 * @since 4.0.0
	 *
	 * @return array
	 */

	protected function _sanitizePost() : array
	{
		$specialFilter = new Filter\Special();
		$content = file_get_contents('php://input');
		$postArray = (array)json_decode($content);

		/* sanitize post */

		return
		[
			'table' => $specialFilter->sanitize($postArray['table']),
			'rankArray' => $postArray['rankArray']
		];
	}
}


1			<?php
2			namespace Redaxscript\Modules\TableSorter;
3
4			use Redaxscript\Db;
5			use Redaxscript\Filter;
6			use Redaxscript\Head;
7			use Redaxscript\Header;
8			use Redaxscript\Module;
9
10			/**
11			* javaScript powered table sorter
12			*
13			* @since 4.0.0
14			*
15			* @package Redaxscript
16			* @category Modules
17			* @author Henry Ruhs
18			*/
19
20			class TableSorter extends Module\Module
21			{
22			/**
23			* array of the module
24			*
25			* @var array
26			*/
27
28			protected static $_moduleArray =
29			[
30			'name' => 'Table Sorter',
31			'alias' => 'TableSorter',
32			'author' => 'Redaxmedia',
33			'description' => 'JavaScript powered table sorter',
34			'version' => '4.0.0'
35			];
36
37			/**
38			* renderStart
39			*
40			* @since 4.0.0
41			*/
42
43			public function renderStart()
44			{
45			if ($this->_registry->get('loggedIn') === $this->_registry->get('token'))
46			{
47			/* link */
48
49			$link = Head\Link::getInstance();
50			$link
51			->init()
52			->appendFile('modules/TableSorter/dist/styles/table-sorter.min.css');
53
54			/* script */
55
56			$script = Head\Script::getInstance();
57			$script
58			->init('foot')
59			->appendFile(
60			[
61			'https://cdnjs.cloudflare.com/ajax/libs/dragula/3.7.2/dragula.min.js',
62			'modules/TableSorter/assets/scripts/init.js',
63			'modules/TableSorter/dist/scripts/table-sorter.min.js'
64			]);
65
66			/* handle sort */
67
68			if ($this->_registry->get('firstParameter') === 'module' && $this->_registry->get('secondParameter') === 'table-sorter' && $this->_registry->get('thirdParameter') === 'sort' && $this->_registry->get('tokenParameter'))
69			{
70			$this->_registry->set('renderBreak', true);
			0 ignored issues – show Documentation introduced 2018-09-21 20:24 UTC by Report Bug Copy Issue Report Show Similar Issues like this `true` is of type `boolean`, but the function expects a `string\|array\|null`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
71			echo $this->_sort();
72			}
73			}
74			}
75
76			/**
77			* sort
78			*
79			* @since 4.0.0
80			*
81			* @return string\|null
82			*/
83
84			protected function _sort() : ?string
85			{
86			if ($this->_request->getServer('HTTP_X_REQUESTED_WITH') === 'XMLHttpRequest')
87			{
88			$postArray = $this->_sanitizePost();
89			$contents = Db::forTablePrefix($postArray['table'])->whereIn('id', $postArray['rankArray'])->findMany();
90
91			/* process contents */
92
93			foreach ($contents as $value)
94			{
95			$value->set('rank', array_search($value->id, $postArray['rankArray']));
96			}
97
98			/* handle response */
99
100			if ($contents->save())
101			{
102			Header::contentType('application/json');
103			return json_encode($postArray['rankArray']);
104			}
105			}
106			Header::responseCode(404);
107			exit;
108			}
109
110			/**
111			* sanitize the post
112			*
113			* @since 4.0.0
114			*
115			* @return array
116			*/
117
118			protected function _sanitizePost() : array
119			{
120			$specialFilter = new Filter\Special();
121			$content = file_get_contents('php://input');
122			$postArray = (array)json_decode($content);
123
124			/* sanitize post */
125
126			return
127			[
128			'table' => $specialFilter->sanitize($postArray['table']),
129			'rankArray' => $postArray['rankArray']
130			];
131			}
132			}
133

redaxscript / redaxscript

Push — master ( 03fc7e...44f12a )

modules/TableSorter/TableSorter.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like