Issues in LoginTest.php - Fixed Issues - Inspection of "Update README.md" - redaxscript/redaxscript - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 16ddfb...0ea243 )

by Henry

created 2019-05-20 23:53 UTC

tests/acceptance/LoginTest.php (1 issue)

Showing only issues like (Show All)

mismatching argument types.

Documentation Minor

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
namespace Redaxscript\Tests;

use Facebook\WebDriver\WebDriverBy;
use Facebook\WebDriver\WebDriverExpectedCondition;

/**
 * LoginTest
 *
 * @since 4.0.0
 *
 * @package Redaxscript
 * @category Tests
 * @author Henry Ruhs
 */

class LoginTest extends TestCaseAbstract
{
	/**
	 * setUp
	 *
	 * @since 4.0.0
	 */

	public function setUp() : void
	{
		parent::setUp();
		$this->_driver->get('http://localhost:8000/?p=login');
	}

	/**
	 * testTitle
	 *
	 * @since 4.0.0
	 */

	public function testTitle() : void
	{
		/* expect and actual */

		$expect = $this->_language->get('login') . ' - ' . $this->_language->get('name', '_package');
		$actual = $this->_driver->getTitle();

		/* compare */

		$this->assertEquals($expect, $actual);
	}

	/**
	 * testLogin
	 *
	 * @since 4.0.0
	 */

	public function testLogin() : void
	{
		/* prepare */

		$formElement = $this->_driver->findElement(WebDriverBy::tagName('form'));
		$userElement = $formElement->findElement(WebDriverBy::id('user'));
		$passwordElement = $formElement->findElement(WebDriverBy::id('password'));
		$buttonElement = $formElement->findElement(WebDriverBy::tagName('button'));

		/* setup */

		$userElement->sendKeys('test');
		$passwordElement->sendKeys('test');
		$buttonElement->click();

		/* compare */

		$this->_driver->wait(5)->until(WebDriverExpectedCondition::urlIs('http://localhost:8000/?p=admin'));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
		$this->expectNotToPerformAssertions();
	}
}


1			<?php
2			namespace Redaxscript\Tests;
3
4			use Facebook\WebDriver\WebDriverBy;
5			use Facebook\WebDriver\WebDriverExpectedCondition;
6
7			/**
8			* LoginTest
9			*
10			* @since 4.0.0
11			*
12			* @package Redaxscript
13			* @category Tests
14			* @author Henry Ruhs
15			*/
16
17			class LoginTest extends TestCaseAbstract
18			{
19			/**
20			* setUp
21			*
22			* @since 4.0.0
23			*/
24
25			public function setUp() : void
26			{
27			parent::setUp();
28			$this->_driver->get('http://localhost:8000/?p=login');
29			}
30
31			/**
32			* testTitle
33			*
34			* @since 4.0.0
35			*/
36
37			public function testTitle() : void
38			{
39			/* expect and actual */
40
41			$expect = $this->_language->get('login') . ' - ' . $this->_language->get('name', '_package');
42			$actual = $this->_driver->getTitle();
43
44			/* compare */
45
46			$this->assertEquals($expect, $actual);
47			}
48
49			/**
50			* testLogin
51			*
52			* @since 4.0.0
53			*/
54
55			public function testLogin() : void
56			{
57			/* prepare */
58
59			$formElement = $this->_driver->findElement(WebDriverBy::tagName('form'));
60			$userElement = $formElement->findElement(WebDriverBy::id('user'));
61			$passwordElement = $formElement->findElement(WebDriverBy::id('password'));
62			$buttonElement = $formElement->findElement(WebDriverBy::tagName('button'));
63
64			/* setup */
65
66			$userElement->sendKeys('test');
67			$passwordElement->sendKeys('test');
68			$buttonElement->click();
69
70			/* compare */
71
72			$this->_driver->wait(5)->until(WebDriverExpectedCondition::urlIs('http://localhost:8000/?p=admin'));
			0 ignored issues – show Documentation introduced 2019-01-26 22:42 UTC by Report Bug Copy Issue Report Show Similar Issues like this `\Facebook\WebDriver\WebD...calhost:8000/?p=admin')` is of type `object<Facebook\WebDrive...riverExpectedCondition>`, but the function expects a `callable`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
73			$this->expectNotToPerformAssertions();
74			}
75			}
76

redaxscript / redaxscript

Push — master ( 16ddfb...0ea243 )

tests/acceptance/LoginTest.php (1 issue)

Showing only issues like (Show All)

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like