More::process() - Code Metrics - Inspection of "Jump to read more and style break (#655)" - redaxscript/redaxscript - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 0a9993...81cd45 )

by Henry

created 2020-05-23 13:51 UTC

More::process() B

↳ Parent: More

Complexity

Conditions	5
Paths	4

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	12
CRAP Score	5

Importance

Changes

Metric	Value
dl	0
loc	41
ccs	12
cts	12
cp	1
rs	8.9528
c	0
b	0
f	0
cc	5
nc	4
nop	2
crap	5

<?php
namespace Redaxscript\Content\Tag;

use Redaxscript\Html;
use function str_replace;
use function strpos;
use function substr;

/**
 * children class to parse content for more tags
 *
 * @since 3.0.0
 *
 * @package Redaxscript
 * @category Content
 * @author Henry Ruhs
 */

class More extends TagAbstract
{
	/**
	 * options of the more tag
	 *
	 * @var array
	 */

	protected $_optionArray =
	[
		'prefix' => 'more-',
		'className' =>
		[
			'link' => 'rs-link-more',
			'break' => 'rs-break-more'
		],
		'search' =>
		[
			'<rs-more>'
		]
	];

	/**
	 * process the class
	 *
	 * @since 3.0.0
	 *
	 * @param string $content content to be parsed
	 * @param string $route route of the content
	 *
	 * @return string
	 */

	public function process(string $content = null, string $route = null) : string
	{
		$output = str_replace($this->_optionArray['search'], null, $content);
		$position = strpos($content, $this->_optionArray['search'][0]);
		$id = $this->_optionArray['prefix'] . $position;

		/* html element */

		$element = new Html\Element();
		$linkElement = $element
			->copy()
			->init('a',
			[
				'class' => $this->_optionArray['className']['link']
			]);
		$breakElement = $element
			->copy()
			->init('hr',
			[
				'id' => $id,
				'class' => $this->_optionArray['className']['break']
			]);

		/* collect output */

		if ($position > -1 && $this->_registry->get('lastTable') === 'categories')
		{
			$output = substr($output, 0, $position);
			if ($route)
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
			{
				$output .= $linkElement
					->attr('href', $this->_registry->get('parameterRoute') . $route . '#' . $id)
					->text($this->_language->get('read_more'));

			}
		}
		else if ($position > -1)
		{
			$output = substr($output, 0, $position) . $breakElement . substr($output, $position);
		}
		return $output;
	}
}


1		<?php
2		namespace Redaxscript\Content\Tag;
3
4		use Redaxscript\Html;
5		use function str_replace;
6		use function strpos;
7		use function substr;
8
9		/**
10		* children class to parse content for more tags
11		*
12		* @since 3.0.0
13		*
14		* @package Redaxscript
15		* @category Content
16		* @author Henry Ruhs
17		*/
18
19		class More extends TagAbstract
20		{
21		/**
22		* options of the more tag
23		*
24		* @var array
25		*/
26
27		protected $_optionArray =
28		[
29		'prefix' => 'more-',
30		'className' =>
31		[
32		'link' => 'rs-link-more',
33		'break' => 'rs-break-more'
34		],
35		'search' =>
36		[
37		'<rs-more>'
38		]
39		];
40
41		/**
42		* process the class
43		*
44		* @since 3.0.0
45		*
46		* @param string $content content to be parsed
47		* @param string $route route of the content
48		*
49		* @return string
50	15	*/
51
52	15	public function process(string $content = null, string $route = null) : string
53	15	{
54		$output = str_replace($this->_optionArray['search'], null, $content);
55		$position = strpos($content, $this->_optionArray['search'][0]);
56		$id = $this->_optionArray['prefix'] . $position;
57	15
58	15	/* html element */
59
60	15	$element = new Html\Element();
61		$linkElement = $element
62		->copy()
63		->init('a',
64		[
65	15	'class' => $this->_optionArray['className']['link']
66		]);
67	1	$breakElement = $element
68	1	->copy()
69		->init('hr',
70		[
71	1	'id' => $id,
72	1	'class' => $this->_optionArray['className']['break']
73	1	]);
74
75		/* collect output */
76	15
77		if ($position > -1 && $this->_registry->get('lastTable') === 'categories')
78		{
79		$output = substr($output, 0, $position);
80		if ($route)
		0 ignored issues – show Bug Best Practice introduced 2017-11-03 13:07 UTC by Report Bug Copy Issue Report The expression `$route` of type `null\|string` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
81		{
82		$output .= $linkElement
83		->attr('href', $this->_registry->get('parameterRoute') . $route . '#' . $id)
84		->text($this->_language->get('read_more'));
		0 ignored issues – show Bug introduced 2018-10-17 01:12 UTC by Report Bug Copy Issue Report It seems like `$this->_language->get('read_more')` targeting `Redaxscript\Language::get()` can also be of type `array`; however, `Redaxscript\Html\Element::text()` does only seem to accept `string\|integer\|null`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
85		}
86		}
87		else if ($position > -1)
88		{
89		$output = substr($output, 0, $position) . $breakElement . substr($output, $position);
90		}
91		return $output;
92		}
93		}
94

redaxscript / redaxscript

Push — master ( 0a9993...81cd45 )

More::process() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like