Issues in Comment.php - Fixed Issues - Inspection of "Develop (#589)" - redaxscript/redaxscript - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( e9b1ca...cbd317 )

by Henry

created 2018-12-15 13:52 UTC

includes/Navigation/Comment.php (1 issue)

Labels

Severity

Major 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
namespace Redaxscript\Navigation;

use Redaxscript\Html;
use Redaxscript\Model;
use Redaxscript\Module;
use Redaxscript\Validator;

/**
 * children class to create the comment navigation
 *
 * @since 3.3.0
 *
 * @package Redaxscript
 * @category Navigation
 * @author Henry Ruhs
 */

class Comment extends NavigationAbstract
{
	/**
	 * options of the navigation
	 *
	 * @var array
	 */

	protected $_optionArray =
	[
		'className' =>
		[
			'list' => 'rs-list-comments'
		],
		'orderColumn' => 'rank'
	];

	/**
	 * render the view
	 *
	 * @since 3.3.0
	 *
	 * @return string
	 */

	public function render() : string
	{
		$output = Module\Hook::trigger('navigationCommentStart');
		$outputItem = null;
		$commentModel = new Model\Comment();
		$accessValidator = new Validator\Access();

		/* html element */

		$element = new Html\Element();
		$listElement = $element
			->copy()
			->init('ul',
			[
				'class' => $this->_optionArray['className']['list']
			]);
		$itemElement = $element->copy()->init('li');
		$linkElement = $element->copy()->init('a');

		/* query comments */

		$comments = $commentModel
			->query()
			->whereLanguageIs($this->_registry->get('language'))
			->where('status', 1)
			->orderBySetting($this->_optionArray['orderColumn'])
			->limit($this->_optionArray['limit'])
			->findMany();

		/* collect item output */

		foreach ($comments as $value)
		{
			if ($accessValidator->validate($value->access, $this->_registry->get('myGroups')))
			{
				$outputItem .= $itemElement
					->copy()
					->html($linkElement
						->copy()
						->attr(
						[
							'href' => $this->_registry->get('parameterRoute') . $commentModel->getRouteById($value->id)
						])
						->text($value->author . $this->_language->get('colon') . ' ' . $value->text)
					);
			}
		}

		/* collect output */

		if ($outputItem)
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
		{
			$output .= $listElement->html($outputItem);
		}
		$output .= Module\Hook::trigger('navigationCommentEnd');
		return $output;
	}
}


1		<?php
2		namespace Redaxscript\Navigation;
3
4		use Redaxscript\Html;
5		use Redaxscript\Model;
6		use Redaxscript\Module;
7		use Redaxscript\Validator;
8
9		/**
10		* children class to create the comment navigation
11		*
12		* @since 3.3.0
13		*
14		* @package Redaxscript
15		* @category Navigation
16		* @author Henry Ruhs
17		*/
18
19		class Comment extends NavigationAbstract
20		{
21		/**
22		* options of the navigation
23		*
24		* @var array
25		*/
26
27		protected $_optionArray =
28		[
29		'className' =>
30		[
31		'list' => 'rs-list-comments'
32		],
33		'orderColumn' => 'rank'
34		];
35
36		/**
37		* render the view
38		*
39		* @since 3.3.0
40		*
41		* @return string
42		*/
43
44	2	public function render() : string
45		{
46	2	$output = Module\Hook::trigger('navigationCommentStart');
47	2	$outputItem = null;
48	2	$commentModel = new Model\Comment();
49	2	$accessValidator = new Validator\Access();
50
51		/* html element */
52
53	2	$element = new Html\Element();
54		$listElement = $element
55	2	->copy()
56	2	->init('ul',
57		[
58	2	'class' => $this->_optionArray['className']['list']
59		]);
60	2	$itemElement = $element->copy()->init('li');
61	2	$linkElement = $element->copy()->init('a');
62
63		/* query comments */
64
65		$comments = $commentModel
66	2	->query()
67	2	->whereLanguageIs($this->_registry->get('language'))
68	2	->where('status', 1)
69	2	->orderBySetting($this->_optionArray['orderColumn'])
70	2	->limit($this->_optionArray['limit'])
71	2	->findMany();
72
73		/* collect item output */
74
75	2	foreach ($comments as $value)
76		{
77	2	if ($accessValidator->validate($value->access, $this->_registry->get('myGroups')))
78		{
79		$outputItem .= $itemElement
80	2	->copy()
81	2	->html($linkElement
82	2	->copy()
83	2	->attr(
84		[
85	2	'href' => $this->_registry->get('parameterRoute') . $commentModel->getRouteById($value->id)
86		])
87	2	->text($value->author . $this->_language->get('colon') . ' ' . $value->text)
88		);
89		}
90		}
91
92		/* collect output */
93
94	2	if ($outputItem)
		0 ignored issues – show Bug Best Practice introduced 2017-12-12 23:18 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `$outputItem` of type `string\|null` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
95		{
96	2	$output .= $listElement->html($outputItem);
97		}
98	2	$output .= Module\Hook::trigger('navigationCommentEnd');
99	2	return $output;
100		}
101		}
102

redaxscript / redaxscript

Push — master ( e9b1ca...cbd317 )

includes/Navigation/Comment.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like