Language::autorun() - Code Metrics - Inspection of "Update dependencies and fix live reload for partia..." - redaxscript/redaxscript - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 14c945...6811c1 )

by Henry

created 2019-12-14 09:20 UTC

Language::autorun() A

↳ Parent: Project

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes

Metric	Value
dl	0
loc	22
ccs	0
cts	15
cp	0
rs	9.568
c	0
b	0
f	0
cc	2
nc	2
nop	0
crap	6

<?php
namespace Redaxscript\Detector;

use Redaxscript\Model;
use function substr;

/**
 * children class to detect the current language
 *
 * @since 2.0.0
 *
 * @package Redaxscript
 * @category Detector
 * @author Henry Ruhs
 */

class Language extends DetectorAbstract
{
	/**
	 * automate run
	 *
	 * @since 2.1.0
	 */

	public function autorun() : void
	{
		$settingModel = new Model\Setting();
		$contentModel = new Model\Content();
		$dbStatus = $this->_registry->get('dbStatus');
		$lastTable = $this->_registry->get('lastTable');
		$lastId = $this->_registry->get('lastId');
		$path = 'languages' . DIRECTORY_SEPARATOR . $this->_filePlaceholder . '.json';
		$setupArray =
		[
			'query' => $this->_request->getQuery('l'),
			'session' => $this->_request->getSession('language'),
			'contents' => $contentModel->getByTableAndId($lastTable, $lastId)->language,
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
			'settings' => $dbStatus === 2 ? $settingModel->get('language') : null,
			'browser' => substr($this->_request->getServer('HTTP_ACCEPT_LANGUAGE'), 0, 2),
			'fallback' => 'en'
		];

		/* detect language */

		$this->_output = $this->_detect('language', $path, $setupArray);
	}
}


1			<?php
2			namespace Redaxscript\Detector;
3
4			use Redaxscript\Model;
5			use function substr;
6
7			/**
8			* children class to detect the current language
9			*
10			* @since 2.0.0
11			*
12			* @package Redaxscript
13			* @category Detector
14			* @author Henry Ruhs
15			*/
16
17			class Language extends DetectorAbstract
18			{
19			/**
20			* automate run
21			*
22			* @since 2.1.0
23			*/
24
25			public function autorun() : void
26			{
27			$settingModel = new Model\Setting();
28			$contentModel = new Model\Content();
29			$dbStatus = $this->_registry->get('dbStatus');
30			$lastTable = $this->_registry->get('lastTable');
31			$lastId = $this->_registry->get('lastId');
32			$path = 'languages' . DIRECTORY_SEPARATOR . $this->_filePlaceholder . '.json';
33			$setupArray =
34			[
35			'query' => $this->_request->getQuery('l'),
36			'session' => $this->_request->getSession('language'),
37			'contents' => $contentModel->getByTableAndId($lastTable, $lastId)->language,
			0 ignored issues – show Bug introduced 2018-12-07 16:57 UTC by Report Bug Copy Issue Report It seems like `$lastTable` defined by `$this->_registry->get('lastTable')` on line `30` can also be of type `array`; however, `Redaxscript\Model\Content::getByTableAndId()` does only seem to accept `null\|string`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string / function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history... Bug introduced 2018-12-07 16:57 UTC by Report Bug Copy Issue Report It seems like `$lastId` defined by `$this->_registry->get('lastId')` on line `31` can also be of type `array` or `string`; however, `Redaxscript\Model\Content::getByTableAndId()` does only seem to accept `null\|integer`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /* * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
38			'settings' => $dbStatus === 2 ? $settingModel->get('language') : null,
39			'browser' => substr($this->_request->getServer('HTTP_ACCEPT_LANGUAGE'), 0, 2),
40			'fallback' => 'en'
41			];
42
43			/* detect language */
44
45			$this->_output = $this->_detect('language', $path, $setupArray);
46			}
47			}
48

redaxscript / redaxscript

Push — master ( 14c945...6811c1 )

Language::autorun() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like