Issues in ClientAbstract.php - Fixed Issues - Inspection of "Fully qualified functions (#587)" - redaxscript/redaxscript - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 541b76...aec89b )

by Henry

created 2018-11-15 23:08 UTC

includes/Client/ClientAbstract.php (1 issue)

Showing only issues like (Show All)

Checks property assignments for possibly missing type casts

Bug Documentation Minor

redaxmedia 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
namespace Redaxscript\Client;

use Redaxscript\Request;

/**
 * abstract class to create a client class
 *
 * @since 2.4.0
 *
 * @package Redaxscript
 * @category Client
 * @author Henry Ruhs
 *
 * @method protected _autorun()
 */

abstract class ClientAbstract
{
	/**
	 * instance of the request class
	 *
	 * @var Request
	 */

	protected $_request;

	/**
	 * output of the client
	 *
	 * @var string
	 */

	protected $_output;

	/**
	 * constructor of the class
	 *
	 * @since 2.4.0
	 *
	 * @param Request $request instance of the request class
	 */

	public function __construct(Request $request)
	{
		$this->_request = $request;
		$this->_autorun();
	}

	/**
	 * get the output
	 *
	 * @since 2.4.0
	 *
	 * @return string|null
	 */

	public function getOutput() : ?string
	{
		return $this->_output;
	}

	/**
	 * detect the required type
	 *
	 * @since 2.4.0
	 *
	 * @param array $setupArray array of client setup
	 * @param string $type type of the client
	 */

	protected function _detect(array $setupArray = [], string $type = null)
	{
		$userAgent = strtolower($this->_request->getServer('HTTP_USER_AGENT'));

		/* process setup */

		foreach ($setupArray as $value)
		{
			if (stristr($userAgent, $value))
			{
				/* general */

				$this->_output = $value;

				/* version */

				if ($type === 'version')
				{
					$this->_output = floor(substr($userAgent, strpos($userAgent, $value) + strlen($value) + 1, 3));
$answer = 42;

$correct = false;

$correct = (bool) $answer;
				}
			}
		}
	}
}


1		<?php
2		namespace Redaxscript\Client;
3
4		use Redaxscript\Request;
5
6		/**
7		* abstract class to create a client class
8		*
9		* @since 2.4.0
10		*
11		* @package Redaxscript
12		* @category Client
13		* @author Henry Ruhs
14		*
15		* @method protected _autorun()
16		*/
17
18		abstract class ClientAbstract
19		{
20		/**
21		* instance of the request class
22		*
23		* @var Request
24		*/
25
26		protected $_request;
27
28		/**
29		* output of the client
30		*
31		* @var string
32		*/
33
34		protected $_output;
35
36		/**
37		* constructor of the class
38		*
39		* @since 2.4.0
40		*
41		* @param Request $request instance of the request class
42		*/
43
44	78	public function __construct(Request $request)
45		{
46	78	$this->_request = $request;
47	78	$this->_autorun();
48	78	}
49
50		/**
51		* get the output
52		*
53		* @since 2.4.0
54		*
55		* @return string\|null
56		*/
57
58	78	public function getOutput() : ?string
59		{
60	78	return $this->_output;
61		}
62
63		/**
64		* detect the required type
65		*
66		* @since 2.4.0
67		*
68		* @param array $setupArray array of client setup
69		* @param string $type type of the client
70		*/
71
72	78	protected function _detect(array $setupArray = [], string $type = null)
73		{
74	78	$userAgent = strtolower($this->_request->getServer('HTTP_USER_AGENT'));
75
76		/* process setup */
77
78	78	foreach ($setupArray as $value)
79		{
80	78	if (stristr($userAgent, $value))
81		{
82		/* general */
83
84	55	$this->_output = $value;
85
86		/* version */
87
88	55	if ($type === 'version')
89		{
90	78	$this->_output = floor(substr($userAgent, strpos($userAgent, $value) + strlen($value) + 1, 3));
		0 ignored issues – show Documentation Bug introduced 2018-04-25 13:20 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `$_output` was declared of type `string`, but `floor(substr($userAgent,...strlen($value) + 1, 3))` is of type `double`. Maybe add a type cast? This check looks for assignments to scalar types that may be of the wrong type. To ensure the code behaves as expected, it may be a good idea to add an explicit type cast. $answer = 42; $correct = false; $correct = (bool) $answer; Loading history...
91		}
92		}
93		}
94	78	}
95		}
96

redaxscript / redaxscript

Push — master ( 541b76...aec89b )

includes/Client/ClientAbstract.php (1 issue)

Showing only issues like (Show All)

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like