redaxscript / redaxscript

includes/Template/Helper/Robots.php

<?php
namespace Redaxscript\Template\Helper;

use Redaxscript\Db;
use Redaxscript\Model;
use function array_key_exists;
use function is_array;

/**
 * helper class to provide a robots helper
 *
 * @since 3.0.0
 *
 * @package Redaxscript
 * @category Template
 * @author Henry Ruhs
 */

class Robots extends HelperAbstract
{
	/**
	 * array of the robots
	 *
	 * @var array
	 */

	protected static $_robotArray =
	[
		1 => 'all',
		2 => 'index',
		3 => 'follow',
		4 => 'index_no',
		5 => 'follow_no',
		6 => 'none'
	];

	/**
	 * process
	 *
	 * @since 3.0.0
	 *
	 * @return string|null
	 */

	public function process() : ?string
	{
		$settingModel = new Model\Setting();
		$lastTable = $this->_registry->get('lastTable');
		$lastId = $this->_registry->get('lastId');
		$useRobots = $this->_registry->get('useRobots');
		$settingRobots = $settingModel->get('robots');
		$robots = null;

		/* handle robots */

		if ($useRobots)
		{
			$robots = $useRobots;
		}
		else if ($lastTable && $lastId)
		{
			$content = Db::forTablePrefix($lastTable)->whereIdIs($lastId)->whereNull('access')->findOne();

It seems like $lastTable defined by $this->_registry->get('lastTable') on line 48 can also be of type array; however, Redaxscript\Db::forTablePrefix() does only seem to accept null|string, maybe add an additional type check?

			$robots = $content->robots;

			/* handle parent */

			if (!$robots)
			{
				$parentId = $content->category ? : $content->parent;
				if ($parentId)
				{
					$parent = Db::forTablePrefix('categories')->whereIdIs($parentId)->whereNull('access')->findOne();
					$robots = $parent->robots;
				}
			}
		}

		/* handle robots */

		if (is_array(self::$_robotArray) && array_key_exists($robots, self::$_robotArray))
		{
			return self::$_robotArray[$robots];
		}
		return self::$_robotArray[$settingRobots];
	}
}