Issues in Setting.php - All Issues - Inspection of "Extend skeleton template with dashboard" - redaxscript/redaxscript - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 113b98...ac9af8 )

by Henry

created 2019-09-25 15:10 UTC

includes/Admin/Controller/Setting.php (1 issue)

Showing only issues like (Show All)

Check for implicit conversion of array to boolean.

Best Practice Bug Minor

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
namespace Redaxscript\Admin\Controller;

use Redaxscript\Admin;
use Redaxscript\Filter;

/**
 * children class to process the admin setting request
 *
 * @since 4.0.0
 *
 * @package Redaxscript
 * @category Controller
 * @author Henry Ruhs
 */

class Setting extends ControllerAbstract
{
	/**
	 * process the class
	 *
	 * @since 4.0.0
	 *
	 * @param string $action action to process
	 *
	 * @return string
	 */

	public function process(string $action = null) : string
	{
		$postArray = $this->_normalizePost($this->_sanitizePost());
		$validateArray = $this->_validatePost($postArray);

		/* validate post */

		if ($validateArray)

		{
			return $this->_error(
			[
				'route' => $this->_getErrorRoute(),
				'message' => $validateArray
			]);
		}

		/* handle update */

		if ($action === 'update')
		{
			$updateArray =
			[
				'language' => $postArray['language'],
				'template' => $postArray['template'],
				'title' => $postArray['title'],
				'author' => $postArray['author'],
				'copyright' => $postArray['copyright'],
				'description' => $postArray['description'],
				'keywords' => $postArray['keywords'],
				'robots' => $postArray['robots'],
				'email' => $postArray['email'],
				'subject' => $postArray['subject'],
				'notification' => $postArray['notification'],
				'charset' => $postArray['charset'],
				'divider' => $postArray['divider'],
				'zone' => $postArray['zone'],
				'time' => $postArray['time'],
				'date' => $postArray['date'],
				'homepage' => $postArray['homepage'],
				'limit' => $postArray['limit'],
				'order' => $postArray['order'],
				'pagination' => $postArray['pagination'],
				'moderation' => $postArray['moderation'],
				'registration' => $postArray['registration'],
				'verification' => $postArray['verification'],
				'recovery' => $postArray['recovery'],
				'captcha' => $postArray['captcha']
			];
			if ($this->_update($updateArray))
			{
				return $this->_success(
				[
					'route' => 'admin',
					'timeout' => 2
				]);
			}
		}

		/* handle error */

		return $this->_error(
		[
			'route' => $this->_getErrorRoute()
		]);
	}

	/**
	 * sanitize the post
	 *
	 * @since 4.0.0
	 *
	 * @return array
	 */

	protected function _sanitizePost() : array
	{
		$numberFilter = new Filter\Number();
		$specialFilter = new Filter\Special();
		$emailFilter = new Filter\Email();

		/* sanitize post */

		return
		[
			'language' => $specialFilter->sanitize($this->_request->getPost('language')),
			'template' => $specialFilter->sanitize($this->_request->getPost('template')),
			'title' => $this->_request->getPost('title'),
			'author' => $this->_request->getPost('author'),
			'copyright' => $this->_request->getPost('copyright'),
			'description' => $this->_request->getPost('description'),
			'keywords' => $this->_request->getPost('keywords'),
			'robots' => $this->_request->getPost('robots'),
			'email' => $emailFilter->sanitize($this->_request->getPost('email')),
			'subject' => $this->_request->getPost('subject'),
			'notification' => $numberFilter->sanitize($this->_request->getPost('notification')),
			'charset' => $this->_request->getPost('charset'),
			'divider' => $this->_request->getPost('divider'),
			'zone' => $this->_request->getPost('zone'),
			'time' => $this->_request->getPost('time'),
			'date' => $this->_request->getPost('date'),
			'homepage' => $this->_request->getPost('homepage'),
			'limit' => $numberFilter->sanitize($this->_request->getPost('limit')),
			'order' => $specialFilter->sanitize($this->_request->getPost('order')),
			'pagination' => $numberFilter->sanitize($this->_request->getPost('pagination')),
			'moderation' => $numberFilter->sanitize($this->_request->getPost('moderation')),
			'registration' => $numberFilter->sanitize($this->_request->getPost('registration')),
			'verification' => $numberFilter->sanitize($this->_request->getPost('verification')),
			'recovery' => $numberFilter->sanitize($this->_request->getPost('recovery')),
			'captcha' => $numberFilter->sanitize($this->_request->getPost('captcha'))
		];
	}

	/**
	 * validate the post
	 *
	 * @since 4.0.0
	 *
	 * @param array $postArray array of the post
	 *
	 * @return array
	 */

	protected function _validatePost(array $postArray = []) : array
	{
		$validateArray = [];

		/* validate post */

		if (!$postArray['charset'] || !$postArray['limit'])
		{
			$validateArray[] = $this->_language->get('input_empty');
		}
		return $validateArray;
	}

	/**
	 * update the setting
	 *
	 * @since 4.0.0
	 *
	 * @param array $updateArray array of the update
	 *
	 * @return bool
	 */

	protected function _update(array $updateArray = []) : bool
	{
		$settingModel = new Admin\Model\Setting();
		return $settingModel->updateByArray($updateArray);
	}

	/**
	 * get error route
	 *
	 * @since 4.1.0
	 *
	 * @return string
	 */

	protected function _getErrorRoute() : string
	{
		if ($this->_registry->get('settingsEdit'))
		{
			return 'admin/edit/settings';
		}
		return 'admin';
	}
}


1			<?php
2			namespace Redaxscript\Admin\Controller;
3
4			use Redaxscript\Admin;
5			use Redaxscript\Filter;
6
7			/**
8			* children class to process the admin setting request
9			*
10			* @since 4.0.0
11			*
12			* @package Redaxscript
13			* @category Controller
14			* @author Henry Ruhs
15			*/
16
17			class Setting extends ControllerAbstract
18			{
19			/**
20			* process the class
21			*
22			* @since 4.0.0
23			*
24			* @param string $action action to process
25			*
26			* @return string
27			*/
28
29			public function process(string $action = null) : string
30			{
31			$postArray = $this->_normalizePost($this->_sanitizePost());
32			$validateArray = $this->_validatePost($postArray);
33
34			/* validate post */
35
36			if ($validateArray)
			0 ignored issues – show Bug Best Practice introduced 2018-07-03 16:14 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `$validateArray` of type `array` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `! empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
37			{
38			return $this->_error(
39			[
40			'route' => $this->_getErrorRoute(),
41			'message' => $validateArray
42			]);
43			}
44
45			/* handle update */
46
47			if ($action === 'update')
48			{
49			$updateArray =
50			[
51			'language' => $postArray['language'],
52			'template' => $postArray['template'],
53			'title' => $postArray['title'],
54			'author' => $postArray['author'],
55			'copyright' => $postArray['copyright'],
56			'description' => $postArray['description'],
57			'keywords' => $postArray['keywords'],
58			'robots' => $postArray['robots'],
59			'email' => $postArray['email'],
60			'subject' => $postArray['subject'],
61			'notification' => $postArray['notification'],
62			'charset' => $postArray['charset'],
63			'divider' => $postArray['divider'],
64			'zone' => $postArray['zone'],
65			'time' => $postArray['time'],
66			'date' => $postArray['date'],
67			'homepage' => $postArray['homepage'],
68			'limit' => $postArray['limit'],
69			'order' => $postArray['order'],
70			'pagination' => $postArray['pagination'],
71			'moderation' => $postArray['moderation'],
72			'registration' => $postArray['registration'],
73			'verification' => $postArray['verification'],
74			'recovery' => $postArray['recovery'],
75			'captcha' => $postArray['captcha']
76			];
77			if ($this->_update($updateArray))
78			{
79			return $this->_success(
80			[
81			'route' => 'admin',
82			'timeout' => 2
83			]);
84			}
85			}
86
87			/* handle error */
88
89			return $this->_error(
90			[
91			'route' => $this->_getErrorRoute()
92			]);
93			}
94
95			/**
96			* sanitize the post
97			*
98			* @since 4.0.0
99			*
100			* @return array
101			*/
102
103			protected function _sanitizePost() : array
104			{
105			$numberFilter = new Filter\Number();
106			$specialFilter = new Filter\Special();
107			$emailFilter = new Filter\Email();
108
109			/* sanitize post */
110
111			return
112			[
113			'language' => $specialFilter->sanitize($this->_request->getPost('language')),
114			'template' => $specialFilter->sanitize($this->_request->getPost('template')),
115			'title' => $this->_request->getPost('title'),
116			'author' => $this->_request->getPost('author'),
117			'copyright' => $this->_request->getPost('copyright'),
118			'description' => $this->_request->getPost('description'),
119			'keywords' => $this->_request->getPost('keywords'),
120			'robots' => $this->_request->getPost('robots'),
121			'email' => $emailFilter->sanitize($this->_request->getPost('email')),
122			'subject' => $this->_request->getPost('subject'),
123			'notification' => $numberFilter->sanitize($this->_request->getPost('notification')),
124			'charset' => $this->_request->getPost('charset'),
125			'divider' => $this->_request->getPost('divider'),
126			'zone' => $this->_request->getPost('zone'),
127			'time' => $this->_request->getPost('time'),
128			'date' => $this->_request->getPost('date'),
129			'homepage' => $this->_request->getPost('homepage'),
130			'limit' => $numberFilter->sanitize($this->_request->getPost('limit')),
131			'order' => $specialFilter->sanitize($this->_request->getPost('order')),
132			'pagination' => $numberFilter->sanitize($this->_request->getPost('pagination')),
133			'moderation' => $numberFilter->sanitize($this->_request->getPost('moderation')),
134			'registration' => $numberFilter->sanitize($this->_request->getPost('registration')),
135			'verification' => $numberFilter->sanitize($this->_request->getPost('verification')),
136			'recovery' => $numberFilter->sanitize($this->_request->getPost('recovery')),
137			'captcha' => $numberFilter->sanitize($this->_request->getPost('captcha'))
138			];
139			}
140
141			/**
142			* validate the post
143			*
144			* @since 4.0.0
145			*
146			* @param array $postArray array of the post
147			*
148			* @return array
149			*/
150
151			protected function _validatePost(array $postArray = []) : array
152			{
153			$validateArray = [];
154
155			/* validate post */
156
157			if (!$postArray['charset'] \|\| !$postArray['limit'])
158			{
159			$validateArray[] = $this->_language->get('input_empty');
160			}
161			return $validateArray;
162			}
163
164			/**
165			* update the setting
166			*
167			* @since 4.0.0
168			*
169			* @param array $updateArray array of the update
170			*
171			* @return bool
172			*/
173
174			protected function _update(array $updateArray = []) : bool
175			{
176			$settingModel = new Admin\Model\Setting();
177			return $settingModel->updateByArray($updateArray);
178			}
179
180			/**
181			* get error route
182			*
183			* @since 4.1.0
184			*
185			* @return string
186			*/
187
188			protected function _getErrorRoute() : string
189			{
190			if ($this->_registry->get('settingsEdit'))
191			{
192			return 'admin/edit/settings';
193			}
194			return 'admin';
195			}
196			}
197

redaxscript / redaxscript

Push — master ( 113b98...ac9af8 )

includes/Admin/Controller/Setting.php (1 issue)

Showing only issues like (Show All)

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like