Conditions | 1 |
Paths | 1 |
Total Lines | 54 |
Lines | 0 |
Ratio | 0 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
56 | public function testBehaviour() |
||
57 | { |
||
58 | /* prepare */ |
||
59 | |||
60 | $formElement = $this->_driver->findElement(WebDriverBy::tagName('form')); |
||
61 | $dbHostElement = $formElement->findElement(WebDriverBy::id('db-host')); |
||
62 | $dbTypeElement = $formElement->findElement(WebDriverBy::id('db-type')); |
||
63 | $dbNameElement = $formElement->findElement(WebDriverBy::id('db-name')); |
||
64 | $dbUserElement = $formElement->findElement(WebDriverBy::id('db-user')); |
||
65 | $dbPasswordElement = $formElement->findElement(WebDriverBy::id('db-password')); |
||
66 | $dbPrefixElement = $formElement->findElement(WebDriverBy::id('db-prefix')); |
||
67 | $adminNameElement = $formElement->findElement(WebDriverBy::id('admin-name')); |
||
68 | $adminUserElement = $formElement->findElement(WebDriverBy::id('admin-user')); |
||
69 | $adminPasswordElement = $formElement->findElement(WebDriverBy::id('admin-password')); |
||
70 | $adminEmailElement = $formElement->findElement(WebDriverBy::id('admin-email')); |
||
71 | $labelAccountElement = $formElement->findElement(WebDriverBy::cssSelector('[for*="Account"]')); |
||
72 | |||
73 | /* setup */ |
||
74 | |||
75 | $dbTypeSelect = new WebDriverSelect($dbTypeElement); |
||
76 | |||
77 | /* compare */ |
||
78 | |||
79 | $this->assertFalse($adminNameElement->isDisplayed()); |
||
80 | $this->assertFalse($adminUserElement->isDisplayed()); |
||
81 | $this->assertFalse($adminPasswordElement->isDisplayed()); |
||
82 | $this->assertFalse($adminEmailElement->isDisplayed()); |
||
83 | |||
84 | /* setup and compare */ |
||
85 | |||
86 | $dbTypeSelect->selectByValue('sqlite'); |
||
87 | $this->assertTrue($dbHostElement->isDisplayed()); |
||
88 | $this->assertFalse($dbNameElement->isDisplayed()); |
||
89 | $this->assertFalse($dbUserElement->isDisplayed()); |
||
90 | $this->assertFalse($dbPasswordElement->isDisplayed()); |
||
91 | $this->assertTrue($dbPrefixElement->isDisplayed()); |
||
92 | |||
93 | /* setup and compare */ |
||
94 | |||
95 | $dbTypeSelect->selectByValue('mysql'); |
||
96 | $this->assertTrue($dbHostElement->isDisplayed()); |
||
97 | $this->assertTrue($dbNameElement->isDisplayed()); |
||
98 | $this->assertTrue($dbUserElement->isDisplayed()); |
||
99 | $this->assertTrue($dbPasswordElement->isDisplayed()); |
||
100 | $this->assertTrue($dbPrefixElement->isDisplayed()); |
||
101 | |||
102 | /* setup and compare */ |
||
103 | |||
104 | $labelAccountElement->click(); |
||
105 | $this->assertTrue($adminNameElement->isDisplayed()); |
||
106 | $this->assertTrue($adminUserElement->isDisplayed()); |
||
107 | $this->assertTrue($adminPasswordElement->isDisplayed()); |
||
108 | $this->assertTrue($adminEmailElement->isDisplayed()); |
||
109 | } |
||
110 | |||
151 |