Access::validate() - Code Metrics - redaxscript/redaxscript - Measure and Improve Code Quality continuously with Scrutinizer

Access::validate() A
last analyzed 2021-05-30 09:27 UTC

↳ Parent: Access

Complexity

Conditions	3
Paths	3

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	4
CRAP Score	3

Importance

Changes

Metric	Value
dl	0
loc	6
c	0
b	0
f	0
ccs	4
cts	4
cp	1
rs	10
cc	3
nc	3
nop	2
crap	3

<?php
namespace Redaxscript\Validator;

use function array_intersect;
use function in_array;
use function json_decode;

/**
 * children class to validate access again group
 *
 * @since 2.2.0
 *
 * @package Redaxscript
 * @category Validator
 * @author Henry Ruhs
 * @author Sven Weingartner
 */

class Access implements ValidatorInterface
{
	/**
	 * validate the access
	 *
	 * @since 4.0.0
	 *
	 * @param string $access access to be validated
	 * @param string $groups groups of the user
	 *
	 * @return bool
	 */

	public function validate(string $access = null, string $groups = null) : bool
	{
		$accessArray = (array)json_decode($access);
		$groupArray = (array)json_decode($groups);
		return !$access || in_array(1, $groupArray) || array_intersect($accessArray, $groupArray);
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
	}
}


1		<?php
2		namespace Redaxscript\Validator;
3
4		use function array_intersect;
5		use function in_array;
6		use function json_decode;
7
8		/**
9		* children class to validate access again group
10		*
11		* @since 2.2.0
12		*
13		* @package Redaxscript
14		* @category Validator
15		* @author Henry Ruhs
16		* @author Sven Weingartner
17		*/
18
19		class Access implements ValidatorInterface
20		{
21		/**
22		* validate the access
23		*
24		* @since 4.0.0
25		*
26		* @param string $access access to be validated
27		* @param string $groups groups of the user
28		*
29		* @return bool
30		*/
31
32	4	public function validate(string $access = null, string $groups = null) : bool
33		{
34	4	$accessArray = (array)json_decode($access);
35	4	$groupArray = (array)json_decode($groups);
36	4	return !$access \|\| in_array(1, $groupArray) \|\| array_intersect($accessArray, $groupArray);
		0 ignored issues – show Bug Best Practice introduced 2018-08-01 20:25 UTC by Report Bug Copy Issue Report The expression `$access` of type `null\|string` is loosely compared to `false`; this is ambiguous if the string can be empty. You might want to explicitly use `=== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
37		}
38		}
39

redaxscript / redaxscript

Access::validate() A last analyzed 2021-05-30 09:27 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like

Access::validate() A
last analyzed 2021-05-30 09:27 UTC