RApiHalHelperSiteContent::save()

Complexity

Conditions	4
Paths	6

Size

Total Lines	28
Code Lines	19

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
	public function save($data)
	{
		if (version_compare(JVERSION, '3.0', 'lt')) {
			JTable::addIncludePath(JPATH_PLATFORM . 'joomla/database/table');
		}
		
		$data = (object) $data;
		$article = JTable::getInstance('content');
		$article->title            = $data->title;

The property title does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

//		$article->alias            = JFilterOutput::stringURLSafe(time());
		$article->alias            = JFilterOutput::stringURLSafe($data->title);
		$article->introtext        = '<p>'.$data->description.'</p>';
		$article->created          = JFactory::getDate()->toSQL();;
		$article->created_by_alias = $data->user;

The property created_by_alias does not seem to exist on JTable.

		$article->state            = 1;
		$article->access           = 1;

The property access does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

		$article->metadata         = '{"page_title":"'.$data->title.'","author":"'.$data->user.'","robots":""}';
		$article->language         = '*';

The property language does not seem to exist on JTable.

//		$article->catid            = 1;
		
		if (!$article->check()) {
			throw new Exception($article->getError());

The function JObject::getError() has been deprecated: 12.3 JError has been deprecated

			return FALSE;

return FALSE is not reachable.

		}
		
		if (!$article->store(TRUE)) {
			throw new Exception($article->getError());

The function JObject::getError() has been deprecated: 12.3 JError has been deprecated

			return FALSE;
		}