RApiHalHelperSiteContent

Complexity

Total Complexity

4

Size/Duplication

Total Lines	37
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	save()	0	28	4

<?php
/**
 * @package     Redcore
 * @subpackage  Api
 *
 * @copyright   Copyright (C) 2008 - 2021 redWEB.dk. All rights reserved.
 * @license     GNU General Public License version 2 or later, see LICENSE.
 */

defined('JPATH_BASE') or die;

/**
 * Api Helper class for overriding default methods
 *
 * @package     Redcore
 * @subpackage  Api Helper
 * @since       1.8
 */
class RApiHalHelperSiteContent
{
	/**
	 * Service for creating content.
	 *
	 * @param   string  $data  content
	 *
	 * @return  boolean         True on success. False otherwise.
	 */
	public function save($data)
	{
		if (version_compare(JVERSION, '3.0', 'lt')) {
			JTable::addIncludePath(JPATH_PLATFORM . 'joomla/database/table');
		}
		
		$data = (object) $data;
		$article = JTable::getInstance('content');
		$article->title            = $data->title;

The property title does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

//		$article->alias            = JFilterOutput::stringURLSafe(time());
		$article->alias            = JFilterOutput::stringURLSafe($data->title);
		$article->introtext        = '<p>'.$data->description.'</p>';
		$article->created          = JFactory::getDate()->toSQL();;
		$article->created_by_alias = $data->user;

The property created_by_alias does not seem to exist on JTable.

		$article->state            = 1;
		$article->access           = 1;

The property access does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

		$article->metadata         = '{"page_title":"'.$data->title.'","author":"'.$data->user.'","robots":""}';
		$article->language         = '*';

The property language does not seem to exist on JTable.

//		$article->catid            = 1;
		
		if (!$article->check()) {
			throw new Exception($article->getError());

The function JObject::getError() has been deprecated: 12.3 JError has been deprecated

			return FALSE;

return FALSE is not reachable.

		}
		
		if (!$article->store(TRUE)) {
			throw new Exception($article->getError());

The function JObject::getError() has been deprecated: 12.3 JError has been deprecated

			return FALSE;
		}
	}
}