recca0120 / laravel-elfinder

src/Connector.php

Doc Comments +1 added lines, -1 removed lines

@@ -49,7 +49,7 @@
      *
      * @param array $data
      *
-     * @return mixed
+     * @return StreamedResponse
      */
     protected function output(array $data)
     {

Unused Use Statements +1 added lines, -1 removed lines

@@ -2,8 +2,8 @@
 
 namespace Recca0120\Elfinder;
 
-use elFinderConnector;
 use Symfony\Component\HttpFoundation\StreamedResponse;
+use elFinderConnector;
 
 class Connector extends elFinderConnector
 {

src/ElfinderServiceProvider.php

Unused Use Statements +2 added lines, -2 removed lines

@@ -2,10 +2,10 @@
 
 namespace Recca0120\Elfinder;
 
-use elFinder;
-use Illuminate\Support\Arr;
 use Illuminate\Routing\Router;
+use Illuminate\Support\Arr;
 use Illuminate\Support\ServiceProvider;
+use elFinder;
 
 class ElfinderServiceProvider extends ServiceProvider
 {

src/Http/Controllers/ElfinderController.php

Doc Comments -1 removed lines

@@ -46,7 +46,6 @@
     /**
      * connector.
      *
-     * @param \Recca0120\Elfinder\Connector $elfinder
      * @return mixed
      */
     public function connector(Connector $connector)

Unused Use Statements +3 added lines, -3 removed lines

@@ -2,11 +2,11 @@
 
 namespace Recca0120\Elfinder\Http\Controllers;
 
+use Illuminate\Contracts\Routing\ResponseFactory;
+use Illuminate\Filesystem\Filesystem;
 use Illuminate\Http\Request;
-use Recca0120\Elfinder\Connector;
 use Illuminate\Routing\Controller;
-use Illuminate\Filesystem\Filesystem;
-use Illuminate\Contracts\Routing\ResponseFactory;
+use Recca0120\Elfinder\Connector;
 
 class ElfinderController extends Controller
 {

src/Options.php

Unused Use Statements +4 added lines, -4 removed lines

@@ -2,12 +2,12 @@
 
 namespace Recca0120\Elfinder;
 
-use Closure;
 use ArrayObject;
-use Illuminate\Support\Arr;
-use Illuminate\Http\Request;
-use Illuminate\Filesystem\Filesystem;
+use Closure;
 use Illuminate\Contracts\Routing\UrlGenerator;
+use Illuminate\Filesystem\Filesystem;
+use Illuminate\Http\Request;
+use Illuminate\Support\Arr;
 
 class Options extends ArrayObject
 {

lib/elFinderVolumeBox.class.php

Doc Comments +11 added lines, -18 removed lines

@@ -284,7 +284,6 @@ 
      * process of on netunmount
      * Drop `box` & rm thumbs.
      *
-     * @param array $options
      *
      * @return bool
      */
@@ -393,11 +392,9 @@ 
     /**
      * Obtains a new access token from OAuth. This token is valid for one hour.
      *
-     * @param string $clientSecret The Box client secret
+     * @param string $client_secret The Box client secret
      * @param string $code         The code returned by Box after
      *                             successful log in
-     * @param string $redirectUri  Must be the same as the redirect URI passed
-     *                             to LoginUrl
      *
      * @throws \Exception Thrown if this Client instance's clientId is not set
      * @throws \Exception Thrown if the redirect URI of this Client instance's
@@ -449,7 +446,7 @@ 
     /**
      * Get token and auto refresh.
      *
-     * @return true|string error message
+     * @return boolean error message
      */
     protected function _bd_refreshToken()
     {
@@ -533,8 +530,8 @@ 
     /**
      * Creates a base cURL object which is compatible with the Box.com API.
      *
-     * @param string $path The path of the API call (eg. /folders/0)
      *
+     * @param string $url
      * @return resource A compatible cURL object
      */
     protected function _bd_fetch($url, $contents = false)
@@ -582,7 +579,7 @@ 
      *
      * @param resource    $curl
      * @param bool|string $decodeOrParent
-     * @param array       $headers
+     * @param string[]       $headers
      *
      * @throws \Exception
      *
@@ -636,7 +633,6 @@ 
     /**
      * Drive query and fetchAll.
      *
-     * @param string $sql
      *
      * @return bool|array
      */
@@ -740,7 +736,6 @@ 
      * Get thumbnail from Box.com.
      *
      * @param string $path
-     * @param string $size
      *
      * @return string | boolean
      */
@@ -763,6 +758,7 @@ 
      * Remove item.
      *
      * @param string $path file path
+     * @param string $type
      *
      * @return bool
      **/
@@ -979,7 +975,7 @@ 
      * @param string $dst  destination dir path
      * @param string $name new file name (optionaly)
      *
-     * @return string|false
+     * @return string|boolean
      *
      * @author Dmitry (dio) Levashov
      * @author Naoki Sawada
@@ -1038,7 +1034,6 @@ 
      * Create thumnbnail and return it's URL on success.
      *
      * @param string $path file path
-     * @param string $mime file mime type
 
      * @return string|false
      *
@@ -1395,7 +1390,6 @@ 
      * Open file and return file pointer.
      *
      * @param string $path  file path
-     * @param bool   $write open file for writing
      *
      * @return resource|false
      *
@@ -1421,7 +1415,7 @@ 
      *
      * @param resource $fp file pointer
      *
-     * @return bool
+     * @return boolean|null
      *
      * @author Dmitry (dio) Levashov
      **/
@@ -1505,7 +1499,7 @@ 
      * @param string $targetDir target directory path
      * @param string $name      new file name
      *
-     * @return string|false
+     * @return string|boolean
      *
      * @author Dmitry (dio) Levashov
      **/
@@ -1552,7 +1546,7 @@ 
      * Return new file path or false.
      *
      * @param string $source source file path
-     * @param string $target target dir path
+     * @param string $targetDir target dir path
      * @param string $name   file name
      *
      * @return string|bool
@@ -1630,7 +1624,6 @@ 
      * Return new file path or false on error.
      *
      * @param resource $fp   file pointer
-     * @param string   $dir  target dir path
      * @param string   $name file name
      * @param array    $stat file stat (required by some virtual fs)
      *
@@ -1729,7 +1722,7 @@ 
      * @param string $path    file path
      * @param string $content new file content
      *
-     * @return bool
+     * @return string|boolean
      *
      * @author Dmitry (dio) Levashov
      **/
@@ -1791,7 +1784,7 @@ 
      *
      * @param string $path file/dir path
      *
-     * @return bool
+     * @return boolean|null
      *
      * @author Dmitry (dio) Levashov
      **/

lib/elFinderVolumeDropbox2.class.php

Doc Comments +7 added lines, -12 removed lines

@@ -295,7 +295,6 @@ 
      * process of on netunmount
      * Drop `Dropbox` & rm thumbs.
      *
-     * @param array $options
      *
      * @return bool
      */
@@ -402,7 +401,7 @@ 
      *
      * @param string $path
      *
-     * @return array
+     * @return string[]
      */
     protected function _db_splitPath($path)
     {
@@ -489,7 +488,6 @@ 
      * Get thumbnail from Dropbox.
      *
      * @param string $path
-     * @param string $size
      *
      * @return string | boolean
      */
@@ -506,7 +504,7 @@ 
      * Join dir name and file name(display name) and retur full path.
      *
      * @param unknown $dir
-     * @param unknown $displayName
+     * @param string $displayName
      *
      * @return string
      */
@@ -785,7 +783,6 @@ 
      * Create thumnbnail and return it's URL on success.
      *
      * @param string $path file path
-     * @param string $mime file mime type
      *
      * @return string|false
      *
@@ -1112,7 +1109,6 @@ 
      * Open file and return file pointer.
      *
      * @param string $path  file path
-     * @param bool   $write open file for writing
      *
      * @return resource|false
      *
@@ -1142,7 +1138,7 @@ 
      *
      * @param resource $fp file pointer
      *
-     * @return bool
+     * @return boolean|null
      *
      * @author Naoki Sawada
      **/
@@ -1229,7 +1225,7 @@ 
      * Return new file path or false.
      *
      * @param string $source source file path
-     * @param string $target target dir path
+     * @param string $targetDir target dir path
      * @param string $name   file name
      *
      * @return string|bool
@@ -1286,7 +1282,6 @@ 
      * Return new file path or false on error.
      *
      * @param resource $fp   file pointer
-     * @param string   $dir  target dir path
      * @param string   $name file name
      * @param array    $stat file stat (required by some virtual fs)
      *
@@ -1352,7 +1347,7 @@ 
      * @param string $path    file path
      * @param string $content new file content
      *
-     * @return bool
+     * @return boolean|string
      *
      * @author Naoki Sawada
      **/
@@ -1414,7 +1409,7 @@ 
      *
      * @param string $path file/dir path
      *
-     * @return bool
+     * @return boolean|null
      *
      * @author Dmitry (dio) Levashov
      **/
@@ -1462,7 +1457,7 @@ 
      *
      * @param string $path
      *
-     * @return object Dropbox metadata
+     * @return string Dropbox metadata
      */
     private function _db_getFile($path, $fields = '')
     {

lib/elFinderVolumeGoogleDrive.class.php

Doc Comments +5 added lines, -12 removed lines

@@ -327,7 +327,6 @@ 
      * process of on netunmount
      * Drop `googledrive` & rm thumbs.
      *
-     * @param array $options
      *
      * @return bool
      */
@@ -582,7 +581,6 @@ 
     /**
      * Get ID based path from item ID.
      *
-     * @param string $path
      */
     protected function _gd_getMountPaths($id)
     {
@@ -686,7 +684,6 @@ 
      * Get thumbnail from GoogleDrive.com.
      *
      * @param string $path
-     * @param string $size
      *
      * @return string | boolean
      */
@@ -1204,7 +1201,6 @@ 
      * Create thumnbnail and return it's URL on success.
      *
      * @param string $path file path
-     * @param string $mime file mime type
      *
      * @return string|false
      *
@@ -1518,7 +1514,6 @@ 
      * Open file and return file pointer.
      *
      * @param string $path  file path
-     * @param bool   $write open file for writing
      *
      * @return resource|false
      *
@@ -1562,7 +1557,7 @@ 
      *
      * @param resource $fp file pointer
      *
-     * @return bool
+     * @return boolean|null
      *
      * @author Dmitry (dio) Levashov
      **/
@@ -1685,7 +1680,7 @@ 
      * Return new file path or false.
      *
      * @param string $source source file path
-     * @param string $target target dir path
+     * @param string $targetDir target dir path
      * @param string $name   file name
      *
      * @return string|bool
@@ -1764,7 +1759,6 @@ 
      * Return new file path or false on error.
      *
      * @param resource $fp   file pointer
-     * @param string   $dir  target dir path
      * @param string   $name file name
      * @param array    $stat file stat (required by some virtual fs)
      *
@@ -1897,7 +1891,7 @@ 
      *
      * @param string $path file path
      *
-     * @return string|false
+     * @return boolean|string
      *
      * @author Dmitry (dio) Levashov
      **/
@@ -1925,7 +1919,7 @@ 
      * @param string $path    file path
      * @param string $content new file content
      *
-     * @return bool
+     * @return string|boolean
      *
      * @author Dmitry (dio) Levashov
      **/
@@ -1987,7 +1981,7 @@ 
      *
      * @param string $path file/dir path
      *
-     * @return bool
+     * @return boolean|null
      *
      * @author Dmitry (dio) Levashov
      **/
@@ -2033,7 +2027,6 @@ 
     /**
      * Drive query and fetchAll.
      *
-     * @param string $sql
      *
      * @return bool|array
      */

lib/elFinderVolumeOneDrive.class.php

Doc Comments +12 added lines, -16 removed lines

@@ -294,7 +294,6 @@ 
      * process of on netunmount
      * Drop `onedrive` & rm thumbs.
      *
-     * @param array $options
      *
      * @return bool
      */
@@ -382,11 +381,9 @@ 
     /**
      * Obtains a new access token from OAuth. This token is valid for one hour.
      *
-     * @param string $clientSecret The OneDrive client secret
+     * @param string $client_secret The OneDrive client secret
      * @param string $code         The code returned by OneDrive after
      *                             successful log in
-     * @param string $redirectUri  Must be the same as the redirect URI passed
-     *                             to LoginUrl
      *
      * @throws \Exception Thrown if this Client instance's clientId is not set
      * @throws \Exception Thrown if the redirect URI of this Client instance's
@@ -456,7 +453,7 @@ 
     /**
      * Get token and auto refresh.
      *
-     * @return true|Exception
+     * @return boolean
      */
     protected function _od_refreshToken()
     {
@@ -563,6 +560,7 @@ 
     /**
      * Creates a base cURL object which is compatible with the OneDrive API.
      *
+     * @param string $url
      * @return resource A compatible cURL object
      */
     protected function _od_prepareCurl($url = null)
@@ -621,7 +619,6 @@ 
     /**
      * Drive query and fetchAll.
      *
-     * @param string $sql
      *
      * @return object|array
      */
@@ -716,7 +713,7 @@ 
      *
      * @param string $path
      *
-     * @return array|object onedrive metadata
+     * @return string onedrive metadata
      */
     protected function _od_getFileRaw($path)
     {
@@ -734,7 +731,6 @@ 
      * Get thumbnail from OneDrive.com.
      *
      * @param string $path
-     * @param string $size
      *
      * @return string | boolean
      */
@@ -854,6 +850,9 @@ 
         $this->disabled[] = 'extract';
     }
 
+    /**
+     * @param string $path
+     */
     protected function isNameExists($path)
     {
         list($pid, $name) = $this->_od_splitPath($path);
@@ -907,7 +906,7 @@ 
      * @param string $dst  destination dir path
      * @param string $name new file name (optionaly)
      *
-     * @return string|false
+     * @return boolean
      *
      * @author Dmitry (dio) Levashov
      * @author Naoki Sawada
@@ -974,7 +973,6 @@ 
      * Create thumnbnail and return it's URL on success.
      *
      * @param string $path file path
-     * @param string $mime file mime type
 
      * @return string|false
      *
@@ -1296,7 +1294,6 @@ 
      * Open file and return file pointer.
      *
      * @param string $path  file path
-     * @param bool   $write open file for writing
      *
      * @return resource|false
      *
@@ -1322,7 +1319,7 @@ 
      *
      * @param resource $fp file pointer
      *
-     * @return bool
+     * @return boolean|null
      *
      * @author Dmitry (dio) Levashov
      **/
@@ -1494,7 +1491,7 @@ 
      * Return new file path or false.
      *
      * @param string $source source file path
-     * @param string $target target dir path
+     * @param string $targetDir target dir path
      * @param string $name   file name
      *
      * @return string|bool
@@ -1589,7 +1586,6 @@ 
      * Return new file path or false on error.
      *
      * @param resource $fp   file pointer
-     * @param string   $dir  target dir path
      * @param string   $name file name
      * @param array    $stat file stat (required by some virtual fs)
      *
@@ -1680,7 +1676,7 @@ 
      * @param string $path    file path
      * @param string $content new file content
      *
-     * @return bool
+     * @return string|boolean
      *
      * @author Dmitry (dio) Levashov
      **/
@@ -1742,7 +1738,7 @@ 
      *
      * @param string $path file/dir path
      *
-     * @return bool
+     * @return boolean|null
      *
      * @author Dmitry (dio) Levashov
      **/

lib/libs/GdBmp.php

Doc Comments +7 added lines, -1 removed lines

@@ -61,7 +61,7 @@ 
  *
  * 以下のものは非対応
  *   BITMAPV4HEADER と BITMAPV5HEADER に含まれる色空間に関する様々な機能
- * @param $filename_or_stream_or_binary
+ * @param string $filename_or_stream_or_binary
  * @return bool|resource
  */
 function imagecreatefrombmp($filename_or_stream_or_binary)
@@ -99,6 +99,9 @@ 
         return $bmp;
     }
 
+    /**
+     * @param string $str
+     */
     public static function loadFromString($str)
     {
         //data scheme より古いバージョンから対応しているようなので php://memory を使う
@@ -126,6 +129,9 @@ 
         return $bmp;
     }
 
+    /**
+     * @param resource $stream
+     */
     public static function loadFromStream($stream)
     {
         $buf = fread($stream, 14); //2+4+2+2+4