MediaTypeGuard::clientRequestMustHaveContentTypeHeader() - Code Metrics - realpage/json-api-for-lumen - Measure and Improve Code Quality continuously with Scrutinizer

clientRequestMustHaveContentTypeHeader() A
last analyzed 2018-01-05 20:40 UTC

↳ Parent: MediaTypeGuard

Complexity

Conditions	2
Paths	2

Size

Total Lines	5
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	3
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	5
ccs	3
cts	3
cp	1
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	3
nc	2
nop	1
crap	2

<?php

namespace RealPage\JsonApi;

use Illuminate\Http\Request;

class MediaTypeGuard
{
    protected $contentType;

    public function __construct(string $contentType, string $acceptHeaderPolicy)
    {
        $this->contentType = $contentType;
        $this->acceptHeaderPolicy = $acceptHeaderPolicy;
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    public function getContentType(): string
    {
        return $this->contentType;
    }

    public function getAcceptHeaderPolicy(): string
    {
        return $this->acceptHeaderPolicy;
    }

    public function validateExistingContentType(Request $request): bool
    {
        return str_is($this->getContentType(), $request->header('Accept')) || str_is('', $request->header('Accept'));

    }

    public function clientRequestMustHaveContentTypeHeader(Request $request)
    {
        $method = $request->method();
        return $method === 'POST' || $method === 'PATCH';
    }

    public function contentTypeIsValid(string $contentType): bool
    {
        return str_is($this->getContentType(), $contentType);
    }

    public function hasCorrectHeadersForData(Request $request): bool
    {
        if ($this->clientRequestMustHaveContentTypeHeader($request)) {
            return $request->hasHeader('Content-Type') && $this->contentTypeIsValid($request->header('Content-Type'));

        }
        return true;
    }

    public function hasCorrectlySetAcceptHeader(Request $request): bool
    {
        if ($this->acceptHeaderPolicy === 'ignore') {
            return true;
        }

        $accept = $request->header('Accept');
        if (empty($accept)) {
            return $this->acceptHeaderPolicy !== 'require';
        }

        if ('*/*' === $accept) {
            return true;
        }

        return substr_count($accept, $this->getContentType()) > substr_count($accept, $this->getContentType() . ';');
    }
}


1		<?php
2
3		namespace RealPage\JsonApi;
4
5		use Illuminate\Http\Request;
6
7		class MediaTypeGuard
8		{
9		protected $contentType;
10
11	18	public function __construct(string $contentType, string $acceptHeaderPolicy)
12		{
13	18	$this->contentType = $contentType;
14	18	$this->acceptHeaderPolicy = $acceptHeaderPolicy;
		0 ignored issues – show Bug introduced 2017-05-19 10:44 UTC by Report Bug Copy Issue Report The property `acceptHeaderPolicy` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
15	18	}
16
17	15	public function getContentType(): string
18		{
19	15	return $this->contentType;
20		}
21
22	3	public function getAcceptHeaderPolicy(): string
23		{
24	3	return $this->acceptHeaderPolicy;
25		}
26
27	3	public function validateExistingContentType(Request $request): bool
28		{
29	3	return str_is($this->getContentType(), $request->header('Accept')) \|\| str_is('', $request->header('Accept'));
		0 ignored issues – show Bug introduced 2017-02-27 16:56 UTC by Report Bug Copy Issue Report It seems like `$request->header('Accept')` targeting `Illuminate\Http\Concerns...actsWithInput::header()` can also be of type `array`; however, `str_is()` does only seem to accept `string`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
30		}
31
32	6	public function clientRequestMustHaveContentTypeHeader(Request $request)
33		{
34	6	$method = $request->method();
35	6	return $method === 'POST' \|\| $method === 'PATCH';
36		}
37
38	6	public function contentTypeIsValid(string $contentType): bool
39		{
40	6	return str_is($this->getContentType(), $contentType);
41		}
42
43	3	public function hasCorrectHeadersForData(Request $request): bool
44		{
45	3	if ($this->clientRequestMustHaveContentTypeHeader($request)) {
46	3	return $request->hasHeader('Content-Type') && $this->contentTypeIsValid($request->header('Content-Type'));
		0 ignored issues – show Bug introduced 2017-06-14 13:53 UTC by Report Bug Copy Issue Report It seems like `$request->header('Content-Type')` targeting `Illuminate\Http\Concerns...actsWithInput::header()` can also be of type `array`; however, `RealPage\JsonApi\MediaTy...d::contentTypeIsValid()` does only seem to accept `string`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
47		}
48	3	return true;
49		}
50
51	3	public function hasCorrectlySetAcceptHeader(Request $request): bool
52		{
53	3	if ($this->acceptHeaderPolicy === 'ignore') {
54	3	return true;
55		}
56
57	3	$accept = $request->header('Accept');
58	3	if (empty($accept)) {
59	3	return $this->acceptHeaderPolicy !== 'require';
60		}
61
62	3	if ('/' === $accept) {
63	3	return true;
64		}
65
66	3	return substr_count($accept, $this->getContentType()) > substr_count($accept, $this->getContentType() . ';');
67		}
68		}
69

realpage / json-api-for-lumen

clientRequestMustHaveContentTypeHeader() A last analyzed 2018-01-05 20:40 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like

clientRequestMustHaveContentTypeHeader() A
last analyzed 2018-01-05 20:40 UTC