ScalarValueBuilder::match() - Code Metrics - Inspection of "Add basic interpreter implementation" - railt/sdl - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — master ( b7ab7b...94ee03 )

by Kirill

created 2018-10-02 21:32 UTC

ScalarValueBuilder::match() A

↳ Parent: ScalarValueBuilder

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
cc	1
nc	1
nop	1
dl	0
loc	4
ccs	0
cts	4
cp	0
crap	2
rs	10
c	0
b	0
f	0

<?php
/**
 * This file is part of Railt package.
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */
declare(strict_types=1);

namespace Railt\SDL\Frontend\Builder\Value;

use Railt\Parser\Ast\RuleInterface;
use Railt\SDL\Frontend\AST\Value\AstValueInterface;
use Railt\SDL\Frontend\Builder\BaseBuilder;
use Railt\SDL\Frontend\Context\ContextInterface;
use Railt\SDL\IR\SymbolTable\Value;
use Railt\SDL\IR\Type;

/**
 * Class ScalarValueBuilder
 */
class ScalarValueBuilder extends BaseBuilder
{
    /**
     * @var string[]
     */
    private const SCALARS = [
        'NumberValue',
        'StringValue',
        'NullValue',
    ];

    /**
     * @param RuleInterface $rule
     * @return bool
     */
    public function match(RuleInterface $rule): bool
    {
        return \in_array($rule->getName(), self::SCALARS, true);
    }

    /**
     * @param ContextInterface $ctx
     * @param RuleInterface|AstValueInterface $rule
     * @return mixed|Value
     */
    public function reduce(ContextInterface $ctx, RuleInterface $rule)
    {
        \assert($rule instanceof AstValueInterface);

        switch ($rule->getName()) {
            case 'NumberValue':
                $value = $rule->toPrimitive();
                return new Value($value, \is_int($value) ? Type::int() : Type::float());
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

            case 'StringValue':
                return new Value($rule->toPrimitive(), Type::string());


            case 'NullValue':
                return new Value(null, Type::null());

        }
    }
}


1			<?php
2			/**
3			* This file is part of Railt package.
4			*
5			* For the full copyright and license information, please view the LICENSE
6			* file that was distributed with this source code.
7			*/
8			declare(strict_types=1);
9
10			namespace Railt\SDL\Frontend\Builder\Value;
11
12			use Railt\Parser\Ast\RuleInterface;
13			use Railt\SDL\Frontend\AST\Value\AstValueInterface;
14			use Railt\SDL\Frontend\Builder\BaseBuilder;
15			use Railt\SDL\Frontend\Context\ContextInterface;
16			use Railt\SDL\IR\SymbolTable\Value;
17			use Railt\SDL\IR\Type;
18
19			/**
20			* Class ScalarValueBuilder
21			*/
22			class ScalarValueBuilder extends BaseBuilder
23			{
24			/**
25			* @var string[]
26			*/
27			private const SCALARS = [
28			'NumberValue',
29			'StringValue',
30			'NullValue',
31			];
32
33			/**
34			* @param RuleInterface $rule
35			* @return bool
36			*/
37			public function match(RuleInterface $rule): bool
38			{
39			return \in_array($rule->getName(), self::SCALARS, true);
40			}
41
42			/**
43			* @param ContextInterface $ctx
44			* @param RuleInterface\|AstValueInterface $rule
45			* @return mixed\|Value
46			*/
47			public function reduce(ContextInterface $ctx, RuleInterface $rule)
48			{
49			\assert($rule instanceof AstValueInterface);
50
51			switch ($rule->getName()) {
52			case 'NumberValue':
53			$value = $rule->toPrimitive();
54			return new Value($value, \is_int($value) ? Type::int() : Type::float());
			0 ignored issues – show Bug introduced 2018-10-02 21:35 UTC by Report Bug Copy Issue Report It seems like `\is_int($value) ? \Railt...lt\SDL\IR\Type::float()` can also be of type `object<Railt\SDL\IR\Type...untimeTypeConstructors>`; however, `Railt\SDL\IR\SymbolTable\Value::__construct()` does only seem to accept `object<Railt\SDL\IR\Type\TypeInterface>`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
55
56			case 'StringValue':
57			return new Value($rule->toPrimitive(), Type::string());
			0 ignored issues – show Bug introduced 2018-10-02 21:35 UTC by Report Bug Copy Issue Report It seems like `\Railt\SDL\IR\Type::string()` targeting `Railt\SDL\IR\Type\TypeCo...eConstructors::string()` can also be of type `object<Railt\SDL\IR\Type...untimeTypeConstructors>`; however, `Railt\SDL\IR\SymbolTable\Value::__construct()` does only seem to accept `object<Railt\SDL\IR\Type\TypeInterface>`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
58
59			case 'NullValue':
60			return new Value(null, Type::null());
			0 ignored issues – show Bug introduced 2018-10-02 21:35 UTC by Report Bug Copy Issue Report It seems like `\Railt\SDL\IR\Type::null()` targeting `Railt\SDL\IR\Type\TypeCo...ypeConstructors::null()` can also be of type `object<Railt\SDL\IR\Type...untimeTypeConstructors>`; however, `Railt\SDL\IR\SymbolTable\Value::__construct()` does only seem to accept `object<Railt\SDL\IR\Type\TypeInterface>`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
61			}
62			}
63			}
64

railt / sdl

Push — master ( b7ab7b...94ee03 )

ScalarValueBuilder::match() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like