Railt\SDL\Frontend\Builder\Value\ScalarValueBuilder

Complexity

Total Complexity

6

Size/Duplication

Total Lines	42
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	4

Test Coverage

Coverage

0%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	match()	0	4	1
A	reduce()	0	16	5

<?php
/**
 * This file is part of Railt package.
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */
declare(strict_types=1);

namespace Railt\SDL\Frontend\Builder\Value;

use Railt\Parser\Ast\RuleInterface;
use Railt\SDL\Frontend\AST\Value\AstValueInterface;
use Railt\SDL\Frontend\Builder\BaseBuilder;
use Railt\SDL\Frontend\Context\ContextInterface;
use Railt\SDL\IR\SymbolTable\Value;
use Railt\SDL\IR\Type;

/**
 * Class ScalarValueBuilder
 */
class ScalarValueBuilder extends BaseBuilder
{
    /**
     * @var string[]
     */
    private const SCALARS = [
        'NumberValue',
        'StringValue',
        'NullValue',
    ];

    /**
     * @param RuleInterface $rule
     * @return bool
     */
    public function match(RuleInterface $rule): bool
    {
        return \in_array($rule->getName(), self::SCALARS, true);
    }

    /**
     * @param ContextInterface $ctx
     * @param RuleInterface|AstValueInterface $rule
     * @return mixed|Value
     */
    public function reduce(ContextInterface $ctx, RuleInterface $rule)
    {
        \assert($rule instanceof AstValueInterface);

        switch ($rule->getName()) {
            case 'NumberValue':
                $value = $rule->toPrimitive();
                return new Value($value, \is_int($value) ? Type::int() : Type::float());

It seems like \is_int($value) ? \Railt\SDL\IR\Type::int() : \Railt\SDL\IR\Type::float() can also be of type object<Railt\SDL\IR\Type\TypeConstructors\RuntimeTypeConstructors>; however, Railt\SDL\IR\SymbolTable\Value::__construct() does only seem to accept object<Railt\SDL\IR\Type\TypeInterface>, maybe add an additional type check?

            case 'StringValue':
                return new Value($rule->toPrimitive(), Type::string());

It seems like \Railt\SDL\IR\Type::string() targeting Railt\SDL\IR\Type\TypeConstructors\RuntimeTypeConstructors::string() can also be of type object<Railt\SDL\IR\Type\TypeConstructors\RuntimeTypeConstructors>; however, Railt\SDL\IR\SymbolTable\Value::__construct() does only seem to accept object<Railt\SDL\IR\Type\TypeInterface>, maybe add an additional type check?

            case 'NullValue':
                return new Value(null, Type::null());

It seems like \Railt\SDL\IR\Type::null() targeting Railt\SDL\IR\Type\TypeConstructors\RuntimeTypeConstructors::null() can also be of type object<Railt\SDL\IR\Type\TypeConstructors\RuntimeTypeConstructors>; however, Railt\SDL\IR\SymbolTable\Value::__construct() does only seem to accept object<Railt\SDL\IR\Type\TypeInterface>, maybe add an additional type check?

        }
    }
}