radowoj / yaah

tests/FieldTest.php

Unused Use Statements +1 added lines, -1 removed lines

@@ -2,7 +2,7 @@
 

 namespace Radowoj\Yaah;

 

-use PHPUnit\Framework\TestCase;

+use PHPUnit\Framework\TestCase;
 use Radowoj\Yaah\Field;

 

 class FieldTest extends TestCase

src/Auction.php

Doc Comments +1 added lines, -1 removed lines

@@ -21,7 +21,7 @@
 
     /**
      * Sets photos for auction
-     * @param array $photos array of photo file paths
+     * @param string[] $photos array of photo file paths
      */
     public function setPhotos(array $photos)
     {

tests/HelperTest.php

Unused Use Statements +1 added lines, -2 removed lines

@@ -2,8 +2,7 @@
 

 namespace Radowoj\Yaah;

 

-use PHPUnit\Framework\TestCase;

-use Radowoj\Yaah\Field;

+use PHPUnit\Framework\TestCase;
 use SoapClient;

 

 class HelperTest extends TestCase

Spacing +1 added lines, -1 removed lines

@@ -143,7 +143,7 @@
         $this->soapClient->expects($this->once())

             ->method('doSomethingNotImplementedInHelper')

             ->with(

-                $this->callback(function($params){

+                $this->callback(function($params) {

                     return array_key_exists('param1', $params)

                         && array_key_exists('webapiKey', $params)

                         && $params['param1'] == 1337

tests/ClientTest.php

Unused Use Statements +4 added lines, -5 removed lines

@@ -2,11 +2,10 @@
 

 namespace Radowoj\Yaah;

 

-use PHPUnit\Framework\TestCase;

-use Radowoj\Yaah\Config;

-use Radowoj\Yaah\Client;

-

-use SoapClient;

+use PHPUnit\Framework\TestCase;
+use Radowoj\Yaah\Config;
+use Radowoj\Yaah\Client;
+use SoapClient;
 use SoapFault;

 

 class ClientTest extends TestCase

src/Field.php

Spacing +2 added lines, -2 removed lines

@@ -201,7 +201,7 @@ 
      */
     protected function setRangeDate(array $range)
     {
-        usort($range, function($date1, $date2){
+        usort($range, function($date1, $date2) {
             return strtotime($date1) - strtotime($date2);
         });
         $this->fValues[self::VALUE_RANGE_DATE] = array_combine(
@@ -242,7 +242,7 @@ 
      */
     public function isRangeDate(array $range)
     {
-        $dates = array_filter($range, function($item){
+        $dates = array_filter($range, function($item) {
             return preg_match(self::DATE_REGEX, $item);
         });
 

src/HelperFactory/HelperFactory.php

Doc Comments +3 added lines

@@ -11,6 +11,9 @@
 {

     protected $config = null;

 

+    /**
+     * @return \SoapClient
+     */
     abstract protected function getSoapClient();

 

     public function create(array $configArray)

Unused Use Statements +2 added lines, -3 removed lines

@@ -2,10 +2,9 @@
 

 namespace Radowoj\Yaah\HelperFactory;

 

-use Radowoj\Yaah\Config;

-use Radowoj\Yaah\Client;

+use Radowoj\Yaah\Config;
+use Radowoj\Yaah\Client;
 use Radowoj\Yaah\Helper;

-use Radowoj\Yaah\Exception;

 

 abstract class HelperFactory

 {

src/Journal/Deal.php

Unused Use Statements +1 added lines, -1 removed lines

@@ -2,7 +2,7 @@
 

 namespace Radowoj\Yaah\Journal;

 

-use stdClass;

+use stdClass;
 use InvalidArgumentException;

 

 /**

Spacing +1 added lines, -1 removed lines

@@ -72,7 +72,7 @@
      */

     protected function mapFromObject(stdClass $deal)
     {
-        foreach($deal as $prop => $value) {

+        foreach ($deal as $prop => $value) {

             $this->setProperty($prop, $value);

         }
     }

examples/GetJournal.php

Spacing +1 added lines, -1 removed lines

@@ -15,7 +15,7 @@
      * Process journal entries - in this case echo details of every journal

      * item that creates a deal

      */

-    array_map(function($deal){

+    array_map(function($deal) {

         if ($deal->isTypeCreateDeal()) {

             echo "Deal {$deal->getId()} (itemId {$deal->getItemId()} - quantity {$deal->getQuantity()}) created at {$deal->getEventTime()}\n";

         }

src/Helper.php

Spacing +4 added lines, -4 removed lines

@@ -29,7 +29,7 @@ 
 
         $items = $data->sellFormFieldsForCategory->sellFormFieldsList->item;
 
-        return array_map(function ($item) {
+        return array_map(function($item) {
             return [
                 'fid' => $item->sellFormId,
                 'title' => $item->sellFormTitle,
@@ -87,7 +87,7 @@ 
      */
     public function finishAuctions(array $auctionIds, $cancelAllBids = 0, $finishCancelReason = '')
     {
-        $finishItemsList = array_map(function ($auctionId) use ($cancelAllBids, $finishCancelReason) {
+        $finishItemsList = array_map(function($auctionId) use ($cancelAllBids, $finishCancelReason) {
             return [
                 'finishItemId' => $auctionId,
                 'finishCancelAllBids' => $cancelAllBids,
@@ -122,7 +122,7 @@ 
     {
         $response = $this->client->doGetSiteJournalDeals(['journalStart' => $journalStart]);
         if (isset($response->siteJournalDeals->item)) {
-            return array_map(function($deal){
+            return array_map(function($deal) {
                 return new Deal($deal);
             }, $response->siteJournalDeals->item);
         }
@@ -137,7 +137,7 @@ 
      */
     public function getAuctionByItemId($itemId)
     {
-        $response =  $this->client->doGetItemFields(['itemId' => $itemId]);
+        $response = $this->client->doGetItemFields(['itemId' => $itemId]);
         if (!isset($response->itemFields->item)) {
             throw new Exception('Invalid WebAPI response: ' . print_r($response, 1));
         }