Puzzle\Assert\ArrayRelated

Complexity

Total Complexity

8

Size/Duplication

Total Lines	49
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	0

Test Coverage

Coverage

100%

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	assertSameArrayExceptOrder()	0	14	2
A	assertSameKeysAndValuesExceptOrder()	0	10	2
A	cloneArray()	0	20	4

<?php

namespace Puzzle\Assert;

trait ArrayRelated
{
    private function assertSameArrayExceptOrder(array $expectedArray, array $array, $message = '')

This method is not used, and could be removed.

    {
        $this->assertCount(count($expectedArray), $array, $message);

It seems like assertCount() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        
        $expected = $this->cloneArray($expectedArray);
        
        foreach($array as $value)
        {
            $index = array_search($value, $expected, true);
            $this->assertNotFalse($index, $message);

It seems like assertNotFalse() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            
            unset($expected[$index]);
        }
    }
    
    private function assertSameKeysAndValuesExceptOrder(array $expectedArray, array $array, $message = '')

This method is not used, and could be removed.

    {
        $this->assertCount(count($expectedArray), $array, $message);

It seems like assertCount() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        
        foreach($expectedArray as $key => $value)
        {
            $this->assertArrayHasKey($key, $array, $message);

It seems like assertArrayHasKey() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            $this->assertSame($value, $array[$key], $message);

The method assertSame() does not exist on Puzzle\Assert\ArrayRelated. Did you maybe mean assertSameArrayExceptOrder()?

        }
    }
    
    private function cloneArray(array $array)
    {
        $clone = [];
        
        foreach($array as $key => $value)
        {
            if(is_object($value))
            {
                $value = clone $value;
            }
            elseif(is_array($value))
            {
                $value = $this->cloneArray($value);
            }
            
            $clone[$key] = $value;
        }
        
        return $clone;
    }
}