ArrayRelated::assertSameArrayExceptOrder() - Code Metrics - Inspection of "test: enhance coverage" - puzzle-org/assert - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( c50550...c21ac6 )

by Nicolas

created 2017-03-10 14:46 UTC

ArrayRelated::assertSameArrayExceptOrder() A

↳ Parent: ArrayRelated

Complexity

Conditions	2
Paths	2

Size

Total Lines	14
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	9
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	14
ccs	9
cts	9
cp	1
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	7
nc	2
nop	3
crap	2

<?php

namespace Puzzle\Assert;

trait ArrayRelated
{
    private function assertSameArrayExceptOrder(array $expectedArray, array $array, $message = '')

    {
        $this->assertCount(count($expectedArray), $array, $message);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        
        $expected = $this->cloneArray($expectedArray);
        
        foreach($array as $value)
        {
            $index = array_search($value, $expected, true);
            $this->assertNotFalse($index, $message);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            
            unset($expected[$index]);
        }
    }
    
    private function assertSameKeysAndValuesExceptOrder(array $expectedArray, array $array, $message = '')

    {
        $this->assertCount(count($expectedArray), $array, $message);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        
        foreach($expectedArray as $key => $value)
        {
            $this->assertArrayHasKey($key, $array, $message);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            $this->assertSame($value, $array[$key], $message);

        }
    }
    
    private function cloneArray(array $array)
    {
        $clone = [];
        
        foreach($array as $key => $value)
        {
            if(is_object($value))
            {
                $value = clone $value;
            }
            elseif(is_array($value))
            {
                $value = $this->cloneArray($value);
            }
            
            $clone[$key] = $value;
        }
        
        return $clone;
    }
}


1		<?php
2
3		namespace Puzzle\Assert;
4
5		trait ArrayRelated
6		{
7	12	private function assertSameArrayExceptOrder(array $expectedArray, array $array, $message = '')
		0 ignored issues – show Unused Code introduced 2017-03-09 17:49 UTC by Report Bug Copy Issue Report This method is not used, and could be removed. Loading history...
8		{
9	12	$this->assertCount(count($expectedArray), $array, $message);
		0 ignored issues – show Bug introduced 2017-03-09 17:49 UTC by Report Bug Copy Issue Report It seems like `assertCount()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
10
11	9	$expected = $this->cloneArray($expectedArray);
12
13	9	foreach($array as $value)
14		{
15	9	$index = array_search($value, $expected, true);
16	9	$this->assertNotFalse($index, $message);
		0 ignored issues – show Bug introduced 2017-03-09 17:49 UTC by Report Bug Copy Issue Report It seems like `assertNotFalse()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
17
18	5	unset($expected[$index]);
19	5	}
20	1	}
21
22	5	private function assertSameKeysAndValuesExceptOrder(array $expectedArray, array $array, $message = '')
		0 ignored issues – show Unused Code introduced 2017-03-09 17:49 UTC by Report Bug Copy Issue Report This method is not used, and could be removed. Loading history...
23		{
24	5	$this->assertCount(count($expectedArray), $array, $message);
		0 ignored issues – show Bug introduced 2017-03-09 17:49 UTC by Report Bug Copy Issue Report It seems like `assertCount()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
25
26	4	foreach($expectedArray as $key => $value)
27		{
28	4	$this->assertArrayHasKey($key, $array, $message);
		0 ignored issues – show Bug introduced 2017-03-09 17:49 UTC by Report Bug Copy Issue Report It seems like `assertArrayHasKey()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
29	4	$this->assertSame($value, $array[$key], $message);
		0 ignored issues – show Bug introduced 2017-03-09 17:49 UTC by Report Bug Copy Issue Report The method `assertSame()` does not exist on `Puzzle\Assert\ArrayRelated`. Did you maybe mean `assertSameArrayExceptOrder()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
30	4	}
31	2	}
32
33	10	private function cloneArray(array $array)
34		{
35	9	$clone = [];
36
37	9	foreach($array as $key => $value)
38		{
39	9	if(is_object($value))
40	9	{
41	1	$value = clone $value;
42	1	}
43	9	elseif(is_array($value))
44		{
45	1	$value = $this->cloneArray($value);
46	1	}
47
48	10	$clone[$key] = $value;
49	9	}
50
51	9	return $clone;
52		}
53		}
54

puzzle-org / assert

Push — master ( c50550...c21ac6 )

ArrayRelated::assertSameArrayExceptOrder() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like