Puerari\Moodle\Core::getCoursesByField()

Complexity

Conditions	2
Paths	2

Size

Total Lines	9
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function getCoursesByField(/*string*/ $field, /*string*/ $value)/*: array|string*/
    {
        $validFields = ['', 'id', 'ids', 'shortname', 'idnumber', 'category'];
        if (!in_array($field, $validFields)) {
            throw new MraException("Invalid field value: '$field'.\n Valid values: " . implode(', ', $validFields));
        }
        $this->data = compact('field', 'value');

The property data does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $this->data['wsfunction'] = 'core_course_get_courses_by_field';
        return $this->execGetCurl();

It seems like execGetCurl() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }