Puerari\Moodle\Core

Complexity

Total Complexity

4

Size/Duplication

Total Lines	34
Duplicated Lines	0 %

Importance

Changes	2
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	getCoursesByField()	0	9	2
A	getCourses()	0	10	2

<?php

namespace Puerari\Moodle;

/**
 * @trait Account
 * @package Puerari\Cwp
 * @author Leandro Puerari <leandro@puerari.com.br>
 */
trait Core
{
    /**
     * @param string $field
     * @param string $value
     * @return array|string
     * @throws MraException
     */
    public function getCoursesByField(/*string*/ $field, /*string*/ $value)/*: array|string*/
    {
        $validFields = ['', 'id', 'ids', 'shortname', 'idnumber', 'category'];
        if (!in_array($field, $validFields)) {
            throw new MraException("Invalid field value: '$field'.\n Valid values: " . implode(', ', $validFields));
        }
        $this->data = compact('field', 'value');

The property data does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $this->data['wsfunction'] = 'core_course_get_courses_by_field';
        return $this->execGetCurl();

It seems like execGetCurl() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }

    /**
     * @param array $ids
     * @return array|string
     * @throws MraException
     */
    public function getCourses(array $ids)
    {
        $this->data = [];

The property data does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $this->data['wsfunction'] = 'core_course_get_courses';
        $cont = 0;
        foreach ($ids as $vlr) {
            $this->data['options']['ids'][$cont] = intval($vlr);
            ++$cont;
        }
        return $this->execGetCurl();
    }
}