psiphp / object-agent

bridge/doctrine-orm/lib/OrmAgent.php

Unused Use Statements -3 removed lines

@@ -9,8 +9,6 @@ 
 use Doctrine\Common\Util\ClassUtils;
 use Doctrine\ORM\EntityManagerInterface;
 use Doctrine\ORM\QueryBuilder;
-use Doctrine\ORM\Query as OrmQuery;
-use Doctrine\ORM\Tools\Pagination\Paginator;
 use Psi\Component\ObjectAgent\AgentInterface;
 use Psi\Component\ObjectAgent\Capabilities;
 use Psi\Component\ObjectAgent\Exception\BadMethodCallException;
@@ -18,7 +16,6 @@ 
 use Psi\Component\ObjectAgent\Query\Comparison;
 use Psi\Component\ObjectAgent\Query\Query;
 use Psi\Component\ObjectAgent\Query\Join;
-use Doctrine\ORM\Query\Expr\Select;
 
 class OrmAgent implements AgentInterface
 {

Spacing +5 added lines, -5 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare(strict_types=1);
+declare(strict_types = 1);
 
 namespace Psi\Bridge\ObjectAgent\Doctrine\Orm;
 
@@ -103,7 +103,7 @@ 
         $idField = reset($idFields);
 
         $queryBuilder = $this->entityManager->getRepository($class)->createQueryBuilder('a');
-        $queryBuilder->where($queryBuilder->expr()->in('a.' . $idField, ':identifiers'));
+        $queryBuilder->where($queryBuilder->expr()->in('a.'.$idField, ':identifiers'));
         $queryBuilder->setParameter('identifiers', $identifiers);
 
         return $queryBuilder->getQuery()->execute();
@@ -205,7 +205,7 @@ 
         // TODO: Make a clone method on the Query, which allows passing an
         //       array of parts to replace in the clone.
         $query = Query::create($query->getClassFqn(), [
-            'selects' => [ 'count(' . self::SOURCE_ALIAS . '.' . $idField . ')' ],
+            'selects' => ['count('.self::SOURCE_ALIAS.'.'.$idField.')'],
             'joins' => $query->getJoins(),
             'criteria' => $query->hasExpression() ? $query->getExpression() : null,
         ]);
@@ -245,7 +245,7 @@ 
 
         $selects = [];
         foreach ($query->getSelects() as $selectName => $selectAlias) {
-            $select = $selectName . ' ' . $selectAlias;
+            $select = $selectName.' '.$selectAlias;
             if (is_int($selectName)) {
                 $select = $selectAlias;
             }
@@ -268,7 +268,7 @@ 
         }
 
         foreach ($query->getOrderings() as $field => $order) {
-            $queryBuilder->addOrderBy(self::SOURCE_ALIAS . '.' . $field, $order);
+            $queryBuilder->addOrderBy(self::SOURCE_ALIAS.'.'.$field, $order);
         }
 
         if (null !== $query->getFirstResult()) {

lib/Query/Query.php

Doc Comments +3 added lines

@@ -60,6 +60,9 @@
         return new self($classFqn, $query['selects'], $query['joins'], $query['criteria'], $query['orderings'], $query['firstResult'], $query['maxResults']);
     }
 
+    /**
+     * @param string $value1
+     */
     public static function comparison(string $comparator, $value1, $value2): Comparison
     {
         return new Comparison($comparator, $value1, $value2);

Spacing +2 added lines, -2 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare(strict_types=1);
+declare(strict_types = 1);
 
 namespace Psi\Component\ObjectAgent\Query;
 
@@ -33,7 +33,7 @@ 
         $this->joins = $joins;
         $this->selects = $selects;
 
-        array_walk($joins, function (Join $join) {
+        array_walk($joins, function(Join $join) {
         });
     }
 

lib/Query/Converter/ArrayConverter.php

Spacing +2 added lines, -2 removed lines

@@ -67,7 +67,7 @@ 
                 'type' => Join::INNER_JOIN,
                 'join'=> null,
                 'alias' => null,
-            ], $join, [ 'join', 'alias']);
+            ], $join, ['join', 'alias']);
 
             $joinObjects[] = new Join($join['join'], $join['alias'], $join['type']);
         }
@@ -119,7 +119,7 @@ 
         if ($diff = array_diff($required, array_keys($values))) {
             throw new \InvalidArgumentException(sprintf(
                 'Keys "%s" are required for "%s"',
-                implode('", "', $diff),  json_encode($values)
+                implode('", "', $diff), json_encode($values)
             ));
         }
 

bridge/doctrine-orm/lib/ExpressionVisitor.php

Spacing +7 added lines, -7 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare(strict_types=1);
+declare(strict_types = 1);
 
 namespace Psi\Bridge\ObjectAgent\Doctrine\Orm;
 
@@ -37,7 +37,7 @@ 
                 return $this->walkComposite($expr);
         }
 
-        throw new \RuntimeException('Unknown Expression: ' . get_class($expr));
+        throw new \RuntimeException('Unknown Expression: '.get_class($expr));
     }
 
     public function getParameters()
@@ -88,7 +88,7 @@ 
                 return $this->expressionFactory->isNotNull($this->getField($field), $this->registerParameter($field, $value));
         }
 
-        throw new \RuntimeException('Unknown comparator: ' . $comparison->getComparator());
+        throw new \RuntimeException('Unknown comparator: '.$comparison->getComparator());
     }
 
     private function walkComposite(Composite $expression)
@@ -100,7 +100,7 @@ 
             $ormExpressions[] = $this->dispatch($childExpression);
         }
 
-        $method = $expression->getType() == Composite::AND ? 'andX' : 'orX';
+        $method = $expression->getType() == Composite::AND? 'andX' : 'orX';
 
         return call_user_func_array([$this->expressionFactory, $method], $ormExpressions);
     }
@@ -113,14 +113,14 @@ 
         }
 
         // otherwise use the primary source alias.
-        return $this->sourceAlias . '.' . $field;
+        return $this->sourceAlias.'.'.$field;
     }
 
     private function registerParameter(string $name, $value)
     {
-        $name = 'param' . $this->paramIndex++;
+        $name = 'param'.$this->paramIndex++;
         $this->parameters[$name] = $value;
 
-        return ':' . $name;
+        return ':'.$name;
     }
 }