Completed
Pull Request — master (#34)
by Daniel
02:15
created
lib/CellFactory.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -48,6 +48,9 @@
 block discarded – undo
48 48
         return $column->createHeader($gridContext, $options);
49 49
     }
50 50
 
51
+    /**
52
+     * @param string $columnName
53
+     */
51 54
     private function resolveOptions($columnName, ColumnInterface $column, array $options)
52 55
     {
53 56
         $resolver = new OptionsResolver();
Please login to merge, or discard this patch.
lib/Metadata/Driver/AnnotationDriver.php 1 patch
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -13,8 +13,6 @@
 block discarded – undo
13 13
 use Psi\Component\Grid\Metadata\ColumnMetadata;
14 14
 use Psi\Component\Grid\Metadata\FilterMetadata;
15 15
 use Psi\Component\Grid\Metadata\GridMetadata;
16
-use Psi\Component\Grid\Metadata\SourceMetadata;
17
-use Psi\Component\Grid\Metadata\ViewMetadata;
18 16
 
19 17
 class AnnotationDriver implements DriverInterface
20 18
 {
Please login to merge, or discard this patch.
lib/Source/PropertySource.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -8,7 +8,6 @@
 block discarded – undo
8 8
 use Psi\Component\Grid\ColumnInterface;
9 9
 use Psi\Component\Grid\GridContext;
10 10
 use Psi\Component\Grid\RowData;
11
-use Psi\Component\Grid\View\Cell as Cell;
12 11
 use Psi\Component\Grid\View\Header;
13 12
 use Symfony\Component\OptionsResolver\OptionsResolver;
14 13
 use Symfony\Component\PropertyAccess\PropertyAccess;
Please login to merge, or discard this patch.
lib/Metadata/Driver/DriverUtil.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -24,12 +24,12 @@
 block discarded – undo
24 24
     private static function resolveConfigurableReference($options)
25 25
     {
26 26
         if (is_string($options)) {
27
-            $options = [ 'type' => $options ];
27
+            $options = ['type' => $options];
28 28
         }
29 29
 
30 30
         $type = isset($options['type']) ? $options['type'] : null;
31 31
         unset($options['type']);
32 32
 
33
-        return [ $type, $options ];
33
+        return [$type, $options];
34 34
     }
35 35
 }
Please login to merge, or discard this patch.
lib/Metadata/AbstractConfigurable.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -9,7 +9,7 @@
 block discarded – undo
9 9
 
10 10
     public function __construct(string $type = null, array $options = [])
11 11
     {
12
-        $this->type = $type ? : 'property';
12
+        $this->type = $type ?: 'property';
13 13
         $this->options = $options;
14 14
     }
15 15
 
Please login to merge, or discard this patch.
lib/Metadata/SourceMetadata.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -6,7 +6,7 @@
 block discarded – undo
6 6
 {
7 7
     public function __construct(string $type = null, array $options = [])
8 8
     {
9
-        $type = $type ? : 'property';
9
+        $type = $type ?: 'property';
10 10
 
11 11
         parent::__construct($type, $options);
12 12
     }
Please login to merge, or discard this patch.
lib/Metadata/ViewMetadata.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -6,7 +6,7 @@
 block discarded – undo
6 6
 {
7 7
     public function __construct(string $type = null, array $options = [])
8 8
     {
9
-        $type = $type ? : 'scalar';
9
+        $type = $type ?: 'scalar';
10 10
 
11 11
         parent::__construct($type, $options);
12 12
     }
Please login to merge, or discard this patch.